Completed
Pull Request — 3.x (#4824)
by Maximilian
04:02
created
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1165,6 +1165,8 @@  discard block
 block discarded – undo
1165 1165
 
1166 1166
     /**
1167 1167
      * {@inheritdoc}
1168
+     * @param string $name
1169
+     * @param string $adminCode
1168 1170
      */
1169 1171
     public function isCurrentRoute($name, $adminCode = null)
1170 1172
     {
@@ -2448,7 +2450,7 @@  discard block
 block discarded – undo
2448 2450
      *
2449 2451
      * @param string $context
2450 2452
      *
2451
-     * @return array
2453
+     * @return string[]
2452 2454
      */
2453 2455
     public function getPermissionsShow($context)
2454 2456
     {
@@ -2692,7 +2694,7 @@  discard block
 block discarded – undo
2692 2694
     /**
2693 2695
      * Set custom per page options.
2694 2696
      *
2695
-     * @param array $options
2697
+     * @param integer[] $options
2696 2698
      */
2697 2699
     public function setPerPageOptions(array $options)
2698 2700
     {
@@ -2854,6 +2856,7 @@  discard block
 block discarded – undo
2854 2856
 
2855 2857
     /**
2856 2858
      * {@inheritdoc}
2859
+     * @param string $action
2857 2860
      */
2858 2861
     public function configureActionButtons($action, $object = null)
2859 2862
     {
@@ -2985,7 +2988,6 @@  discard block
 block discarded – undo
2985 2988
     }
2986 2989
 
2987 2990
     /**
2988
-     * @param FormMapper $form
2989 2991
      */
2990 2992
     final public function getSearchResultLink($object)
2991 2993
     {
@@ -3102,7 +3104,7 @@  discard block
 block discarded – undo
3102 3104
      * NEXT_MAJOR: remove this method.
3103 3105
      *
3104 3106
      * @param MenuItemInterface $menu
3105
-     * @param                   $action
3107
+     * @param                   string $action
3106 3108
      * @param AdminInterface    $childAdmin
3107 3109
      *
3108 3110
      * @return mixed
Please login to merge, or discard this patch.
src/Admin/FieldDescriptionCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     }
31 31
 
32 32
     /**
33
-     * @return array
33
+     * @return FieldDescriptionInterface[]
34 34
      */
35 35
     public function getElements()
36 36
     {
Please login to merge, or discard this patch.
src/Admin/Pool.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
     }
279 279
 
280 280
     /**
281
-     * @param array $adminServiceIds
281
+     * @param string[] $adminServiceIds
282 282
      */
283 283
     public function setAdminServiceIds(array $adminServiceIds)
284 284
     {
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
     }
287 287
 
288 288
     /**
289
-     * @return array
289
+     * @return string[]
290 290
      */
291 291
     public function getAdminServiceIds()
292 292
     {
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
     }
319 319
 
320 320
     /**
321
-     * @return array
321
+     * @return string[]
322 322
      */
323 323
     public function getTemplates()
324 324
     {
Please login to merge, or discard this patch.
src/Datagrid/Pager.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -459,7 +459,7 @@  discard block
 block discarded – undo
459 459
      * Returns a parameter.
460 460
      *
461 461
      * @param string $name
462
-     * @param mixed  $default
462
+     * @param null|string  $default
463 463
      *
464 464
      * @return mixed
465 465
      */
@@ -484,7 +484,7 @@  discard block
 block discarded – undo
484 484
      * Sets a parameter.
485 485
      *
486 486
      * @param string $name
487
-     * @param mixed  $value
487
+     * @param string  $value
488 488
      */
489 489
     public function setParameter($name, $value)
490 490
     {
@@ -595,7 +595,7 @@  discard block
 block discarded – undo
595 595
     }
596 596
 
597 597
     /**
598
-     * @param array $countColumn
598
+     * @param string[] $countColumn
599 599
      *
600 600
      * @return array
601 601
      */
Please login to merge, or discard this patch.
src/Generator/AdminGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
 
39 39
     /**
40 40
      * @param ModelManagerInterface $modelManager
41
-     * @param array|string          $skeletonDirectories
41
+     * @param string          $skeletonDirectories
42 42
      */
43 43
     public function __construct(ModelManagerInterface $modelManager, $skeletonDirectories)
44 44
     {
Please login to merge, or discard this patch.
src/Generator/ControllerGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
     private $file;
32 32
 
33 33
     /**
34
-     * @param array|string $skeletonDirectory
34
+     * @param string $skeletonDirectory
35 35
      */
36 36
     public function __construct($skeletonDirectory)
37 37
     {
Please login to merge, or discard this patch.
src/Twig/Extension/SonataAdminExtension.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     /**
124 124
      * render a list element from the FieldDescription.
125 125
      *
126
-     * @param mixed                     $object
126
+     * @param \stdClass                     $object
127 127
      * @param FieldDescriptionInterface $fieldDescription
128 128
      * @param array                     $params
129 129
      *
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
      * render a view element.
227 227
      *
228 228
      * @param FieldDescriptionInterface $fieldDescription
229
-     * @param mixed                     $object
229
+     * @param \stdClass                     $object
230 230
      *
231 231
      * @return string
232 232
      */
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
     /**
366 366
      * Get the identifiers as a string that is safe to use in a url.
367 367
      *
368
-     * @param object         $model
368
+     * @param \stdClass         $model
369 369
      * @param AdminInterface $admin
370 370
      *
371 371
      * @return string string representation of the id that is safe to use in a url
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
     /**
391 391
      * @param $type
392 392
      *
393
-     * @return string|bool
393
+     * @return string|false
394 394
      */
395 395
     public function getXEditableType($type)
396 396
     {
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
      * @param FieldDescriptionInterface $fieldDescription
448 448
      * @param string                    $defaultTemplate
449 449
      *
450
-     * @return \Twig_TemplateInterface
450
+     * @return \Twig_Template
451 451
      */
452 452
     protected function getTemplate(
453 453
         FieldDescriptionInterface $fieldDescription,
Please login to merge, or discard this patch.
tests/Admin/Extension/LockExtensionTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -195,6 +195,10 @@
 block discarded – undo
195 195
         return new FormMapper($contractor->reveal(), $formBuilder, $this->admin->reveal());
196 196
     }
197 197
 
198
+    /**
199
+     * @param string $uniqid
200
+     * @param Request $request
201
+     */
198 202
     private function configureAdmin($uniqid = null, $request = null, $modelManager = null)
199 203
     {
200 204
         $this->admin->getUniqid()->willReturn($uniqid);
Please login to merge, or discard this patch.
tests/Controller/CRUDControllerTest.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -3759,6 +3759,9 @@  discard block
 block discarded – undo
3759 3759
         ];
3760 3760
     }
3761 3761
 
3762
+    /**
3763
+     * @param string $method
3764
+     */
3762 3765
     private function assertLoggerLogsModelManagerException($subject, $method)
3763 3766
     {
3764 3767
         $exception = new ModelManagerException(
@@ -3781,6 +3784,10 @@  discard block
 block discarded – undo
3781 3784
             ]);
3782 3785
     }
3783 3786
 
3787
+    /**
3788
+     * @param string $id
3789
+     * @param string $domain
3790
+     */
3784 3791
     private function expectTranslate($id, array $parameters = [], $domain = null, $locale = null)
3785 3792
     {
3786 3793
         $this->translator->expects($this->once())
Please login to merge, or discard this patch.