Issues in ObjectAclManipulatorTest.php - New Issues - Inspection of "Merge 3.x into master" - sonata-project/SonataAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a97f84...b5df1f )

unknown

created 2019-02-23 01:00 UTC

tests/Util/ObjectAclManipulatorTest.php (1 issue)

Labels

Bug 1

Severity

Major 1

Sonata CI 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\AdminBundle\Tests\Util;

use PHPUnit\Framework\TestCase;
use Prophecy\Argument;
use Sonata\AdminBundle\Admin\AdminInterface;
use Sonata\AdminBundle\Security\Handler\AclSecurityHandlerInterface;
use Sonata\AdminBundle\Tests\Fixtures\Util\DummyObjectAclManipulator;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Security\Acl\Domain\UserSecurityIdentity;
use Symfony\Component\Security\Acl\Model\AclInterface;
use Symfony\Component\Security\Acl\Model\ObjectIdentityInterface;

/**
 * @author Grégoire Paris <[email protected]>
 */
class ObjectAclManipulatorTest extends TestCase
{
    protected function setUp(): void
    {
        $this->output = $this->prophesize(OutputInterface::class);
        $this->admin = $this->prophesize(AdminInterface::class);
        $this->oids = new \ArrayIterator([
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->prophesize(ObjectIdentityInterface::class)->reveal(),
            $this->prophesize(ObjectIdentityInterface::class)->reveal(),
        ]);
        $this->securityIdentity = new UserSecurityIdentity('Michael', 'stdClass');
    }

    public function testConfigureAclsIgnoresNonAclSecurityHandlers(): void
    {
        $this->admin->getSecurityHandler()->shouldBeCalled();
        $this->admin->getCode()->shouldBeCalled()->willReturn('test');
        $this->output->writeln(Argument::allof(
            Argument::containingString('ignoring'),
            Argument::containingString('test')
        ))->shouldBeCalled();
        $manipulator = new DummyObjectAclManipulator();
        $this->assertSame(
            [0, 0],
            $manipulator->configureAcls(
                $this->output->reveal(),
                $this->admin->reveal(),
                $this->oids,
                $this->securityIdentity
            )
        );
    }

    public function testConfigureAcls(): void
    {
        $securityHandler = $this->prophesize(AclSecurityHandlerInterface::class);
        $acls = $this->prophesize('SplObjectStorage');
        $acls->contains(Argument::type(ObjectIdentityInterface::class))
            ->shouldBeCalled()
            ->willReturn(false, true);
        $acl = $this->prophesize(AclInterface::class)->reveal();
        $acls->offsetGet(Argument::Type(ObjectIdentityInterface::class))
            ->shouldBeCalled()
            ->willReturn($acl);
        $securityHandler->findObjectAcls($this->oids)->shouldBeCalled()->willReturn($acls->reveal());
        $securityHandler->createAcl(Argument::type(ObjectIdentityInterface::class))->shouldBeCalled()->willReturn($acl);
        $securityHandler->addObjectOwner($acl, Argument::type(UserSecurityIdentity::class))->shouldBeCalled();
        $securityHandler->buildSecurityInformation($this->admin)->shouldBeCalled()->willReturn([]);
        $securityHandler->addObjectClassAces($acl, [])->shouldBeCalled();
        $securityHandler->updateAcl($acl)->shouldBeCalled()->willThrow(new \Exception('test exception'));
        $this->output->writeln(Argument::allof(
            Argument::containingString('ignoring'),
            Argument::containingString('test exception')
        ))->shouldBeCalled();

        $this->admin->getSecurityHandler()->shouldBeCalled()->willReturn($securityHandler->reveal());

        $manipulator = new DummyObjectAclManipulator();

        $this->assertSame(
            [1, 1],
            $manipulator->configureAcls(
                $this->output->reveal(),
                $this->admin->reveal(),
                $this->oids,
                $this->securityIdentity
            )
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\AdminBundle\Tests\Util;
15
16			use PHPUnit\Framework\TestCase;
17			use Prophecy\Argument;
18			use Sonata\AdminBundle\Admin\AdminInterface;
19			use Sonata\AdminBundle\Security\Handler\AclSecurityHandlerInterface;
20			use Sonata\AdminBundle\Tests\Fixtures\Util\DummyObjectAclManipulator;
21			use Symfony\Component\Console\Output\OutputInterface;
22			use Symfony\Component\Security\Acl\Domain\UserSecurityIdentity;
23			use Symfony\Component\Security\Acl\Model\AclInterface;
24			use Symfony\Component\Security\Acl\Model\ObjectIdentityInterface;
25
26			/**
27			* @author Grégoire Paris <[email protected]>
28			*/
29			class ObjectAclManipulatorTest extends TestCase
30			{
31			protected function setUp(): void
32			{
33			$this->output = $this->prophesize(OutputInterface::class);
34			$this->admin = $this->prophesize(AdminInterface::class);
35			$this->oids = new \ArrayIterator([
			0 ignored issues – show Bug introduced 2017-11-02 14:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `oids` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36			$this->prophesize(ObjectIdentityInterface::class)->reveal(),
37			$this->prophesize(ObjectIdentityInterface::class)->reveal(),
38			]);
39			$this->securityIdentity = new UserSecurityIdentity('Michael', 'stdClass');
40			}
41
42			public function testConfigureAclsIgnoresNonAclSecurityHandlers(): void
43			{
44			$this->admin->getSecurityHandler()->shouldBeCalled();
45			$this->admin->getCode()->shouldBeCalled()->willReturn('test');
46			$this->output->writeln(Argument::allof(
47			Argument::containingString('ignoring'),
48			Argument::containingString('test')
49			))->shouldBeCalled();
50			$manipulator = new DummyObjectAclManipulator();
51			$this->assertSame(
52			[0, 0],
53			$manipulator->configureAcls(
54			$this->output->reveal(),
55			$this->admin->reveal(),
56			$this->oids,
57			$this->securityIdentity
58			)
59			);
60			}
61
62			public function testConfigureAcls(): void
63			{
64			$securityHandler = $this->prophesize(AclSecurityHandlerInterface::class);
65			$acls = $this->prophesize('SplObjectStorage');
66			$acls->contains(Argument::type(ObjectIdentityInterface::class))
67			->shouldBeCalled()
68			->willReturn(false, true);
69			$acl = $this->prophesize(AclInterface::class)->reveal();
70			$acls->offsetGet(Argument::Type(ObjectIdentityInterface::class))
71			->shouldBeCalled()
72			->willReturn($acl);
73			$securityHandler->findObjectAcls($this->oids)->shouldBeCalled()->willReturn($acls->reveal());
74			$securityHandler->createAcl(Argument::type(ObjectIdentityInterface::class))->shouldBeCalled()->willReturn($acl);
75			$securityHandler->addObjectOwner($acl, Argument::type(UserSecurityIdentity::class))->shouldBeCalled();
76			$securityHandler->buildSecurityInformation($this->admin)->shouldBeCalled()->willReturn([]);
77			$securityHandler->addObjectClassAces($acl, [])->shouldBeCalled();
78			$securityHandler->updateAcl($acl)->shouldBeCalled()->willThrow(new \Exception('test exception'));
79			$this->output->writeln(Argument::allof(
80			Argument::containingString('ignoring'),
81			Argument::containingString('test exception')
82			))->shouldBeCalled();
83
84			$this->admin->getSecurityHandler()->shouldBeCalled()->willReturn($securityHandler->reveal());
85
86			$manipulator = new DummyObjectAclManipulator();
87
88			$this->assertSame(
89			[1, 1],
90			$manipulator->configureAcls(
91			$this->output->reveal(),
92			$this->admin->reveal(),
93			$this->oids,
94			$this->securityIdentity
95			)
96			);
97			}
98			}
99

sonata-project / SonataAdminBundle

Push — master ( a97f84...b5df1f )

tests/Util/ObjectAclManipulatorTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like