ModelChoiceLoaderTest::testLoadFromEntityWithSamePropertyValues() - Code Metrics - Inspection of "Merge 3.x into master" - sonata-project/SonataAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a97f84...b5df1f )

unknown

created 2019-02-23 01:00 UTC

testLoadFromEntityWithSamePropertyValues() A

↳ Parent: ModelChoiceLoaderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	33
rs	9.392
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\AdminBundle\Tests\Form\ChoiceList;

use PHPUnit\Framework\TestCase;
use Sonata\AdminBundle\Form\ChoiceList\ModelChoiceLoader;
use Sonata\AdminBundle\Model\ModelManagerInterface;
use Sonata\AdminBundle\Tests\Fixtures\Bundle\Entity\Foo;

class ModelChoiceLoaderTest extends TestCase
{
    private $modelManager = null;

    public function setUp(): void
    {
        $this->modelManager = $this->getMockForAbstractClass(ModelManagerInterface::class);
    }

    public function testLoadFromEntityWithSamePropertyValues(): void
    {
        $fooA = new Foo();
        $fooA->setBar(1);
        $fooA->setBaz('baz');

        $fooB = new Foo();
        $fooB->setBar(2);
        $fooB->setBaz('baz');

        $this->modelManager->expects($this->once())
            ->method('findBy')
            ->will($this->returnValue([$fooA, $fooB]));

        $this->modelManager->expects($this->any())
            ->method('getIdentifierValues')
            ->will($this->returnCallback(function (Foo $foo) {
                return [$foo->getBar()];
            }));

        $modelChoiceLoader = new ModelChoiceLoader(
            $this->modelManager,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            \Sonata\AdminBundle\Tests\Fixtures\Entity\Foo::class,
            'baz'
        );

        $expectedChoices = [
            1 => 'baz (id: 1)',
            2 => 'baz (id: 2)',
        ];

        $this->assertSame($expectedChoices, $modelChoiceLoader->loadChoiceList()->getOriginalKeys());
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\AdminBundle\Tests\Form\ChoiceList;
15
16			use PHPUnit\Framework\TestCase;
17			use Sonata\AdminBundle\Form\ChoiceList\ModelChoiceLoader;
18			use Sonata\AdminBundle\Model\ModelManagerInterface;
19			use Sonata\AdminBundle\Tests\Fixtures\Bundle\Entity\Foo;
20
21			class ModelChoiceLoaderTest extends TestCase
22			{
23			private $modelManager = null;
24
25			public function setUp(): void
26			{
27			$this->modelManager = $this->getMockForAbstractClass(ModelManagerInterface::class);
28			}
29
30			public function testLoadFromEntityWithSamePropertyValues(): void
31			{
32			$fooA = new Foo();
33			$fooA->setBar(1);
34			$fooA->setBaz('baz');
35
36			$fooB = new Foo();
37			$fooB->setBar(2);
38			$fooB->setBaz('baz');
39
40			$this->modelManager->expects($this->once())
41			->method('findBy')
42			->will($this->returnValue([$fooA, $fooB]));
43
44			$this->modelManager->expects($this->any())
45			->method('getIdentifierValues')
46			->will($this->returnCallback(function (Foo $foo) {
47			return [$foo->getBar()];
48			}));
49
50			$modelChoiceLoader = new ModelChoiceLoader(
51			$this->modelManager,
			0 ignored issues – show Documentation introduced 2019-02-09 11:04 UTC by Report Bug Copy Issue Report `$this->modelManager` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Sonata\AdminBundl...\ModelManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52			\Sonata\AdminBundle\Tests\Fixtures\Entity\Foo::class,
53			'baz'
54			);
55
56			$expectedChoices = [
57			1 => 'baz (id: 1)',
58			2 => 'baz (id: 2)',
59			];
60
61			$this->assertSame($expectedChoices, $modelChoiceLoader->loadChoiceList()->getOriginalKeys());
62			}
63			}
64

sonata-project / SonataAdminBundle

Push — master ( a97f84...b5df1f )

testLoadFromEntityWithSamePropertyValues() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like