sonata-project / SonataAdminBundle

Command/GenerateAdminCommand.php

Doc Comments +5 added lines

@@ -291,6 +291,11 @@
         return $questionHelper->ask($input, $output, $question);
     }
 
+    /**
+     * @param string $questionText
+     * @param string $default
+     * @param string $separator
+     */
     private function askConfirmation(InputInterface $input, OutputInterface $output, $questionText, $default, $separator)
     {
         $questionHelper = $this->getQuestionHelper();

Controller/CoreController.php

Doc Comments -2 removed lines

@@ -37,7 +37,6 @@ 
     }
 
     /**
-     * @param Request $request
      *
      * @return string
      */
@@ -51,7 +50,6 @@ 
     }
 
     /**
-     * @param Request $request
      *
      * @return Response
      */

Controller/CRUDController.php

Doc Comments +10 added lines, -19 removed lines

@@ -175,6 +175,7 @@ 
 
     /**
      * {@inheritdoc}
+     * @param null|string $view
      */
     public function render($view, array $parameters = array(), Response $response = null)
     {
@@ -191,6 +192,9 @@ 
         return parent::render($view, $parameters, $response);
     }
 
+    /**
+     * @param ModelManagerException $e
+     */
     private function logModelManagerException($e)
     {
         $context = array('exception' => $e);
@@ -260,7 +264,7 @@ 
     /**
      * Delete action.
      *
-     * @param int|string|null $id
+     * @param integer $id
      *
      * @return Response|RedirectResponse
      *
@@ -429,7 +433,6 @@ 
      * Redirect the user depend on this choice.
      *
      * @param object  $object
-     * @param Request $request
      *
      * @return RedirectResponse
      */
@@ -468,7 +471,6 @@ 
     /**
      * Batch action.
      *
-     * @param Request $request
      *
      * @return Response|RedirectResponse
      *
@@ -582,7 +584,6 @@ 
     /**
      * Create action.
      *
-     * @param Request $request
      *
      * @return Response
      *
@@ -679,7 +680,6 @@ 
     /**
      * Returns true if the preview is requested to be shown.
      *
-     * @param Request $request
      *
      * @return bool
      */
@@ -693,7 +693,6 @@ 
     /**
      * Returns true if the preview has been approved.
      *
-     * @param Request $request
      *
      * @return bool
      */
@@ -710,7 +709,6 @@ 
      * That means either a preview is requested or the preview has already been shown
      * and it got approved/declined.
      *
-     * @param Request $request
      *
      * @return bool
      */
@@ -725,7 +723,6 @@ 
     /**
      * Returns true if the preview has been declined.
      *
-     * @param Request $request
      *
      * @return bool
      */
@@ -740,7 +737,6 @@ 
      * Show action.
      *
      * @param int|string|null $id
-     * @param Request         $request
      *
      * @return Response
      *
@@ -775,7 +771,6 @@ 
      * Show history revisions for object.
      *
      * @param int|string|null $id
-     * @param Request         $request
      *
      * @return Response
      *
@@ -823,9 +818,8 @@ 
     /**
      * View history revision of object.
      *
-     * @param int|string|null $id
+     * @param null|integer $id
      * @param string|null     $revision
-     * @param Request         $request
      *
      * @return Response
      *
@@ -886,10 +880,9 @@ 
     /**
      * Compare history revisions of object.
      *
-     * @param int|string|null $id
-     * @param int|string|null $base_revision
-     * @param int|string|null $compare_revision
-     * @param Request         $request
+     * @param null|integer $id
+     * @param null|integer $base_revision
+     * @param null|integer $compare_revision
      *
      * @return Response
      *
@@ -963,7 +956,7 @@ 
     /**
      * Export data to specified format.
      *
-     * @param Request $reques
+     * @param Request $request
      *
      * @return Response
      *
@@ -1030,7 +1023,6 @@ 
      * Returns the Response object associated to the acl action.
      *
      * @param int|string|null $id
-     * @param Request         $request
      *
      * @return Response|RedirectResponse
      *
@@ -1108,7 +1100,6 @@ 
      * Validate CSRF token for action without form.
      *
      * @param string  $intention
-     * @param Request $request
      *
      * @throws HttpException
      */

Controller/HelperController.php

Doc Comments +1 added lines, -1 removed lines

@@ -428,7 +428,7 @@
      * @param AdminInterface $admin
      * @param string         $field
      *
-     * @return \Symfony\Component\Form\FormInterface
+     * @return \Sonata\AdminBundle\Admin\FieldDescriptionInterface
      *
      * @throws \RuntimeException
      */

Datagrid/DatagridMapper.php

Doc Comments +1 added lines, -1 removed lines

@@ -114,7 +114,7 @@
     /**
      * @param array $keys field names
      *
-     * @return \Sonata\AdminBundle\Datagrid\ListMapper
+     * @return DatagridMapper
      */
     public function reorder(array $keys)
     {

Datagrid/Pager.php

Doc Comments +4 added lines, -4 removed lines

@@ -58,7 +58,7 @@ 
     /**
      * Returns the current pager's max record limit.
      *
-     * @return int
+     * @return boolean
      */
     public function getMaxRecordLimit()
     {
@@ -407,7 +407,7 @@ 
      * Returns a parameter.
      *
      * @param string $name
-     * @param mixed  $default
+     * @param null|string  $default
      *
      * @return mixed
      */
@@ -432,7 +432,7 @@ 
      * Sets a parameter.
      *
      * @param string $name
-     * @param mixed  $value
+     * @param string  $value
      */
     public function setParameter($name, $value)
     {
@@ -571,7 +571,7 @@ 
     }
 
     /**
-     * @param array $countColumn
+     * @param string[] $countColumn
      *
      * @return array
      */

Tests/Admin/PoolTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -253,7 +253,7 @@
     }
 
     /**
-     * @return Symfony\Component\DependencyInjection\ContainerInterface - the mock of container interface
+     * @return \Symfony\Component\DependencyInjection\ContainerInterface - the mock of container interface
      */
     private function getContainer()
     {

Tests/Controller/CRUDControllerTest.php

Doc Comments +7 added lines

@@ -663,6 +663,9 @@ 
         $this->assertSame('list?filter%5Bfoo%5D=bar', $result->getTargetUrl());
     }
 
+    /**
+     * @param string $method
+     */
     private function assertLoggerLogsModelManagerException($subject, $method)
     {
         $exception = new ModelManagerException(
@@ -2972,6 +2975,10 @@ 
         );
     }
 
+    /**
+     * @param string $id
+     * @param string $domain
+     */
     private function expectTranslate($id, array $parameters = array(), $domain = null, $locale = null)
     {
         $this->admin->expects($this->once())

Tests/Show/ShowMapperTest.php

Doc Comments +4 added lines

@@ -223,6 +223,10 @@
             ), ), true), print_r($this->admin->getShowGroups(), true));
     }
 
+    /**
+     * @param string $name
+     * @param string $label
+     */
     private function getFieldDescriptionMock($name = null, $label = null)
     {
         $fieldDescription = $this->getMockForAbstractClass('Sonata\AdminBundle\Admin\BaseFieldDescription');