Completed
Pull Request — 2.x (#5811)
by
unknown
17:25
created
Datagrid/ListMapper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
      * @throws \RuntimeException
68 68
      *
69 69
      * @param mixed $name
70
-     * @param mixed $type
70
+     * @param string|null $type
71 71
      * @param array $fieldDescriptionOptions
72 72
      *
73 73
      * @return ListMapper
Please login to merge, or discard this patch.
Generator/AdminGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
 
39 39
     /**
40 40
      * @param ModelManagerInterface $modelManager
41
-     * @param array|string          $skeletonDirectories
41
+     * @param string          $skeletonDirectories
42 42
      */
43 43
     public function __construct(ModelManagerInterface $modelManager, $skeletonDirectories)
44 44
     {
Please login to merge, or discard this patch.
Generator/ControllerGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
     private $file;
32 32
 
33 33
     /**
34
-     * @param array|string $skeletonDirectory
34
+     * @param string $skeletonDirectory
35 35
      */
36 36
     public function __construct($skeletonDirectory)
37 37
     {
Please login to merge, or discard this patch.
Tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -257,6 +257,12 @@
 block discarded – undo
257 257
         ), array_keys($this->datagrid->getFilters()));
258 258
     }
259 259
 
260
+    /**
261
+     * @param string $name
262
+     * @param string $label
263
+     *
264
+     * @return string
265
+     */
260 266
     private function getFieldDescriptionMock($name = null, $label = null)
261 267
     {
262 268
         $fieldDescription = $this->getMockForAbstractClass('Sonata\AdminBundle\Admin\BaseFieldDescription');
Please login to merge, or discard this patch.
Tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -245,6 +245,10 @@
 block discarded – undo
245 245
         ), true), print_r($this->fieldDescriptionCollection->getElements(), true));
246 246
     }
247 247
 
248
+    /**
249
+     * @param string $name
250
+     * @param string $label
251
+     */
248 252
     private function getFieldDescriptionMock($name = null, $label = null)
249 253
     {
250 254
         $fieldDescription = $this->getMockForAbstractClass('Sonata\AdminBundle\Admin\BaseFieldDescription');
Please login to merge, or discard this patch.
Tests/Datagrid/PagerTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -640,6 +640,10 @@
 block discarded – undo
640 640
         $this->assertSame(null, $this->pager->getQuery());
641 641
     }
642 642
 
643
+    /**
644
+     * @param Pager $obj
645
+     * @param string $name
646
+     */
643 647
     protected function callMethod($obj, $name, array $args = array())
644 648
     {
645 649
         $class = new \ReflectionClass($obj);
Please login to merge, or discard this patch.
Tests/Fixtures/Admin/PostAdmin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -8,6 +8,9 @@
 block discarded – undo
8 8
 {
9 9
     protected $metadataClass = null;
10 10
 
11
+    /**
12
+     * @param string $associationMapping
13
+     */
11 14
     public function setParentAssociationMapping($associationMapping)
12 15
     {
13 16
         $this->parentAssociationMapping = $associationMapping;
Please login to merge, or discard this patch.
Admin/Admin.php 1 patch
Doc Comments   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -515,7 +515,7 @@  discard block
 block discarded – undo
515 515
      * Configures the tab menu in your admin.
516 516
      *
517 517
      * @param MenuItemInterface $menu
518
-     * @param                   $action
518
+     * @param                   string $action
519 519
      * @param AdminInterface    $childAdmin
520 520
      *
521 521
      * @return mixed
@@ -879,7 +879,7 @@  discard block
 block discarded – undo
879 879
      * Returns the name of the parent related field, so the field can be use to set the default
880 880
      * value (ie the parent object) or to filter the object.
881 881
      *
882
-     * @return string the name of the parent related field
882
+     * @return \ReflectionProperty the name of the parent related field
883 883
      */
884 884
     public function getParentAssociationMapping()
885 885
     {
@@ -1588,6 +1588,7 @@  discard block
 block discarded – undo
1588 1588
 
1589 1589
     /**
1590 1590
      * {@inheritdoc}
1591
+     * @param string $key
1591 1592
      */
1592 1593
     public function removeFieldFromFormGroup($key)
1593 1594
     {
@@ -2179,7 +2180,7 @@  discard block
 block discarded – undo
2179 2180
      * @param string $id
2180 2181
      * @param int    $count
2181 2182
      * @param array  $parameters
2182
-     * @param null   $domain
2183
+     * @param string   $domain
2183 2184
      * @param null   $locale
2184 2185
      *
2185 2186
      * @return string the translated string
@@ -2430,7 +2431,7 @@  discard block
 block discarded – undo
2430 2431
     /**
2431 2432
      * Set the roles and permissions per role.
2432 2433
      *
2433
-     * @param array $information
2434
+     * @param string[] $information
2434 2435
      */
2435 2436
     public function setSecurityInformation(array $information)
2436 2437
     {
@@ -2450,7 +2451,7 @@  discard block
 block discarded – undo
2450 2451
      *
2451 2452
      * @param string $context
2452 2453
      *
2453
-     * @return array
2454
+     * @return string[]
2454 2455
      */
2455 2456
     public function getPermissionsShow($context)
2456 2457
     {
@@ -2686,7 +2687,7 @@  discard block
 block discarded – undo
2686 2687
     /**
2687 2688
      * Set custom per page options.
2688 2689
      *
2689
-     * @param array $options
2690
+     * @param integer[] $options
2690 2691
      */
2691 2692
     public function setPerPageOptions(array $options)
2692 2693
     {
Please login to merge, or discard this patch.
Admin/AdminInterface.php 1 patch
Doc Comments   +51 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,6 +30,7 @@  discard block
 block discarded – undo
30 30
 {
31 31
     /**
32 32
      * @param \Sonata\AdminBundle\Builder\FormContractorInterface $formContractor
33
+     * @return void
33 34
      */
34 35
     public function setFormContractor(FormContractorInterface $formContractor);
35 36
 
@@ -37,6 +38,7 @@  discard block
 block discarded – undo
37 38
      * Set ListBuilder.
38 39
      *
39 40
      * @param ListBuilderInterface $listBuilder
41
+     * @return void
40 42
      */
41 43
     public function setListBuilder(ListBuilderInterface $listBuilder);
42 44
 
@@ -51,6 +53,7 @@  discard block
 block discarded – undo
51 53
      * Set DatagridBuilder.
52 54
      *
53 55
      * @param \Sonata\AdminBundle\Builder\DatagridBuilderInterface $datagridBuilder
56
+     * @return void
54 57
      */
55 58
     public function setDatagridBuilder(DatagridBuilderInterface $datagridBuilder);
56 59
 
@@ -65,6 +68,7 @@  discard block
 block discarded – undo
65 68
      * Set translator.
66 69
      *
67 70
      * @param \Symfony\Component\Translation\TranslatorInterface $translator
71
+     * @return void
68 72
      */
69 73
     public function setTranslator(TranslatorInterface $translator);
70 74
 
@@ -77,16 +81,19 @@  discard block
 block discarded – undo
77 81
 
78 82
     /**
79 83
      * @param \Symfony\Component\HttpFoundation\Request $request
84
+     * @return void
80 85
      */
81 86
     public function setRequest(Request $request);
82 87
 
83 88
     /**
84 89
      * @param Pool $pool
90
+     * @return void
85 91
      */
86 92
     public function setConfigurationPool(Pool $pool);
87 93
 
88 94
     /**
89 95
      * @param \Sonata\AdminBundle\Route\RouteGeneratorInterface $routeGenerator
96
+     * @return void
90 97
      */
91 98
     public function setRouteGenerator(RouteGeneratorInterface $routeGenerator);
92 99
 
@@ -102,6 +109,7 @@  discard block
 block discarded – undo
102 109
 
103 110
     /**
104 111
      * @param \Sonata\AdminBundle\Admin\FieldDescriptionInterface $fieldDescription
112
+     * @return void
105 113
      */
106 114
     public function attachAdminClass(FieldDescriptionInterface $fieldDescription);
107 115
 
@@ -114,6 +122,7 @@  discard block
 block discarded – undo
114 122
      * Set base controller name.
115 123
      *
116 124
      * @param string $baseControllerName
125
+     * @return void
117 126
      */
118 127
     public function setBaseControllerName($baseControllerName);
119 128
 
@@ -159,7 +168,7 @@  discard block
 block discarded – undo
159 168
     public function generateMenuUrl($name, array $parameters = array(), $absolute = false);
160 169
 
161 170
     /**
162
-     * @return \Sonata\AdminBundle\Model\ModelManagerInterface;
171
+     * @return \Sonata\AdminBundle\Model\ModelManagerInterface
163 172
      */
164 173
     public function getModelManager();
165 174
 
@@ -238,6 +247,7 @@  discard block
 block discarded – undo
238 247
 
239 248
     /**
240 249
      * @param \Sonata\AdminBundle\Admin\FieldDescriptionInterface $parentFieldDescription
250
+     * @return void
241 251
      */
242 252
     public function setParentFieldDescription(FieldDescriptionInterface $parentFieldDescription);
243 253
 
@@ -260,7 +270,7 @@  discard block
 block discarded – undo
260 270
      *
261 271
      * @param string $id
262 272
      * @param array  $parameters
263
-     * @param null   $domain
273
+     * @param string   $domain
264 274
      * @param null   $locale
265 275
      *
266 276
      * @return string the translated string
@@ -302,6 +312,7 @@  discard block
 block discarded – undo
302 312
      *
303 313
      * @param string                                              $name
304 314
      * @param \Sonata\AdminBundle\Admin\FieldDescriptionInterface $fieldDescription
315
+     * @return void
305 316
      */
306 317
     public function addShowFieldDescription($name, FieldDescriptionInterface $fieldDescription);
307 318
 
@@ -309,6 +320,7 @@  discard block
 block discarded – undo
309 320
      * Remove a ShowFieldDescription.
310 321
      *
311 322
      * @param string $name
323
+     * @return void
312 324
      */
313 325
     public function removeShowFieldDescription($name);
314 326
 
@@ -317,6 +329,7 @@  discard block
 block discarded – undo
317 329
      *
318 330
      * @param string                                              $name
319 331
      * @param \Sonata\AdminBundle\Admin\FieldDescriptionInterface $fieldDescription
332
+     * @return void
320 333
      */
321 334
     public function addListFieldDescription($name, FieldDescriptionInterface $fieldDescription);
322 335
 
@@ -324,6 +337,7 @@  discard block
 block discarded – undo
324 337
      * Remove a list FieldDescription.
325 338
      *
326 339
      * @param string $name
340
+     * @return void
327 341
      */
328 342
     public function removeListFieldDescription($name);
329 343
 
@@ -341,6 +355,7 @@  discard block
 block discarded – undo
341 355
      *
342 356
      * @param string                                              $name
343 357
      * @param \Sonata\AdminBundle\Admin\FieldDescriptionInterface $fieldDescription
358
+     * @return void
344 359
      */
345 360
     public function addFilterFieldDescription($name, FieldDescriptionInterface $fieldDescription);
346 361
 
@@ -348,6 +363,7 @@  discard block
 block discarded – undo
348 363
      * Remove a filter FieldDescription.
349 364
      *
350 365
      * @param string $name
366
+     * @return void
351 367
      */
352 368
     public function removeFilterFieldDescription($name);
353 369
 
@@ -367,6 +383,7 @@  discard block
 block discarded – undo
367 383
 
368 384
     /**
369 385
      * @param \Sonata\AdminBundle\Security\Handler\SecurityHandlerInterface $securityHandler
386
+     * @return void
370 387
      */
371 388
     public function setSecurityHandler(SecurityHandlerInterface $securityHandler);
372 389
 
@@ -385,11 +402,13 @@  discard block
 block discarded – undo
385 402
 
386 403
     /**
387 404
      * @param mixed $entity
405
+     * @return string
388 406
      */
389 407
     public function getUrlsafeIdentifier($entity);
390 408
 
391 409
     /**
392 410
      * @param mixed $entity
411
+     * @return string
393 412
      */
394 413
     public function getNormalizedIdentifier($entity);
395 414
 
@@ -398,12 +417,13 @@  discard block
 block discarded – undo
398 417
      *
399 418
      * @param object $entity
400 419
      *
401
-     * @return mixed
420
+     * @return string
402 421
      */
403 422
     public function id($entity);
404 423
 
405 424
     /**
406 425
      * @param \Symfony\Component\Validator\ValidatorInterface $validator
426
+     * @return void
407 427
      */
408 428
     public function setValidator(ValidatorInterface $validator);
409 429
 
@@ -413,12 +433,13 @@  discard block
 block discarded – undo
413 433
     public function getValidator();
414 434
 
415 435
     /**
416
-     * @return array
436
+     * @return FieldDescriptionCollection
417 437
      */
418 438
     public function getShow();
419 439
 
420 440
     /**
421 441
      * @param array $formTheme
442
+     * @return void
422 443
      */
423 444
     public function setFormTheme(array $formTheme);
424 445
 
@@ -429,6 +450,7 @@  discard block
 block discarded – undo
429 450
 
430 451
     /**
431 452
      * @param array $filterTheme
453
+     * @return void
432 454
      */
433 455
     public function setFilterTheme(array $filterTheme);
434 456
 
@@ -439,6 +461,7 @@  discard block
 block discarded – undo
439 461
 
440 462
     /**
441 463
      * @param AdminExtensionInterface $extension
464
+     * @return void
442 465
      */
443 466
     public function addExtension(AdminExtensionInterface $extension);
444 467
 
@@ -451,6 +474,7 @@  discard block
 block discarded – undo
451 474
 
452 475
     /**
453 476
      * @param \Knp\Menu\FactoryInterface $menuFactory
477
+     * @return void
454 478
      */
455 479
     public function setMenuFactory(MenuFactoryInterface $menuFactory);
456 480
 
@@ -461,6 +485,7 @@  discard block
 block discarded – undo
461 485
 
462 486
     /**
463 487
      * @param \Sonata\AdminBundle\Builder\RouteBuilderInterface $routeBuilder
488
+     * @return void
464 489
      */
465 490
     public function setRouteBuilder(RouteBuilderInterface $routeBuilder);
466 491
 
@@ -478,6 +503,7 @@  discard block
 block discarded – undo
478 503
 
479 504
     /**
480 505
      * @param \Sonata\Adminbundle\Translator\LabelTranslatorStrategyInterface $labelTranslatorStrategy
506
+     * @return void
481 507
      */
482 508
     public function setLabelTranslatorStrategy(LabelTranslatorStrategyInterface $labelTranslatorStrategy);
483 509
 
@@ -499,6 +525,7 @@  discard block
 block discarded – undo
499 525
      * add an Admin child to the current one.
500 526
      *
501 527
      * @param \Sonata\AdminBundle\Admin\AdminInterface $child
528
+     * @return void
502 529
      */
503 530
     public function addChild(AdminInterface $child);
504 531
 
@@ -593,7 +620,7 @@  discard block
 block discarded – undo
593 620
     /**
594 621
      * Returns the array of allowed export formats.
595 622
      *
596
-     * @return array
623
+     * @return string[]
597 624
      */
598 625
     public function getExportFormats();
599 626
 
@@ -604,6 +631,9 @@  discard block
 block discarded – undo
604 631
      */
605 632
     public function getDataSourceIterator();
606 633
 
634
+    /**
635
+     * @return void
636
+     */
607 637
     public function configure();
608 638
 
609 639
     /**
@@ -676,6 +706,7 @@  discard block
 block discarded – undo
676 706
      * @param ProxyQueryInterface $query
677 707
      * @param array               $idx
678 708
      * @param bool                $allElements
709
+     * @return void
679 710
      */
680 711
     public function preBatchAction($actionName, ProxyQueryInterface $query, array &$idx, $allElements);
681 712
 
@@ -699,6 +730,7 @@  discard block
 block discarded – undo
699 730
      *
700 731
      * @deprecated this feature cannot be stable, use a custom validator,
701 732
      *             the feature will be removed with Symfony 2.2
733
+     * @return void
702 734
      */
703 735
     public function validate(ErrorElement $errorElement, $object);
704 736
 
@@ -713,6 +745,7 @@  discard block
 block discarded – undo
713 745
      * Add object security, fe. make the current user owner of the object.
714 746
      *
715 747
      * @param mixed $object
748
+     * @return void
716 749
      */
717 750
     public function createObjectSecurity($object);
718 751
 
@@ -723,6 +756,7 @@  discard block
 block discarded – undo
723 756
 
724 757
     /**
725 758
      * @param AdminInterface $admin
759
+     * @return void
726 760
      */
727 761
     public function setParent(AdminInterface $admin);
728 762
 
@@ -746,6 +780,7 @@  discard block
 block discarded – undo
746 780
      * Set the translation domain.
747 781
      *
748 782
      * @param string $translationDomain the translation domain
783
+     * @return void
749 784
      */
750 785
     public function setTranslationDomain($translationDomain);
751 786
 
@@ -767,6 +802,7 @@  discard block
 block discarded – undo
767 802
      * Set the form groups.
768 803
      *
769 804
      * @param array $formGroups
805
+     * @return void
770 806
      */
771 807
     public function setFormGroups(array $formGroups);
772 808
 
@@ -777,6 +813,7 @@  discard block
 block discarded – undo
777 813
 
778 814
     /**
779 815
      * {@inheritdoc}
816
+     * @return void
780 817
      */
781 818
     public function setFormTabs(array $formTabs);
782 819
 
@@ -787,13 +824,15 @@  discard block
 block discarded – undo
787 824
 
788 825
     /**
789 826
      * {@inheritdoc}
827
+     * @return void
790 828
      */
791 829
     public function setShowTabs(array $showTabs);
792 830
 
793 831
     /**
794 832
      * Remove a form group field.
795 833
      *
796
-     * @param $key
834
+     * @param string $key
835
+     * @return void
797 836
      */
798 837
     public function removeFieldFromFormGroup($key);
799 838
 
@@ -808,6 +847,7 @@  discard block
 block discarded – undo
808 847
      * Set the show groups.
809 848
      *
810 849
      * @param array $showGroups
850
+     * @return void
811 851
      */
812 852
     public function setShowGroups(array $showGroups);
813 853
 
@@ -816,6 +856,7 @@  discard block
 block discarded – undo
816 856
      *
817 857
      * @param string $group
818 858
      * @param array  $keys
859
+     * @return void
819 860
      */
820 861
     public function reorderShowGroup($group, array $keys);
821 862
 
@@ -824,6 +865,7 @@  discard block
 block discarded – undo
824 865
      *
825 866
      * @param string                                              $name
826 867
      * @param \Sonata\AdminBundle\Admin\FieldDescriptionInterface $fieldDescription
868
+     * @return void
827 869
      */
828 870
     public function addFormFieldDescription($name, FieldDescriptionInterface $fieldDescription);
829 871
 
@@ -831,6 +873,7 @@  discard block
 block discarded – undo
831 873
      * Remove a FieldDescription.
832 874
      *
833 875
      * @param string $name
876
+     * @return void
834 877
      */
835 878
     public function removeFormFieldDescription($name);
836 879
 
@@ -845,6 +888,7 @@  discard block
 block discarded – undo
845 888
      * Sets the list of supported sub classes.
846 889
      *
847 890
      * @param array $subClasses the list of sub classes
891
+     * @return void
848 892
      */
849 893
     public function setSubClasses(array $subClasses);
850 894
 
@@ -912,6 +956,7 @@  discard block
 block discarded – undo
912 956
      * Set the current child status.
913 957
      *
914 958
      * @param bool $currentChild
959
+     * @return void
915 960
      */
916 961
     public function setCurrentChild($currentChild);
917 962
 
Please login to merge, or discard this patch.