Completed
Pull Request — 3.x (#6306)
by
unknown
02:57
created
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -586,6 +586,10 @@
 block discarded – undo
586 586
         $this->admin->setShowBuilder(new ShowBuilder());
587 587
     }
588 588
 
589
+    /**
590
+     * @param string $name
591
+     * @param string $label
592
+     */
589 593
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
590 594
     {
591 595
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Twig/Extension/SonataAdminExtension.php 1 patch
Doc Comments   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     /**
183 183
      * render a view element.
184 184
      *
185
-     * @param object $object
185
+     * @param \stdClass $object
186 186
      *
187 187
      * @return string
188 188
      */
@@ -221,8 +221,8 @@  discard block
 block discarded – undo
221 221
     /**
222 222
      * render a compared view element.
223 223
      *
224
-     * @param mixed $baseObject
225
-     * @param mixed $compareObject
224
+     * @param \stdClass $baseObject
225
+     * @param \stdClass $compareObject
226 226
      *
227 227
      * @return string
228 228
      */
@@ -343,7 +343,8 @@  discard block
 block discarded – undo
343 343
     /**
344 344
      * Get the identifiers as a string that is safe to use in a url.
345 345
      *
346
-     * @param object $model
346
+     * @param \stdClass $model
347
+     * @param AdminInterface $admin
347 348
      *
348 349
      * @return string string representation of the id that is safe to use in a url
349 350
      */
@@ -365,7 +366,7 @@  discard block
 block discarded – undo
365 366
     }
366 367
 
367 368
     /**
368
-     * @return string|bool
369
+     * @return string|false
369 370
      */
370 371
     public function getXEditableType($type)
371 372
     {
Please login to merge, or discard this patch.
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -414,6 +414,10 @@
 block discarded – undo
414 414
         );
415 415
     }
416 416
 
417
+    /**
418
+     * @param string $name
419
+     * @param string $label
420
+     */
417 421
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
418 422
     {
419 423
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Block/AdminListBlockService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
      * NEXT_MAJOR: Change signature for (Environment $twig, Pool $pool, ?TemplateRegistryInterface $templateRegistry = null).
45 45
      *
46 46
      * @param Environment|string                  $twigOrName
47
-     * @param EngineInterface|Pool|null           $poolOrTemplating
47
+     * @param Pool|null           $poolOrTemplating
48 48
      * @param Pool|TemplateRegistryInterface|null $templateRegistryOrPool
49 49
      */
50 50
     public function __construct(
Please login to merge, or discard this patch.
src/Block/AdminSearchBlockService.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,8 +45,9 @@
 block discarded – undo
45 45
      * NEXT_MAJOR: Change signature for (Environment $twig, Pool $pool, SearchHandler $searchHandler).
46 46
      *
47 47
      * @param Environment|string        $twigOrName
48
-     * @param Pool|EngineInterface|null $poolOrTemplating
48
+     * @param Pool|null $poolOrTemplating
49 49
      * @param SearchHandler|Pool        $searchHandlerOrPool
50
+     * @param SearchHandler $searchHandler
50 51
      */
51 52
     public function __construct($twigOrName, ?object $poolOrTemplating, object $searchHandlerOrPool, ?SearchHandler $searchHandler = null)
52 53
     {
Please login to merge, or discard this patch.
src/Block/AdminStatsBlockService.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,8 @@
 block discarded – undo
37 37
      * NEXT_MAJOR: Change signature for (Environment $twig, Pool $pool).
38 38
      *
39 39
      * @param Environment|string        $twigOrName
40
-     * @param Pool|EngineInterface|null $poolOrTemplating
40
+     * @param Pool|null $poolOrTemplating
41
+     * @param Pool $pool
41 42
      */
42 43
     public function __construct($twigOrName, ?object $poolOrTemplating, ?Pool $pool = null)
43 44
     {
Please login to merge, or discard this patch.
src/Admin/BaseFieldDescription.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -540,6 +540,9 @@
 block discarded – undo
540 540
         return $object->{$fieldName};
541 541
     }
542 542
 
543
+    /**
544
+     * @param string $fieldName
545
+     */
543 546
     private function cacheFieldGetter(object $object, ?string $fieldName, string $method, ?string $getter = null): void
544 547
     {
545 548
         $getterKey = $this->getFieldGetterKey($object, $fieldName);
Please login to merge, or discard this patch.
src/Model/ModelManagerInterface.php 1 patch
Doc Comments   +11 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,6 +36,7 @@  discard block
 block discarded – undo
36 36
      * @param object $object
37 37
      *
38 38
      * @throws ModelManagerException
39
+     * @return void
39 40
      */
40 41
     public function create($object);
41 42
 
@@ -43,6 +44,7 @@  discard block
 block discarded – undo
43 44
      * @param object $object
44 45
      *
45 46
      * @throws ModelManagerException
47
+     * @return void
46 48
      */
47 49
     public function update($object);
48 50
 
@@ -50,6 +52,7 @@  discard block
 block discarded – undo
50 52
      * @param object $object
51 53
      *
52 54
      * @throws ModelManagerException
55
+     * @return void
53 56
      */
54 57
     public function delete($object);
55 58
 
@@ -71,7 +74,7 @@  discard block
 block discarded – undo
71 74
      * @param string $class
72 75
      * @param mixed  $id
73 76
      *
74
-     * @return object|null the object with id or null if not found
77
+     * @return \Sonata\AdminBundle\Tests\App\Model\Foo|null the object with id or null if not found
75 78
      */
76 79
     public function find($class, $id);
77 80
 
@@ -79,6 +82,7 @@  discard block
 block discarded – undo
79 82
      * @param string $class
80 83
      *
81 84
      * @throws ModelManagerException
85
+     * @return void
82 86
      */
83 87
     public function batchDelete($class, ProxyQueryInterface $queryProxy);
84 88
 
@@ -90,6 +94,7 @@  discard block
 block discarded – undo
90 94
      *
91 95
      * @param array  $parentAssociationMapping
92 96
      * @param string $class
97
+     * @return FieldDescriptionInterface
93 98
      */
94 99
     public function getParentFieldDescription($parentAssociationMapping, $class);
95 100
 
@@ -180,6 +185,7 @@  discard block
 block discarded – undo
180 185
      *
181 186
      * @param array  $collection
182 187
      * @param object $element
188
+     * @return void
183 189
      */
184 190
     public function collectionRemoveElement(&$collection, &$element);
185 191
 
@@ -188,6 +194,7 @@  discard block
 block discarded – undo
188 194
      *
189 195
      * @param array  $collection
190 196
      * @param object $element
197
+     * @return void
191 198
      */
192 199
     public function collectionAddElement(&$collection, &$element);
193 200
 
@@ -205,6 +212,7 @@  discard block
 block discarded – undo
205 212
      * Clear the collection.
206 213
      *
207 214
      * @param array $collection
215
+     * @return void
208 216
      */
209 217
     public function collectionClear(&$collection);
210 218
 
@@ -235,6 +243,7 @@  discard block
 block discarded – undo
235 243
 
236 244
     /**
237 245
      * @param mixed $query
246
+     * @return void
238 247
      */
239 248
     public function executeQuery($query);
240 249
 
@@ -272,6 +281,7 @@  discard block
 block discarded – undo
272 281
 
273 282
     /**
274 283
      * @param string $class
284
+     * @return void
275 285
      */
276 286
     public function addIdentifiersToQuery($class, ProxyQueryInterface $query, array $idx);
277 287
 }
Please login to merge, or discard this patch.
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1111,6 +1111,7 @@  discard block
 block discarded – undo
1111 1111
 
1112 1112
     /**
1113 1113
      * NEXT_MAJOR: remove this method.
1114
+     * @param string $subClass
1114 1115
      */
1115 1116
     public function addSubClass($subClass)
1116 1117
     {
@@ -2677,7 +2678,7 @@  discard block
 block discarded – undo
2677 2678
      *
2678 2679
      * @param string $context
2679 2680
      *
2680
-     * @return array
2681
+     * @return string[]
2681 2682
      */
2682 2683
     public function getPermissionsShow($context)
2683 2684
     {
Please login to merge, or discard this patch.