Completed
Pull Request — 3.x (#4669)
by Jordi Sala
07:49
created
Admin/AbstractAdmin.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 
14 14
 use Doctrine\Common\Util\ClassUtils;
15 15
 use Knp\Menu\FactoryInterface as MenuFactoryInterface;
16
-use Knp\Menu\ItemInterface;
17 16
 use Knp\Menu\ItemInterface as MenuItemInterface;
18 17
 use Sonata\AdminBundle\Builder\DatagridBuilderInterface;
19 18
 use Sonata\AdminBundle\Builder\FormContractorInterface;
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1154,6 +1154,8 @@  discard block
 block discarded – undo
1154 1154
 
1155 1155
     /**
1156 1156
      * {@inheritdoc}
1157
+     * @param string $name
1158
+     * @param string $adminCode
1157 1159
      */
1158 1160
     public function isCurrentRoute($name, $adminCode = null)
1159 1161
     {
@@ -2482,7 +2484,7 @@  discard block
 block discarded – undo
2482 2484
      *
2483 2485
      * @param string $context
2484 2486
      *
2485
-     * @return array
2487
+     * @return string[]
2486 2488
      */
2487 2489
     public function getPermissionsShow($context)
2488 2490
     {
@@ -2725,7 +2727,7 @@  discard block
 block discarded – undo
2725 2727
     /**
2726 2728
      * Set custom per page options.
2727 2729
      *
2728
-     * @param array $options
2730
+     * @param integer[] $options
2729 2731
      */
2730 2732
     public function setPerPageOptions(array $options)
2731 2733
     {
@@ -2887,6 +2889,7 @@  discard block
 block discarded – undo
2887 2889
 
2888 2890
     /**
2889 2891
      * {@inheritdoc}
2892
+     * @param string $action
2890 2893
      */
2891 2894
     public function configureActionButtons($action, $object = null)
2892 2895
     {
@@ -3018,7 +3021,6 @@  discard block
 block discarded – undo
3018 3021
     }
3019 3022
 
3020 3023
     /**
3021
-     * @param FormMapper $form
3022 3024
      */
3023 3025
     final public function getSearchResultLink($object)
3024 3026
     {
Please login to merge, or discard this patch.
Admin/FieldDescriptionCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     }
31 31
 
32 32
     /**
33
-     * @return array
33
+     * @return FieldDescriptionInterface[]
34 34
      */
35 35
     public function getElements()
36 36
     {
Please login to merge, or discard this patch.
Admin/Pool.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
     }
279 279
 
280 280
     /**
281
-     * @param array $adminServiceIds
281
+     * @param string[] $adminServiceIds
282 282
      */
283 283
     public function setAdminServiceIds(array $adminServiceIds)
284 284
     {
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
     }
287 287
 
288 288
     /**
289
-     * @return array
289
+     * @return string[]
290 290
      */
291 291
     public function getAdminServiceIds()
292 292
     {
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
     }
319 319
 
320 320
     /**
321
-     * @return array
321
+     * @return string[]
322 322
      */
323 323
     public function getTemplates()
324 324
     {
Please login to merge, or discard this patch.
Datagrid/ListMapper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
      * @throws \RuntimeException
68 68
      *
69 69
      * @param mixed $name
70
-     * @param mixed $type
70
+     * @param string|null $type
71 71
      * @param array $fieldDescriptionOptions
72 72
      *
73 73
      * @return ListMapper
Please login to merge, or discard this patch.
Datagrid/Pager.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -459,7 +459,7 @@  discard block
 block discarded – undo
459 459
      * Returns a parameter.
460 460
      *
461 461
      * @param string $name
462
-     * @param mixed  $default
462
+     * @param null|string  $default
463 463
      *
464 464
      * @return mixed
465 465
      */
@@ -484,7 +484,7 @@  discard block
 block discarded – undo
484 484
      * Sets a parameter.
485 485
      *
486 486
      * @param string $name
487
-     * @param mixed  $value
487
+     * @param string  $value
488 488
      */
489 489
     public function setParameter($name, $value)
490 490
     {
@@ -595,7 +595,7 @@  discard block
 block discarded – undo
595 595
     }
596 596
 
597 597
     /**
598
-     * @param array $countColumn
598
+     * @param string[] $countColumn
599 599
      *
600 600
      * @return array
601 601
      */
Please login to merge, or discard this patch.
Generator/AdminGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
 
39 39
     /**
40 40
      * @param ModelManagerInterface $modelManager
41
-     * @param array|string          $skeletonDirectories
41
+     * @param string          $skeletonDirectories
42 42
      */
43 43
     public function __construct(ModelManagerInterface $modelManager, $skeletonDirectories)
44 44
     {
Please login to merge, or discard this patch.
Generator/ControllerGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
     private $file;
32 32
 
33 33
     /**
34
-     * @param array|string $skeletonDirectory
34
+     * @param string $skeletonDirectory
35 35
      */
36 36
     public function __construct($skeletonDirectory)
37 37
     {
Please login to merge, or discard this patch.
Search/SearchHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
      * @param int            $page
41 41
      * @param int            $offset
42 42
      *
43
-     * @return PagerInterface|false
43
+     * @return null|\Symfony\Component\HttpFoundation\Response
44 44
      *
45 45
      * @throws \RuntimeException
46 46
      */
Please login to merge, or discard this patch.
Tests/Admin/Extension/LockExtensionTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -195,6 +195,10 @@
 block discarded – undo
195 195
         return new FormMapper($contractor->reveal(), $formBuilder, $this->admin->reveal());
196 196
     }
197 197
 
198
+    /**
199
+     * @param string $uniqid
200
+     * @param Request $request
201
+     */
198 202
     private function configureAdmin($uniqid = null, $request = null, $modelManager = null)
199 203
     {
200 204
         $this->admin->getUniqid()->willReturn($uniqid);
Please login to merge, or discard this patch.