Completed
Pull Request — 3.x (#4669)
by Jordi Sala
07:49
created
Twig/Extension/SonataAdminExtension.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     /**
124 124
      * render a list element from the FieldDescription.
125 125
      *
126
-     * @param mixed                     $object
126
+     * @param \stdClass                     $object
127 127
      * @param FieldDescriptionInterface $fieldDescription
128 128
      * @param array                     $params
129 129
      *
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
      * render a view element.
227 227
      *
228 228
      * @param FieldDescriptionInterface $fieldDescription
229
-     * @param mixed                     $object
229
+     * @param \stdClass                     $object
230 230
      *
231 231
      * @return string
232 232
      */
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
     /**
366 366
      * Get the identifiers as a string that is safe to use in a url.
367 367
      *
368
-     * @param object         $model
368
+     * @param \stdClass         $model
369 369
      * @param AdminInterface $admin
370 370
      *
371 371
      * @return string string representation of the id that is safe to use in a url
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
     /**
391 391
      * @param $type
392 392
      *
393
-     * @return string|bool
393
+     * @return string|false
394 394
      */
395 395
     public function getXEditableType($type)
396 396
     {
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
      * @param FieldDescriptionInterface $fieldDescription
448 448
      * @param string                    $defaultTemplate
449 449
      *
450
-     * @return \Twig_TemplateInterface
450
+     * @return \Twig_Template
451 451
      */
452 452
     protected function getTemplate(
453 453
         FieldDescriptionInterface $fieldDescription,
Please login to merge, or discard this patch.
Admin/AbstractAdminExtension.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -62,6 +62,7 @@
 block discarded – undo
62 62
 
63 63
     /**
64 64
      * {@inheritdoc}
65
+     * @param string $action
65 66
      */
66 67
     public function configureSideMenu(AdminInterface $admin, MenuItemInterface $menu, $action, AdminInterface $childAdmin = null)
67 68
     {
Please login to merge, or discard this patch.
Controller/CRUDController.php 1 patch
Doc Comments   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -58,6 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
     /**
60 60
      * {@inheritdoc}
61
+     * @param null|string $view
61 62
      */
62 63
     public function render($view, array $parameters = [], Response $response = null)
63 64
     {
@@ -154,7 +155,7 @@  discard block
 block discarded – undo
154 155
     /**
155 156
      * Delete action.
156 157
      *
157
-     * @param int|string|null $id
158
+     * @param integer|null $id
158 159
      *
159 160
      * @return Response|RedirectResponse
160 161
      *
@@ -673,7 +674,7 @@  discard block
 block discarded – undo
673 674
     /**
674 675
      * View history revision of object.
675 676
      *
676
-     * @param int|string|null $id
677
+     * @param null|integer $id
677 678
      * @param string|null     $revision
678 679
      *
679 680
      * @return Response
@@ -733,9 +734,9 @@  discard block
 block discarded – undo
733 734
     /**
734 735
      * Compare history revisions of object.
735 736
      *
736
-     * @param int|string|null $id
737
-     * @param int|string|null $base_revision
738
-     * @param int|string|null $compare_revision
737
+     * @param null|integer $id
738
+     * @param null|integer $base_revision
739
+     * @param null|integer $compare_revision
739 740
      *
740 741
      * @return Response
741 742
      *
Please login to merge, or discard this patch.
Tests/Controller/CRUDControllerTest.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -3759,6 +3759,9 @@  discard block
 block discarded – undo
3759 3759
         ];
3760 3760
     }
3761 3761
 
3762
+    /**
3763
+     * @param string $method
3764
+     */
3762 3765
     private function assertLoggerLogsModelManagerException($subject, $method)
3763 3766
     {
3764 3767
         $exception = new ModelManagerException(
@@ -3781,6 +3784,10 @@  discard block
 block discarded – undo
3781 3784
             ]);
3782 3785
     }
3783 3786
 
3787
+    /**
3788
+     * @param string $id
3789
+     * @param string $domain
3790
+     */
3784 3791
     private function expectTranslate($id, array $parameters = [], $domain = null, $locale = null)
3785 3792
     {
3786 3793
         $this->translator->expects($this->once())
Please login to merge, or discard this patch.
Tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -257,6 +257,12 @@
 block discarded – undo
257 257
         ], array_keys($this->datagrid->getFilters()));
258 258
     }
259 259
 
260
+    /**
261
+     * @param string $name
262
+     * @param string $label
263
+     *
264
+     * @return string
265
+     */
260 266
     private function getFieldDescriptionMock($name = null, $label = null)
261 267
     {
262 268
         $fieldDescription = $this->getMockForAbstractClass('Sonata\AdminBundle\Admin\BaseFieldDescription');
Please login to merge, or discard this patch.
Tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -251,6 +251,10 @@
 block discarded – undo
251 251
         ], true), print_r($this->fieldDescriptionCollection->getElements(), true));
252 252
     }
253 253
 
254
+    /**
255
+     * @param string $name
256
+     * @param string $label
257
+     */
254 258
     private function getFieldDescriptionMock($name = null, $label = null)
255 259
     {
256 260
         $fieldDescription = $this->getMockForAbstractClass('Sonata\AdminBundle\Admin\BaseFieldDescription');
Please login to merge, or discard this patch.
Tests/Datagrid/PagerTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -640,6 +640,10 @@
 block discarded – undo
640 640
         $this->assertSame(null, $this->pager->getQuery());
641 641
     }
642 642
 
643
+    /**
644
+     * @param Pager $obj
645
+     * @param string $name
646
+     */
643 647
     protected function callMethod($obj, $name, array $args = [])
644 648
     {
645 649
         $class = new \ReflectionClass($obj);
Please login to merge, or discard this patch.
Admin/AbstractAdmin.php 1 patch
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1154,6 +1154,8 @@  discard block
 block discarded – undo
1154 1154
 
1155 1155
     /**
1156 1156
      * {@inheritdoc}
1157
+     * @param string $name
1158
+     * @param string $adminCode
1157 1159
      */
1158 1160
     public function isCurrentRoute($name, $adminCode = null)
1159 1161
     {
@@ -2482,7 +2484,7 @@  discard block
 block discarded – undo
2482 2484
      *
2483 2485
      * @param string $context
2484 2486
      *
2485
-     * @return array
2487
+     * @return string[]
2486 2488
      */
2487 2489
     public function getPermissionsShow($context)
2488 2490
     {
@@ -2725,7 +2727,7 @@  discard block
 block discarded – undo
2725 2727
     /**
2726 2728
      * Set custom per page options.
2727 2729
      *
2728
-     * @param array $options
2730
+     * @param integer[] $options
2729 2731
      */
2730 2732
     public function setPerPageOptions(array $options)
2731 2733
     {
@@ -2887,6 +2889,7 @@  discard block
 block discarded – undo
2887 2889
 
2888 2890
     /**
2889 2891
      * {@inheritdoc}
2892
+     * @param string $action
2890 2893
      */
2891 2894
     public function configureActionButtons($action, $object = null)
2892 2895
     {
@@ -3018,7 +3021,6 @@  discard block
 block discarded – undo
3018 3021
     }
3019 3022
 
3020 3023
     /**
3021
-     * @param FormMapper $form
3022 3024
      */
3023 3025
     final public function getSearchResultLink($object)
3024 3026
     {
Please login to merge, or discard this patch.
Form/ChoiceList/ModelChoiceList.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -99,9 +99,9 @@
 block discarded – undo
99 99
     /**
100 100
      * @param ModelManagerInterface $modelManager
101 101
      * @param string                $class
102
-     * @param null                  $property
103
-     * @param null                  $query
104
-     * @param array                 $choices
102
+     * @param string|null                  $property
103
+     * @param string|null                  $query
104
+     * @param integer[]                 $choices
105 105
      */
106 106
     public function __construct(ModelManagerInterface $modelManager, $class, $property = null, $query = null, $choices = [], PropertyAccessorInterface $propertyAccessor = null)
107 107
     {
Please login to merge, or discard this patch.