Completed
Pull Request — master (#4845)
by Jordi Sala
03:28
created
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -255,6 +255,12 @@
 block discarded – undo
255 255
         ], true), print_r($this->fieldDescriptionCollection->getElements(), true));
256 256
     }
257 257
 
258
+    /**
259
+     * @param string $name
260
+     * @param string $label
261
+     *
262
+     * @return string
263
+     */
258 264
     private function getFieldDescriptionMock($name = null, $label = null)
259 265
     {
260 266
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -455,6 +455,10 @@
 block discarded – undo
455 455
         $this->showMapper = new ShowMapper($this->showBuilder, $this->fieldDescriptionCollection, $this->admin);
456 456
     }
457 457
 
458
+    /**
459
+     * @param string $name
460
+     * @param string $label
461
+     */
458 462
     private function getFieldDescriptionMock($name = null, $label = null)
459 463
     {
460 464
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Controller/CRUDController.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
     /**
209 209
      * Delete action.
210 210
      *
211
-     * @param int|string|null $id
211
+     * @param integer|null $id
212 212
      *
213 213
      * @throws NotFoundHttpException If the object does not exist
214 214
      * @throws AccessDeniedException If access is not granted
@@ -726,7 +726,7 @@  discard block
 block discarded – undo
726 726
     /**
727 727
      * View history revision of object.
728 728
      *
729
-     * @param int|string|null $id
729
+     * @param null|integer $id
730 730
      * @param string|null     $revision
731 731
      *
732 732
      * @throws AccessDeniedException If access is not granted
@@ -786,9 +786,9 @@  discard block
 block discarded – undo
786 786
     /**
787 787
      * Compare history revisions of object.
788 788
      *
789
-     * @param int|string|null $id
790
-     * @param int|string|null $base_revision
791
-     * @param int|string|null $compare_revision
789
+     * @param null|integer $id
790
+     * @param null|integer $base_revision
791
+     * @param null|integer $compare_revision
792 792
      *
793 793
      * @throws AccessDeniedException If access is not granted
794 794
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available
Please login to merge, or discard this patch.
tests/Datagrid/PagerTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -639,6 +639,10 @@
 block discarded – undo
639 639
         $this->assertNull($this->pager->getQuery());
640 640
     }
641 641
 
642
+    /**
643
+     * @param Pager $obj
644
+     * @param string $name
645
+     */
642 646
     protected function callMethod($obj, $name, array $args = [])
643 647
     {
644 648
         $class = new \ReflectionClass($obj);
Please login to merge, or discard this patch.
tests/Twig/Extension/SonataAdminExtensionTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -2210,6 +2210,9 @@
 block discarded – undo
2210 2210
         return htmlspecialchars(http_build_query($url, '', '&', PHP_QUERY_RFC3986));
2211 2211
     }
2212 2212
 
2213
+    /**
2214
+     * @param string $privateMethod
2215
+     */
2213 2216
     private function getMethodAsPublic($privateMethod)
2214 2217
     {
2215 2218
         $reflection = new \ReflectionMethod('Sonata\AdminBundle\Twig\Extension\SonataAdminExtension', $privateMethod);
Please login to merge, or discard this patch.
src/Admin/Pool.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
     }
292 292
 
293 293
     /**
294
-     * @param array $adminServiceIds
294
+     * @param string[] $adminServiceIds
295 295
      */
296 296
     public function setAdminServiceIds(array $adminServiceIds): void
297 297
     {
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
     }
300 300
 
301 301
     /**
302
-     * @return array
302
+     * @return string[]
303 303
      */
304 304
     public function getAdminServiceIds()
305 305
     {
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
     }
332 332
 
333 333
     /**
334
-     * @return array
334
+     * @return string[]
335 335
      */
336 336
     public function getTemplates()
337 337
     {
Please login to merge, or discard this patch.
src/Controller/PolyfillControllerTrait.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -27,6 +27,9 @@
 block discarded – undo
27 27
  */
28 28
 trait PolyfillControllerTrait
29 29
 {
30
+    /**
31
+     * @param string $methodName
32
+     */
30 33
     public function __call($methodName, $arguments): void
31 34
     {
32 35
         $this->proxyToController($methodName, $arguments);
Please login to merge, or discard this patch.
src/Datagrid/Pager.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -461,7 +461,7 @@  discard block
 block discarded – undo
461 461
      * Returns a parameter.
462 462
      *
463 463
      * @param string $name
464
-     * @param mixed  $default
464
+     * @param null|string  $default
465 465
      *
466 466
      * @return mixed
467 467
      */
@@ -486,7 +486,7 @@  discard block
 block discarded – undo
486 486
      * Sets a parameter.
487 487
      *
488 488
      * @param string $name
489
-     * @param mixed  $value
489
+     * @param string  $value
490 490
      */
491 491
     public function setParameter($name, $value): void
492 492
     {
@@ -597,7 +597,7 @@  discard block
 block discarded – undo
597 597
     }
598 598
 
599 599
     /**
600
-     * @param array $countColumn
600
+     * @param string[] $countColumn
601 601
      *
602 602
      * @return array
603 603
      */
Please login to merge, or discard this patch.
tests/Admin/Extension/LockExtensionTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -210,6 +210,10 @@
 block discarded – undo
210 210
         return new FormMapper($contractor->reveal(), $formBuilder, $this->admin->reveal());
211 211
     }
212 212
 
213
+    /**
214
+     * @param string $uniqid
215
+     * @param Request $request
216
+     */
213 217
     private function configureAdmin($uniqid = null, $request = null, $modelManager = null): void
214 218
     {
215 219
         $this->admin->getUniqid()->willReturn($uniqid);
Please login to merge, or discard this patch.