Completed
Pull Request — 3.x (#4825)
by Grégoire
04:01
created
src/Form/ChoiceList/ModelChoiceList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
      * @param string                $class
103 103
      * @param string|null           $property
104 104
      * @param QueryBuilder|null     $query
105
-     * @param array                 $choices
105
+     * @param integer[]                 $choices
106 106
      */
107 107
     public function __construct(ModelManagerInterface $modelManager, $class, $property = null, $query = null, $choices = [], PropertyAccessorInterface $propertyAccessor = null)
108 108
     {
Please login to merge, or discard this patch.
src/Controller/CRUDController.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     /**
174 174
      * Delete action.
175 175
      *
176
-     * @param int|string|null $id
176
+     * @param integer|null $id
177 177
      *
178 178
      * @return Response|RedirectResponse
179 179
      *
@@ -700,7 +700,7 @@  discard block
 block discarded – undo
700 700
     /**
701 701
      * View history revision of object.
702 702
      *
703
-     * @param int|string|null $id
703
+     * @param null|integer $id
704 704
      * @param string|null     $revision
705 705
      *
706 706
      * @return Response
@@ -760,9 +760,9 @@  discard block
 block discarded – undo
760 760
     /**
761 761
      * Compare history revisions of object.
762 762
      *
763
-     * @param int|string|null $id
764
-     * @param int|string|null $base_revision
765
-     * @param int|string|null $compare_revision
763
+     * @param null|integer $id
764
+     * @param null|integer $base_revision
765
+     * @param null|integer $compare_revision
766 766
      *
767 767
      * @return Response
768 768
      *
Please login to merge, or discard this patch.
src/Controller/PolyfillControllerTrait.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -25,6 +25,9 @@
 block discarded – undo
25 25
  */
26 26
 trait PolyfillControllerTrait
27 27
 {
28
+    /**
29
+     * @param string $methodName
30
+     */
28 31
     public function __call($methodName, $arguments)
29 32
     {
30 33
         $this->proxyToController($methodName, $arguments);
Please login to merge, or discard this patch.
src/Twig/GlobalVariables.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     /**
68 68
      * @param string $code
69 69
      * @param string $action
70
-     * @param array  $parameters
70
+     * @param string[]  $parameters
71 71
      * @param int    $absolute
72 72
      *
73 73
      * @return string
@@ -82,8 +82,8 @@  discard block
 block discarded – undo
82 82
     /**
83 83
      * @param string $code
84 84
      * @param string $action
85
-     * @param mixed  $object
86
-     * @param array  $parameters
85
+     * @param string  $object
86
+     * @param string[]  $parameters
87 87
      * @param int    $absolute
88 88
      *
89 89
      * @return string
@@ -96,8 +96,8 @@  discard block
 block discarded – undo
96 96
     }
97 97
 
98 98
     /**
99
-     * @param $code
100
-     * @param $action
99
+     * @param string $code
100
+     * @param string $action
101 101
      *
102 102
      * @return array
103 103
      */
Please login to merge, or discard this patch.
tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -266,6 +266,12 @@
 block discarded – undo
266 266
         ], array_keys($this->datagrid->getFilters()));
267 267
     }
268 268
 
269
+    /**
270
+     * @param string $name
271
+     * @param string $label
272
+     *
273
+     * @return string
274
+     */
269 275
     private function getFieldDescriptionMock($name = null, $label = null)
270 276
     {
271 277
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -255,6 +255,12 @@
 block discarded – undo
255 255
         ], true), print_r($this->fieldDescriptionCollection->getElements(), true));
256 256
     }
257 257
 
258
+    /**
259
+     * @param string $name
260
+     * @param string $label
261
+     *
262
+     * @return string
263
+     */
258 264
     private function getFieldDescriptionMock($name = null, $label = null)
259 265
     {
260 266
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -455,6 +455,10 @@
 block discarded – undo
455 455
         $this->showMapper = new ShowMapper($this->showBuilder, $this->fieldDescriptionCollection, $this->admin);
456 456
     }
457 457
 
458
+    /**
459
+     * @param string $name
460
+     * @param string $label
461
+     */
458 462
     private function getFieldDescriptionMock($name = null, $label = null)
459 463
     {
460 464
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1019,6 +1019,7 @@  discard block
 block discarded – undo
1019 1019
 
1020 1020
     /**
1021 1021
      * NEXT_MAJOR: remove this method
1022
+     * @param string $subClass
1022 1023
      */
1023 1024
     public function addSubClass($subClass)
1024 1025
     {
@@ -1172,6 +1173,8 @@  discard block
 block discarded – undo
1172 1173
 
1173 1174
     /**
1174 1175
      * {@inheritdoc}
1176
+     * @param string $name
1177
+     * @param string $adminCode
1175 1178
      */
1176 1179
     public function isCurrentRoute($name, $adminCode = null)
1177 1180
     {
@@ -2543,7 +2546,7 @@  discard block
 block discarded – undo
2543 2546
      *
2544 2547
      * @param string $context
2545 2548
      *
2546
-     * @return array
2549
+     * @return string[]
2547 2550
      */
2548 2551
     public function getPermissionsShow($context)
2549 2552
     {
@@ -2786,7 +2789,7 @@  discard block
 block discarded – undo
2786 2789
     /**
2787 2790
      * Set custom per page options.
2788 2791
      *
2789
-     * @param array $options
2792
+     * @param integer[] $options
2790 2793
      */
2791 2794
     public function setPerPageOptions(array $options)
2792 2795
     {
@@ -2948,6 +2951,7 @@  discard block
 block discarded – undo
2948 2951
 
2949 2952
     /**
2950 2953
      * {@inheritdoc}
2954
+     * @param string $action
2951 2955
      */
2952 2956
     public function configureActionButtons($action, $object = null)
2953 2957
     {
@@ -3079,7 +3083,6 @@  discard block
 block discarded – undo
3079 3083
     }
3080 3084
 
3081 3085
     /**
3082
-     * @param FormMapper $form
3083 3086
      */
3084 3087
     final public function getSearchResultLink($object)
3085 3088
     {
@@ -3196,7 +3199,7 @@  discard block
 block discarded – undo
3196 3199
      * NEXT_MAJOR: remove this method.
3197 3200
      *
3198 3201
      * @param MenuItemInterface $menu
3199
-     * @param                   $action
3202
+     * @param                   string $action
3200 3203
      * @param AdminInterface    $childAdmin
3201 3204
      *
3202 3205
      * @return mixed
Please login to merge, or discard this patch.