Completed
Pull Request — 3.x (#4959)
by Julien
04:13
created
tests/Controller/HelperControllerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -495,6 +495,9 @@
 block discarded – undo
495 495
         $this->assertSame('{"status":"OK","more":false,"items":[{"id":123,"label":"FOO"}]}', $response->getContent());
496 496
     }
497 497
 
498
+    /**
499
+     * @param string $field
500
+     */
498 501
     private function configureFormConfig($field, $disabled = false)
499 502
     {
500 503
         $form = $this->prophesize(Form::class);
Please login to merge, or discard this patch.
src/Admin/BaseFieldDescription.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -447,6 +447,9 @@  discard block
 block discarded – undo
447 447
         return implode('-', $components);
448 448
     }
449 449
 
450
+    /**
451
+     * @param string $fieldName
452
+     */
450 453
     private function hasCachedFieldGetter($object, $fieldName)
451 454
     {
452 455
         return isset(
@@ -454,6 +457,9 @@  discard block
 block discarded – undo
454 457
         );
455 458
     }
456 459
 
460
+    /**
461
+     * @param string $fieldName
462
+     */
457 463
     private function callCachedGetter($object, $fieldName, array $parameters = [])
458 464
     {
459 465
         $getterKey = $this->getFieldGetterKey($object, $fieldName);
@@ -472,6 +478,10 @@  discard block
 block discarded – undo
472 478
         return $object->{$fieldName};
473 479
     }
474 480
 
481
+    /**
482
+     * @param string $fieldName
483
+     * @param string $method
484
+     */
475 485
     private function cacheFieldGetter($object, $fieldName, $method, $getter = null)
476 486
     {
477 487
         $getterKey = $this->getFieldGetterKey($object, $fieldName);
Please login to merge, or discard this patch.
src/Form/ChoiceList/ModelChoiceLoader.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@
 block discarded – undo
149 149
     /**
150 150
      * @param object $entity
151 151
      *
152
-     * @return array
152
+     * @return string
153 153
      */
154 154
     private function getNormalizedIdentifier($entity)
155 155
     {
Please login to merge, or discard this patch.
src/Form/DataTransformer/ModelsToArrayTransformer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@
 block discarded – undo
185 185
     /**
186 186
      * @param object $entity
187 187
      *
188
-     * @return array
188
+     * @return string
189 189
      */
190 190
     private function getNormalizedIdentifier($entity)
191 191
     {
Please login to merge, or discard this patch.