sonata-project / SonataAdminBundle

src/Action/GetShortObjectDescriptionAction.php

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\AdminBundle\Action;

use Sonata\AdminBundle\Admin\Pool;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Twig\Environment;

final class GetShortObjectDescriptionAction
{
    /**
     * @var Pool
     */
    private $pool;

    /**
     * @var Environment
     */
    private $twig;

    public function __construct(Environment $twig, Pool $pool)
    {
        $this->pool = $pool;
        $this->twig = $twig;
    }

    /**
     * @throws NotFoundHttpException
     */
    public function __invoke(Request $request): Response
    {
        $code = $request->get('code');
        $objectId = $request->get('objectId');
        $uniqid = $request->get('uniqid');
        $linkParameters = $request->get('linkParameters', []);

        $admin = $this->pool->getInstance($code);

        if (!$admin) {
            throw new NotFoundHttpException(sprintf(
                'Could not find admin for code "%s"',
                $code
            ));
        }

        $admin->setRequest($request);

        if ($uniqid) {
            $admin->setUniqid($uniqid);
        }

        if (!$objectId) {
            $objectId = null;
        }

        $object = $admin->getObject($objectId);

        if (!$object && 'html' === $request->get('_format')) {
            return new Response();
        }

        if ('json' === $request->get('_format')) {
            return new JsonResponse(['result' => [
                'id' => $admin->id($object),

It seems like $object defined by $admin->getObject($objectId) on line 70 can also be of type null; however, Sonata\AdminBundle\Admin\AdminInterface::id() does only seem to accept object, maybe add an additional type check?

                'label' => $admin->toString($object),

It seems like $object defined by $admin->getObject($objectId) on line 70 can also be of type null; however, Sonata\AdminBundle\Admin\AdminInterface::toString() does only seem to accept object, maybe add an additional type check?

            ]]);
        } elseif ('html' === $request->get('_format')) {
            return new Response($this->twig->render($admin->getTemplate('short_object_description'), [
                'admin' => $admin,
                'description' => $admin->toString($object),

It seems like $object defined by $admin->getObject($objectId) on line 70 can also be of type null; however, Sonata\AdminBundle\Admin\AdminInterface::toString() does only seem to accept object, maybe add an additional type check?

                'object' => $object,
                'link_parameters' => $linkParameters,
            ]));
        }

        throw new \RuntimeException('Invalid format');
    }
}