ModelToIdTransformerTest::setUp() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/3.x'" - sonata-project/SonataAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 46c3a0...a94e83 )

by Grégoire

created 2019-10-06 15:41 UTC

ModelToIdTransformerTest::setUp() A

↳ Parent: ModelToIdTransformerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\AdminBundle\Tests\Form\DataTransformer;

use PHPUnit\Framework\TestCase;
use Sonata\AdminBundle\Form\DataTransformer\ModelToIdTransformer;
use Sonata\AdminBundle\Model\ModelManagerInterface;

class ModelToIdTransformerTest extends TestCase
{
    private $modelManager = null;

    public function setUp(): void
    {
        $this->modelManager = $this->getMockForAbstractClass(ModelManagerInterface::class);
    }

    public function testReverseTransformWhenPassing0AsId(): void
    {
        $transformer = new ModelToIdTransformer($this->modelManager, 'TEST');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->modelManager
                ->expects($this->exactly(2))
                ->method('find')
                ->willReturn(true);

        $this->assertFalse(\in_array(false, ['0', 0], true));

        // we pass 0 as integer
        $this->assertTrue($transformer->reverseTransform(0));

        // we pass 0 as string
        $this->assertTrue($transformer->reverseTransform('0'));

        // we pass null must return null
        $this->assertNull($transformer->reverseTransform(null));

        // we pass false, must return null
        $this->assertNull($transformer->reverseTransform(false));
    }

    /**
     * @dataProvider getReverseTransformValues
     */
    public function testReverseTransform($value, $expected): void
    {
        $transformer = new ModelToIdTransformer($this->modelManager, 'TEST2');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->modelManager->expects($this->any())->method('find');

        $this->assertSame($expected, $transformer->reverseTransform($value));
    }

    public function getReverseTransformValues()
    {
        return [
            [null, null],
            [false, null],
            [[], null],
            ['', null],
        ];
    }

    public function testTransform(): void
    {
        $this->modelManager->expects($this->once())
            ->method('getNormalizedIdentifier')
            ->willReturn(123);

        $transformer = new ModelToIdTransformer($this->modelManager, 'TEST');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertNull($transformer->transform(null));
        $this->assertNull($transformer->transform(false));
        $this->assertNull($transformer->transform(0));
        $this->assertNull($transformer->transform('0'));

        $this->assertSame(123, $transformer->transform(new \stdClass()));
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\AdminBundle\Tests\Form\DataTransformer;
15
16			use PHPUnit\Framework\TestCase;
17			use Sonata\AdminBundle\Form\DataTransformer\ModelToIdTransformer;
18			use Sonata\AdminBundle\Model\ModelManagerInterface;
19
20			class ModelToIdTransformerTest extends TestCase
21			{
22			private $modelManager = null;
23
24			public function setUp(): void
25			{
26			$this->modelManager = $this->getMockForAbstractClass(ModelManagerInterface::class);
27			}
28
29			public function testReverseTransformWhenPassing0AsId(): void
30			{
31			$transformer = new ModelToIdTransformer($this->modelManager, 'TEST');
			0 ignored issues – show Documentation introduced 2019-09-28 09:38 UTC by Report Bug Copy Issue Report `$this->modelManager` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Sonata\AdminBundl...\ModelManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32
33			$this->modelManager
34			->expects($this->exactly(2))
35			->method('find')
36			->willReturn(true);
37
38			$this->assertFalse(\in_array(false, ['0', 0], true));
39
40			// we pass 0 as integer
41			$this->assertTrue($transformer->reverseTransform(0));
42
43			// we pass 0 as string
44			$this->assertTrue($transformer->reverseTransform('0'));
45
46			// we pass null must return null
47			$this->assertNull($transformer->reverseTransform(null));
48
49			// we pass false, must return null
50			$this->assertNull($transformer->reverseTransform(false));
51			}
52
53			/**
54			* @dataProvider getReverseTransformValues
55			*/
56			public function testReverseTransform($value, $expected): void
57			{
58			$transformer = new ModelToIdTransformer($this->modelManager, 'TEST2');
			0 ignored issues – show Documentation introduced 2019-09-28 09:38 UTC by Report Bug Copy Issue Report `$this->modelManager` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Sonata\AdminBundl...\ModelManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
59
60			$this->modelManager->expects($this->any())->method('find');
61
62			$this->assertSame($expected, $transformer->reverseTransform($value));
63			}
64
65			public function getReverseTransformValues()
66			{
67			return [
68			[null, null],
69			[false, null],
70			[[], null],
71			['', null],
72			];
73			}
74
75			public function testTransform(): void
76			{
77			$this->modelManager->expects($this->once())
78			->method('getNormalizedIdentifier')
79			->willReturn(123);
80
81			$transformer = new ModelToIdTransformer($this->modelManager, 'TEST');
			0 ignored issues – show Documentation introduced 2019-09-28 09:38 UTC by Report Bug Copy Issue Report `$this->modelManager` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Sonata\AdminBundl...\ModelManagerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
82
83			$this->assertNull($transformer->transform(null));
84			$this->assertNull($transformer->transform(false));
85			$this->assertNull($transformer->transform(0));
86			$this->assertNull($transformer->transform('0'));
87
88			$this->assertSame(123, $transformer->transform(new \stdClass()));
89			}
90			}
91

sonata-project / SonataAdminBundle

Push — master ( 46c3a0...a94e83 )

ModelToIdTransformerTest::setUp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like