Completed
Pull Request — master (#4669)
by Jordi Sala
05:03 queued 01:37
created
Tests/Controller/CRUDControllerTest.php 2 patches
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -3702,6 +3702,9 @@  discard block
 block discarded – undo
3702 3702
         );
3703 3703
     }
3704 3704
 
3705
+    /**
3706
+     * @param string $method
3707
+     */
3705 3708
     private function assertLoggerLogsModelManagerException($subject, $method)
3706 3709
     {
3707 3710
         $exception = new ModelManagerException(
@@ -3724,6 +3727,10 @@  discard block
 block discarded – undo
3724 3727
             ));
3725 3728
     }
3726 3729
 
3730
+    /**
3731
+     * @param string $id
3732
+     * @param string $domain
3733
+     */
3727 3734
     private function expectTranslate($id, array $parameters = array(), $domain = null, $locale = null)
3728 3735
     {
3729 3736
         $this->translator->expects($this->once())
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use Symfony\Component\HttpFoundation\Session\Session;
34 34
 use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;
35 35
 use Symfony\Component\HttpKernel\Exception\HttpException;
36
-use Symfony\Component\HttpKernel\Kernel;
37 36
 use Symfony\Component\HttpKernel\KernelInterface;
38 37
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
39 38
 use Symfony\Component\Security\Csrf\CsrfToken;
Please login to merge, or discard this patch.
Tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -257,6 +257,12 @@
 block discarded – undo
257 257
         ), array_keys($this->datagrid->getFilters()));
258 258
     }
259 259
 
260
+    /**
261
+     * @param string $name
262
+     * @param string $label
263
+     *
264
+     * @return string
265
+     */
260 266
     private function getFieldDescriptionMock($name = null, $label = null)
261 267
     {
262 268
         $fieldDescription = $this->getMockForAbstractClass('Sonata\AdminBundle\Admin\BaseFieldDescription');
Please login to merge, or discard this patch.
Tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -245,6 +245,10 @@
 block discarded – undo
245 245
         ), true), print_r($this->fieldDescriptionCollection->getElements(), true));
246 246
     }
247 247
 
248
+    /**
249
+     * @param string $name
250
+     * @param string $label
251
+     */
248 252
     private function getFieldDescriptionMock($name = null, $label = null)
249 253
     {
250 254
         $fieldDescription = $this->getMockForAbstractClass('Sonata\AdminBundle\Admin\BaseFieldDescription');
Please login to merge, or discard this patch.
Tests/Datagrid/PagerTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -640,6 +640,10 @@
 block discarded – undo
640 640
         $this->assertSame(null, $this->pager->getQuery());
641 641
     }
642 642
 
643
+    /**
644
+     * @param Pager $obj
645
+     * @param string $name
646
+     */
643 647
     protected function callMethod($obj, $name, array $args = array())
644 648
     {
645 649
         $class = new \ReflectionClass($obj);
Please login to merge, or discard this patch.
Tests/Fixtures/Admin/PostAdmin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -8,6 +8,9 @@
 block discarded – undo
8 8
 {
9 9
     protected $metadataClass = null;
10 10
 
11
+    /**
12
+     * @param string $associationMapping
13
+     */
11 14
     public function setParentAssociationMapping($associationMapping)
12 15
     {
13 16
         $this->parentAssociationMapping = $associationMapping;
Please login to merge, or discard this patch.
Tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -450,6 +450,10 @@
 block discarded – undo
450 450
         $this->showMapper = new ShowMapper($this->showBuilder, $this->fieldDescriptionCollection, $this->admin);
451 451
     }
452 452
 
453
+    /**
454
+     * @param string $name
455
+     * @param string $label
456
+     */
453 457
     private function getFieldDescriptionMock($name = null, $label = null)
454 458
     {
455 459
         $fieldDescription = $this->getMockForAbstractClass('Sonata\AdminBundle\Admin\BaseFieldDescription');
Please login to merge, or discard this patch.
Tests/Twig/Extension/SonataAdminExtensionTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -2209,6 +2209,9 @@
 block discarded – undo
2209 2209
         return htmlspecialchars(http_build_query($url, '', '&'));
2210 2210
     }
2211 2211
 
2212
+    /**
2213
+     * @param string $privateMethod
2214
+     */
2212 2215
     private function getMethodAsPublic($privateMethod)
2213 2216
     {
2214 2217
         $reflection = new \ReflectionMethod('Sonata\AdminBundle\Twig\Extension\SonataAdminExtension', $privateMethod);
Please login to merge, or discard this patch.
Twig/Extension/SonataAdminExtension.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     /**
123 123
      * render a list element from the FieldDescription.
124 124
      *
125
-     * @param mixed                     $object
125
+     * @param \stdClass                     $object
126 126
      * @param FieldDescriptionInterface $fieldDescription
127 127
      * @param array                     $params
128 128
      *
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
      * render a view element.
153 153
      *
154 154
      * @param FieldDescriptionInterface $fieldDescription
155
-     * @param mixed                     $object
155
+     * @param \stdClass                     $object
156 156
      *
157 157
      * @return string
158 158
      */
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
     /**
292 292
      * Get the identifiers as a string that is safe to use in a url.
293 293
      *
294
-     * @param object         $model
294
+     * @param \stdClass         $model
295 295
      * @param AdminInterface $admin
296 296
      *
297 297
      * @return string string representation of the id that is safe to use in a url
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
     /**
317 317
      * @param $type
318 318
      *
319
-     * @return string|bool
319
+     * @return string|false
320 320
      */
321 321
     public function getXEditableType($type)
322 322
     {
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
      * @param FieldDescriptionInterface $fieldDescription
448 448
      * @param string                    $defaultTemplate
449 449
      *
450
-     * @return \Twig_TemplateInterface
450
+     * @return \Twig_Template
451 451
      */
452 452
     private function getTemplate(
453 453
         FieldDescriptionInterface $fieldDescription,
Please login to merge, or discard this patch.
Admin/AbstractAdminExtension.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -62,6 +62,7 @@
 block discarded – undo
62 62
 
63 63
     /**
64 64
      * {@inheritdoc}
65
+     * @param string $action
65 66
      */
66 67
     public function configureSideMenu(AdminInterface $admin, MenuItemInterface $menu, $action, AdminInterface $childAdmin = null)
67 68
     {
Please login to merge, or discard this patch.