AdminAclManipulator::addAdminClassAces() - Code Metrics - Inspection of "PHPStan Level 2" - sonata-project/SonataAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 3.x (#6161)

unknown

created 2020-06-27 14:48 UTC

AdminAclManipulator::addAdminClassAces() C

↳ Parent: AdminAclManipulator

Complexity

Conditions	11
Paths	24

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	52
c	0
b	0
f	0
rs	6.9006
cc	11
nc	24
nop	4

How to fix Long Method Complexity

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\AdminBundle\Util;

use Sonata\AdminBundle\Admin\AdminInterface;
use Sonata\AdminBundle\Security\Handler\AclSecurityHandlerInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Security\Acl\Domain\ObjectIdentity;
use Symfony\Component\Security\Acl\Domain\RoleSecurityIdentity;
use Symfony\Component\Security\Acl\Model\AclInterface;
use Symfony\Component\Security\Acl\Model\MutableAclInterface;

/**
 * @final since sonata-project/admin-bundle 3.52
 *
 * @author Thomas Rabaix <[email protected]>
 */
class AdminAclManipulator implements AdminAclManipulatorInterface
{
    /**
     * @var string
     */
    protected $maskBuilderClass;

    /**
     * @param string $maskBuilderClass
     */
    public function __construct($maskBuilderClass)
    {
        $this->maskBuilderClass = $maskBuilderClass;
    }

    public function configureAcls(OutputInterface $output, AdminInterface $admin)
    {
        $securityHandler = $admin->getSecurityHandler();
        if (!$securityHandler instanceof AclSecurityHandlerInterface) {
            $output->writeln(sprintf('Admin `%s` is not configured to use ACL : <info>ignoring</info>', $admin->getCode()));

            return;
        }

        $objectIdentity = ObjectIdentity::fromDomainObject($admin);
        $newAcl = false;
        if (null === ($acl = $securityHandler->getObjectAcl($objectIdentity))) {
            $acl = $securityHandler->createAcl($objectIdentity);
            $newAcl = true;
        }

        // create admin ACL
        $output->writeln(sprintf(' > install ACL for %s', $admin->getCode()));
        $configResult = $this->addAdminClassAces($output, $acl, $securityHandler, $securityHandler->buildSecurityInformation($admin));

        if ($configResult) {
            $securityHandler->updateAcl($acl);
        } else {
            $output->writeln(sprintf('   - %s , no roles and permissions found', ($newAcl ? 'skip' : 'removed')));
            $securityHandler->deleteAcl($objectIdentity);
        }
    }

    public function addAdminClassAces(
        OutputInterface $output,
        AclInterface $acl,
        AclSecurityHandlerInterface $securityHandler,
        array $roleInformation = []
    ) {
        if (!$acl instanceof MutableAclInterface) {
            throw new \InvalidArgumentException('$acl must implement '.MutableAclInterface::class);
        }
        if (\count($securityHandler->getAdminPermissions()) > 0) {
            $builder = new $this->maskBuilderClass();

            foreach ($roleInformation as $role => $permissions) {
                $aceIndex = $securityHandler->findClassAceIndexByRole($acl, $role);
                $roleAdminPermissions = [];

                foreach ($permissions as $permission) {
                    // add only the admin permissions
                    if (\in_array($permission, $securityHandler->getAdminPermissions(), true)) {
                        $builder->add($permission);
                        $roleAdminPermissions[] = $permission;
                    }
                }

                if (\count($roleAdminPermissions) > 0) {
                    if (false === $aceIndex) {
                        $acl->insertClassAce(new RoleSecurityIdentity($role), $builder->get());
                        $action = 'add';
                    } else {
                        $acl->updateClassAce($aceIndex, $builder->get());
                        $action = 'update';
                    }

                    if (null !== $output) {
                        $output->writeln(sprintf('   - %s role: %s, permissions: %s', $action, $role, json_encode($roleAdminPermissions)));
                    }

                    $builder->reset();
                } elseif (false !== $aceIndex) {
                    $acl->deleteClassAce($aceIndex);

                    if (null !== $output) {
                        $output->writeln(sprintf('   - remove role: %s', $role));
                    }
                }
            }

            return true;
        }

        return false;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\AdminBundle\Util;
15
16			use Sonata\AdminBundle\Admin\AdminInterface;
17			use Sonata\AdminBundle\Security\Handler\AclSecurityHandlerInterface;
18			use Symfony\Component\Console\Output\OutputInterface;
19			use Symfony\Component\Security\Acl\Domain\ObjectIdentity;
20			use Symfony\Component\Security\Acl\Domain\RoleSecurityIdentity;
21			use Symfony\Component\Security\Acl\Model\AclInterface;
22			use Symfony\Component\Security\Acl\Model\MutableAclInterface;
23
24			/**
25			* @final since sonata-project/admin-bundle 3.52
26			*
27			* @author Thomas Rabaix <[email protected]>
28			*/
29			class AdminAclManipulator implements AdminAclManipulatorInterface
30			{
31			/**
32			* @var string
33			*/
34			protected $maskBuilderClass;
35
36			/**
37			* @param string $maskBuilderClass
38			*/
39			public function __construct($maskBuilderClass)
40			{
41			$this->maskBuilderClass = $maskBuilderClass;
42			}
43
44			public function configureAcls(OutputInterface $output, AdminInterface $admin)
45			{
46			$securityHandler = $admin->getSecurityHandler();
47			if (!$securityHandler instanceof AclSecurityHandlerInterface) {
48			$output->writeln(sprintf('Admin `%s` is not configured to use ACL : <info>ignoring</info>', $admin->getCode()));
49
50			return;
51			}
52
53			$objectIdentity = ObjectIdentity::fromDomainObject($admin);
54			$newAcl = false;
55			if (null === ($acl = $securityHandler->getObjectAcl($objectIdentity))) {
56			$acl = $securityHandler->createAcl($objectIdentity);
57			$newAcl = true;
58			}
59
60			// create admin ACL
61			$output->writeln(sprintf(' > install ACL for %s', $admin->getCode()));
62			$configResult = $this->addAdminClassAces($output, $acl, $securityHandler, $securityHandler->buildSecurityInformation($admin));
63
64			if ($configResult) {
65			$securityHandler->updateAcl($acl);
66			} else {
67			$output->writeln(sprintf(' - %s , no roles and permissions found', ($newAcl ? 'skip' : 'removed')));
68			$securityHandler->deleteAcl($objectIdentity);
69			}
70			}
71
72			public function addAdminClassAces(
73			OutputInterface $output,
74			AclInterface $acl,
75			AclSecurityHandlerInterface $securityHandler,
76			array $roleInformation = []
77			) {
78			if (!$acl instanceof MutableAclInterface) {
79			throw new \InvalidArgumentException('$acl must implement '.MutableAclInterface::class);
80			}
81			if (\count($securityHandler->getAdminPermissions()) > 0) {
82			$builder = new $this->maskBuilderClass();
83
84			foreach ($roleInformation as $role => $permissions) {
85			$aceIndex = $securityHandler->findClassAceIndexByRole($acl, $role);
86			$roleAdminPermissions = [];
87
88			foreach ($permissions as $permission) {
89			// add only the admin permissions
90			if (\in_array($permission, $securityHandler->getAdminPermissions(), true)) {
91			$builder->add($permission);
92			$roleAdminPermissions[] = $permission;
93			}
94			}
95
96			if (\count($roleAdminPermissions) > 0) {
97			if (false === $aceIndex) {
98			$acl->insertClassAce(new RoleSecurityIdentity($role), $builder->get());
99			$action = 'add';
100			} else {
101			$acl->updateClassAce($aceIndex, $builder->get());
102			$action = 'update';
103			}
104
105			if (null !== $output) {
106			$output->writeln(sprintf(' - %s role: %s, permissions: %s', $action, $role, json_encode($roleAdminPermissions)));
107			}
108
109			$builder->reset();
110			} elseif (false !== $aceIndex) {
111			$acl->deleteClassAce($aceIndex);
112
113			if (null !== $output) {
114			$output->writeln(sprintf(' - remove role: %s', $role));
115			}
116			}
117			}
118
119			return true;
120			}
121
122			return false;
123			}
124			}
125

sonata-project / SonataAdminBundle

Pull Request — 3.x (#6161)

AdminAclManipulator::addAdminClassAces() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like