Completed
Pull Request — 3.x (#6053)
by Oskar
02:52
created
tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -292,6 +292,10 @@
 block discarded – undo
292 292
         $this->assertTrue($this->datagridMapper->has('baz'));
293 293
     }
294 294
 
295
+    /**
296
+     * @param string $name
297
+     * @param string $label
298
+     */
295 299
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
296 300
     {
297 301
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -286,6 +286,10 @@
 block discarded – undo
286 286
         $this->assertTrue($this->listMapper->has('baz'));
287 287
     }
288 288
 
289
+    /**
290
+     * @param string $name
291
+     * @param string $label
292
+     */
289 293
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
290 294
     {
291 295
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -501,6 +501,10 @@
 block discarded – undo
501 501
         $this->admin->setLabelTranslatorStrategy(new NoopLabelTranslatorStrategy());
502 502
     }
503 503
 
504
+    /**
505
+     * @param string $name
506
+     * @param string $label
507
+     */
504 508
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
505 509
     {
506 510
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Security/Handler/SecurityHandlerInterface.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 interface SecurityHandlerInterface
22 22
 {
23 23
     /**
24
-     * @param string|array $attributes
24
+     * @param string $attributes
25 25
      * @param mixed|null   $object
26 26
      *
27 27
      * @return bool
@@ -44,6 +44,7 @@  discard block
 block discarded – undo
44 44
      * Create object security, fe. make the current user owner of the object.
45 45
      *
46 46
      * @param object $object
47
+     * @return void
47 48
      */
48 49
     public function createObjectSecurity(AdminInterface $admin, $object);
49 50
 
@@ -51,6 +52,7 @@  discard block
 block discarded – undo
51 52
      * Remove object security.
52 53
      *
53 54
      * @param object $object
55
+     * @return void
54 56
      */
55 57
     public function deleteObjectSecurity(AdminInterface $admin, $object);
56 58
 }
Please login to merge, or discard this patch.
tests/Datagrid/PagerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -647,6 +647,9 @@
 block discarded – undo
647 647
         $this->assertNull($this->pager->getQuery());
648 648
     }
649 649
 
650
+    /**
651
+     * @param Pager $obj
652
+     */
650 653
     protected function callMethod($obj, string $name, array $args = [])
651 654
     {
652 655
         $class = new \ReflectionClass($obj);
Please login to merge, or discard this patch.
src/Command/QuestionableCommand.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 {
25 25
     /**
26 26
      * @param string   $questionText
27
-     * @param mixed    $default
27
+     * @param string    $default
28 28
      * @param callable $validator
29 29
      *
30 30
      * @return mixed
Please login to merge, or discard this patch.
src/Model/ModelManagerInterface.php 1 patch
Doc Comments   +11 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,6 +37,7 @@  discard block
 block discarded – undo
37 37
      * @param object $object
38 38
      *
39 39
      * @throws ModelManagerException
40
+     * @return void
40 41
      */
41 42
     public function create($object);
42 43
 
@@ -44,6 +45,7 @@  discard block
 block discarded – undo
44 45
      * @param object $object
45 46
      *
46 47
      * @throws ModelManagerException
48
+     * @return void
47 49
      */
48 50
     public function update($object);
49 51
 
@@ -51,6 +53,7 @@  discard block
 block discarded – undo
51 53
      * @param object $object
52 54
      *
53 55
      * @throws ModelManagerException
56
+     * @return void
54 57
      */
55 58
     public function delete($object);
56 59
 
@@ -72,7 +75,7 @@  discard block
 block discarded – undo
72 75
      * @param string $class
73 76
      * @param mixed  $id
74 77
      *
75
-     * @return object|null the object with id or null if not found
78
+     * @return \Sonata\AdminBundle\Tests\App\Model\Foo|null the object with id or null if not found
76 79
      */
77 80
     public function find($class, $id);
78 81
 
@@ -80,6 +83,7 @@  discard block
 block discarded – undo
80 83
      * @param string $class
81 84
      *
82 85
      * @throws ModelManagerException
86
+     * @return void
83 87
      */
84 88
     public function batchDelete($class, ProxyQueryInterface $queryProxy);
85 89
 
@@ -156,7 +160,7 @@  discard block
 block discarded – undo
156 160
      *
157 161
      * @param string $class
158 162
      *
159
-     * @return object
163
+     * @return \Sonata\AdminBundle\Tests\App\Model\Foo
160 164
      */
161 165
     public function getModelInstance($class);
162 166
 
@@ -172,6 +176,7 @@  discard block
 block discarded – undo
172 176
      *
173 177
      * @param array  $collection
174 178
      * @param object $element
179
+     * @return void
175 180
      */
176 181
     public function collectionRemoveElement(&$collection, &$element);
177 182
 
@@ -180,6 +185,7 @@  discard block
 block discarded – undo
180 185
      *
181 186
      * @param array  $collection
182 187
      * @param object $element
188
+     * @return void
183 189
      */
184 190
     public function collectionAddElement(&$collection, &$element);
185 191
 
@@ -197,6 +203,7 @@  discard block
 block discarded – undo
197 203
      * Clear the collection.
198 204
      *
199 205
      * @param array $collection
206
+     * @return void
200 207
      */
201 208
     public function collectionClear(&$collection);
202 209
 
@@ -229,6 +236,7 @@  discard block
 block discarded – undo
229 236
 
230 237
     /**
231 238
      * @param mixed $query
239
+     * @return void
232 240
      */
233 241
     public function executeQuery($query);
234 242
 
@@ -261,6 +269,7 @@  discard block
 block discarded – undo
261 269
 
262 270
     /**
263 271
      * @param string $class
272
+     * @return void
264 273
      */
265 274
     public function addIdentifiersToQuery($class, ProxyQueryInterface $query, array $idx);
266 275
 }
Please login to merge, or discard this patch.
src/Filter/FilterInterface.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,6 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
     /**
64 64
      * @param string $label
65
+     * @return void
65 66
      */
66 67
     public function setLabel($label);
67 68
 
@@ -72,7 +73,7 @@  discard block
 block discarded – undo
72 73
 
73 74
     /**
74 75
      * @param string     $name
75
-     * @param mixed|null $default
76
+     * @param boolean $default
76 77
      *
77 78
      * @return mixed
78 79
      */
@@ -80,12 +81,14 @@  discard block
 block discarded – undo
80 81
 
81 82
     /**
82 83
      * @param string $name
83
-     * @param mixed  $value
84
+     * @param boolean  $value
85
+     * @return void
84 86
      */
85 87
     public function setOption($name, $value);
86 88
 
87 89
     /**
88 90
      * @param string $name
91
+     * @return void
89 92
      */
90 93
     public function initialize($name, array $options = []);
91 94
 
@@ -129,6 +132,7 @@  discard block
 block discarded – undo
129 132
      *
130 133
      * @param string $name
131 134
      * @param mixed  $value
135
+     * @return void
132 136
      */
133 137
     public function setFieldOption($name, $value);
134 138
 
@@ -155,6 +159,7 @@  discard block
 block discarded – undo
155 159
      * Set the condition to use with the left side of the query : OR or AND.
156 160
      *
157 161
      * @param string $condition
162
+     * @return void
158 163
      */
159 164
     public function setCondition($condition);
160 165
 
Please login to merge, or discard this patch.
src/Admin/AdminInterface.php 1 patch
Doc Comments   +75 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,6 +48,9 @@  discard block
 block discarded – undo
48 48
  */
49 49
 interface AdminInterface extends AccessRegistryInterface, FieldDescriptionRegistryInterface, LifecycleHookProviderInterface, MenuBuilderInterface, ParentAdminInterface, UrlGeneratorInterface
50 50
 {
51
+    /**
52
+     * @return void
53
+     */
51 54
     public function setMenuFactory(MenuFactoryInterface $menuFactory);
52 55
 
53 56
     /**
@@ -55,8 +58,14 @@  discard block
 block discarded – undo
55 58
      */
56 59
     public function getMenuFactory();
57 60
 
61
+    /**
62
+     * @return void
63
+     */
58 64
     public function setFormContractor(FormContractorInterface $formContractor);
59 65
 
66
+    /**
67
+     * @return void
68
+     */
60 69
     public function setListBuilder(ListBuilderInterface $listBuilder);
61 70
 
62 71
     /**
@@ -64,6 +73,9 @@  discard block
 block discarded – undo
64 73
      */
65 74
     public function getListBuilder();
66 75
 
76
+    /**
77
+     * @return void
78
+     */
67 79
     public function setDatagridBuilder(DatagridBuilderInterface $datagridBuilder);
68 80
 
69 81
     /**
@@ -71,6 +83,9 @@  discard block
 block discarded – undo
71 83
      */
72 84
     public function getDatagridBuilder();
73 85
 
86
+    /**
87
+     * @return void
88
+     */
74 89
     public function setTranslator(TranslatorInterface $translator);
75 90
 
76 91
     /**
@@ -78,8 +93,14 @@  discard block
 block discarded – undo
78 93
      */
79 94
     public function getTranslator();
80 95
 
96
+    /**
97
+     * @return void
98
+     */
81 99
     public function setRequest(Request $request);
82 100
 
101
+    /**
102
+     * @return void
103
+     */
83 104
     public function setConfigurationPool(Pool $pool);
84 105
 
85 106
     /**
@@ -92,6 +113,9 @@  discard block
 block discarded – undo
92 113
      */
93 114
     public function getClass();
94 115
 
116
+    /**
117
+     * @return void
118
+     */
95 119
     public function attachAdminClass(FieldDescriptionInterface $fieldDescription);
96 120
 
97 121
     /**
@@ -103,6 +127,7 @@  discard block
 block discarded – undo
103 127
      * Set base controller name.
104 128
      *
105 129
      * @param string $baseControllerName
130
+     * @return void
106 131
      */
107 132
     public function setBaseControllerName($baseControllerName);
108 133
 
@@ -175,6 +200,9 @@  discard block
 block discarded – undo
175 200
      */
176 201
     public function getSecurityInformation();
177 202
 
203
+    /**
204
+     * @return void
205
+     */
178 206
     public function setParentFieldDescription(FieldDescriptionInterface $parentFieldDescription);
179 207
 
180 208
     /**
@@ -222,6 +250,9 @@  discard block
 block discarded – undo
222 250
      */
223 251
     public function hasRoute($name);
224 252
 
253
+    /**
254
+     * @return void
255
+     */
225 256
     public function setSecurityHandler(SecurityHandlerInterface $securityHandler);
226 257
 
227 258
     /**
@@ -249,12 +280,13 @@  discard block
 block discarded – undo
249 280
      *
250 281
      * @param object $entity
251 282
      *
252
-     * @return mixed
283
+     * @return string
253 284
      */
254 285
     public function id($entity);
255 286
 
256 287
     /**
257 288
      * @param ValidatorInterface $validator
289
+     * @return void
258 290
      */
259 291
     public function setValidator($validator);
260 292
 
@@ -268,6 +300,9 @@  discard block
 block discarded – undo
268 300
      */
269 301
     public function getShow();
270 302
 
303
+    /**
304
+     * @return void
305
+     */
271 306
     public function setFormTheme(array $formTheme);
272 307
 
273 308
     /**
@@ -275,6 +310,9 @@  discard block
 block discarded – undo
275 310
      */
276 311
     public function getFormTheme();
277 312
 
313
+    /**
314
+     * @return void
315
+     */
278 316
     public function setFilterTheme(array $filterTheme);
279 317
 
280 318
     /**
@@ -282,6 +320,9 @@  discard block
 block discarded – undo
282 320
      */
283 321
     public function getFilterTheme();
284 322
 
323
+    /**
324
+     * @return void
325
+     */
285 326
     public function addExtension(AdminExtensionInterface $extension);
286 327
 
287 328
     /**
@@ -291,6 +332,9 @@  discard block
 block discarded – undo
291 332
      */
292 333
     public function getExtensions();
293 334
 
335
+    /**
336
+     * @return void
337
+     */
294 338
     public function setRouteBuilder(RouteBuilderInterface $routeBuilder);
295 339
 
296 340
     /**
@@ -305,6 +349,9 @@  discard block
 block discarded – undo
305 349
      */
306 350
     public function toString($object);
307 351
 
352
+    /**
353
+     * @return void
354
+     */
308 355
     public function setLabelTranslatorStrategy(LabelTranslatorStrategyInterface $labelTranslatorStrategy);
309 356
 
310 357
     /**
@@ -328,6 +375,7 @@  discard block
 block discarded – undo
328 375
 
329 376
     /**
330 377
      * @param string $uniqId
378
+     * @return void
331 379
      */
332 380
     public function setUniqid($uniqId);
333 381
 
@@ -347,6 +395,7 @@  discard block
 block discarded – undo
347 395
 
348 396
     /**
349 397
      * @param object|null $subject
398
+     * @return void
350 399
      */
351 400
     public function setSubject($subject);
352 401
 
@@ -394,6 +443,9 @@  discard block
 block discarded – undo
394 443
      */
395 444
     public function getDataSourceIterator();
396 445
 
446
+    /**
447
+     * @return void
448
+     */
397 449
     public function configure();
398 450
 
399 451
     /**
@@ -401,6 +453,7 @@  discard block
 block discarded – undo
401 453
      *
402 454
      * @param string $actionName
403 455
      * @param bool   $allElements
456
+     * @return void
404 457
      */
405 458
     public function preBatchAction($actionName, ProxyQueryInterface $query, array &$idx, $allElements);
406 459
 
@@ -425,6 +478,7 @@  discard block
 block discarded – undo
425 478
      *
426 479
      * @deprecated this feature cannot be stable, use a custom validator,
427 480
      *             the feature will be removed with Symfony 2.2
481
+     * @return void
428 482
      */
429 483
     public function validate(ErrorElement $errorElement, $object);
430 484
 
@@ -439,6 +493,7 @@  discard block
 block discarded – undo
439 493
      * Add object security, fe. make the current user owner of the object.
440 494
      *
441 495
      * @param object $object
496
+     * @return void
442 497
      */
443 498
     public function createObjectSecurity($object);
444 499
 
@@ -447,6 +502,9 @@  discard block
 block discarded – undo
447 502
      */
448 503
     public function getParent();
449 504
 
505
+    /**
506
+     * @return void
507
+     */
450 508
     public function setParent(self $admin);
451 509
 
452 510
     /**
@@ -471,6 +529,7 @@  discard block
 block discarded – undo
471 529
      * Set the translation domain.
472 530
      *
473 531
      * @param string $translationDomain the translation domain
532
+     * @return void
474 533
      */
475 534
     public function setTranslationDomain($translationDomain);
476 535
 
@@ -492,6 +551,7 @@  discard block
 block discarded – undo
492 551
 
493 552
     /**
494 553
      * Set the form groups.
554
+     * @return void
495 555
      */
496 556
     public function setFormGroups(array $formGroups);
497 557
 
@@ -500,6 +560,9 @@  discard block
 block discarded – undo
500 560
      */
501 561
     public function getFormTabs();
502 562
 
563
+    /**
564
+     * @return void
565
+     */
503 566
     public function setFormTabs(array $formTabs);
504 567
 
505 568
     /**
@@ -507,12 +570,16 @@  discard block
 block discarded – undo
507 570
      */
508 571
     public function getShowTabs();
509 572
 
573
+    /**
574
+     * @return void
575
+     */
510 576
     public function setShowTabs(array $showTabs);
511 577
 
512 578
     /**
513 579
      * Remove a form group field.
514 580
      *
515 581
      * @param string $key
582
+     * @return void
516 583
      */
517 584
     public function removeFieldFromFormGroup($key);
518 585
 
@@ -527,6 +594,7 @@  discard block
 block discarded – undo
527 594
 
528 595
     /**
529 596
      * Set the show groups.
597
+     * @return void
530 598
      */
531 599
     public function setShowGroups(array $showGroups);
532 600
 
@@ -534,6 +602,7 @@  discard block
 block discarded – undo
534 602
      * Reorder items in showGroup.
535 603
      *
536 604
      * @param string $group
605
+     * @return void
537 606
      */
538 607
     public function reorderShowGroup($group, array $keys);
539 608
 
@@ -541,6 +610,7 @@  discard block
 block discarded – undo
541 610
      * add a FieldDescription.
542 611
      *
543 612
      * @param string $name
613
+     * @return void
544 614
      */
545 615
     public function addFormFieldDescription($name, FieldDescriptionInterface $fieldDescription);
546 616
 
@@ -548,6 +618,7 @@  discard block
 block discarded – undo
548 618
      * Remove a FieldDescription.
549 619
      *
550 620
      * @param string $name
621
+     * @return void
551 622
      */
552 623
     public function removeFormFieldDescription($name);
553 624
 
@@ -560,6 +631,7 @@  discard block
 block discarded – undo
560 631
 
561 632
     /**
562 633
      * Sets the list of supported sub classes.
634
+     * @return void
563 635
      */
564 636
     public function setSubClasses(array $subClasses);
565 637
 
@@ -628,6 +700,7 @@  discard block
 block discarded – undo
628 700
      * Set the current child status.
629 701
      *
630 702
      * @param bool $currentChild
703
+     * @return void
631 704
      */
632 705
     public function setCurrentChild($currentChild);
633 706
 
@@ -675,6 +748,7 @@  discard block
 block discarded – undo
675 748
 
676 749
     /**
677 750
      * @param string $mode
751
+     * @return void
678 752
      */
679 753
     public function setListMode($mode);
680 754
 
Please login to merge, or discard this patch.