Completed
Pull Request — master (#4938)
by Andrey F.
03:47
created
tests/Twig/Extension/SonataAdminExtensionTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -2210,6 +2210,9 @@
 block discarded – undo
2210 2210
         return htmlspecialchars(http_build_query($url, '', '&', PHP_QUERY_RFC3986));
2211 2211
     }
2212 2212
 
2213
+    /**
2214
+     * @param string $privateMethod
2215
+     */
2213 2216
     private function getMethodAsPublic($privateMethod)
2214 2217
     {
2215 2218
         $reflection = new \ReflectionMethod('Sonata\AdminBundle\Twig\Extension\SonataAdminExtension', $privateMethod);
Please login to merge, or discard this patch.
src/Admin/Pool.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
     }
296 296
 
297 297
     /**
298
-     * @return array
298
+     * @return string[]
299 299
      */
300 300
     public function getAdminServiceIds()
301 301
     {
@@ -321,7 +321,7 @@  discard block
 block discarded – undo
321 321
     }
322 322
 
323 323
     /**
324
-     * @return array
324
+     * @return string[]
325 325
      */
326 326
     public function getTemplates()
327 327
     {
Please login to merge, or discard this patch.
src/Form/ChoiceList/ModelChoiceList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
      * @param string            $class
102 102
      * @param string|null       $property
103 103
      * @param QueryBuilder|null $query
104
-     * @param array             $choices
104
+     * @param integer[]             $choices
105 105
      */
106 106
     public function __construct(
107 107
         ModelManagerInterface $modelManager,
Please login to merge, or discard this patch.
src/Generator/AdminGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     private $file;
38 38
 
39 39
     /**
40
-     * @param array|string $skeletonDirectories
40
+     * @param string $skeletonDirectories
41 41
      */
42 42
     public function __construct(ModelManagerInterface $modelManager, $skeletonDirectories)
43 43
     {
Please login to merge, or discard this patch.
src/Controller/PolyfillControllerTrait.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -27,6 +27,9 @@
 block discarded – undo
27 27
  */
28 28
 trait PolyfillControllerTrait
29 29
 {
30
+    /**
31
+     * @param string $methodName
32
+     */
30 33
     public function __call($methodName, $arguments): void
31 34
     {
32 35
         $this->proxyToController($methodName, $arguments);
Please login to merge, or discard this patch.
tests/Admin/Extension/LockExtensionTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -210,6 +210,10 @@
 block discarded – undo
210 210
         return new FormMapper($contractor->reveal(), $formBuilder, $this->admin->reveal());
211 211
     }
212 212
 
213
+    /**
214
+     * @param string $uniqid
215
+     * @param Request $request
216
+     */
213 217
     private function configureAdmin($uniqid = null, $request = null, $modelManager = null): void
214 218
     {
215 219
         $this->admin->getUniqid()->willReturn($uniqid);
Please login to merge, or discard this patch.
tests/Controller/CRUDControllerTest.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -3685,6 +3685,9 @@  discard block
 block discarded – undo
3685 3685
         ];
3686 3686
     }
3687 3687
 
3688
+    /**
3689
+     * @param string $method
3690
+     */
3688 3691
     private function assertLoggerLogsModelManagerException($subject, $method): void
3689 3692
     {
3690 3693
         $exception = new ModelManagerException(
@@ -3707,6 +3710,10 @@  discard block
 block discarded – undo
3707 3710
             ]);
3708 3711
     }
3709 3712
 
3713
+    /**
3714
+     * @param string $id
3715
+     * @param string $domain
3716
+     */
3710 3717
     private function expectTranslate($id, array $parameters = [], $domain = null, $locale = null): void
3711 3718
     {
3712 3719
         $this->translator->expects($this->once())
Please login to merge, or discard this patch.
src/Datagrid/Pager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
      * Returns a parameter.
435 435
      *
436 436
      * @param string $name
437
-     * @param mixed  $default
437
+     * @param null|string  $default
438 438
      *
439 439
      * @return mixed
440 440
      */
@@ -459,7 +459,7 @@  discard block
 block discarded – undo
459 459
      * Sets a parameter.
460 460
      *
461 461
      * @param string $name
462
-     * @param mixed  $value
462
+     * @param string  $value
463 463
      */
464 464
     public function setParameter($name, $value): void
465 465
     {
Please login to merge, or discard this patch.
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -863,6 +863,7 @@  discard block
 block discarded – undo
863 863
 
864 864
     /**
865 865
      * NEXT_MAJOR: remove this method.
866
+     * @param string $subClass
866 867
      */
867 868
     public function addSubClass($subClass): void
868 869
     {
@@ -1962,7 +1963,7 @@  discard block
 block discarded – undo
1962 1963
      *
1963 1964
      * @param string $context
1964 1965
      *
1965
-     * @return array
1966
+     * @return string[]
1966 1967
      */
1967 1968
     public function getPermissionsShow($context)
1968 1969
     {
@@ -2477,6 +2478,9 @@  discard block
 block discarded – undo
2477 2478
     {
2478 2479
     }
2479 2480
 
2481
+    /**
2482
+     * @param string $action
2483
+     */
2480 2484
     protected function configureActionButtons($buttonList, $action, $object = null)
2481 2485
     {
2482 2486
         return $buttonList;
@@ -2497,6 +2501,7 @@  discard block
 block discarded – undo
2497 2501
     /**
2498 2502
      * NEXT_MAJOR: remove this method.
2499 2503
      *
2504
+     * @param string $action
2500 2505
      * @return mixed
2501 2506
      *
2502 2507
      * @deprecated Use configureTabMenu instead
Please login to merge, or discard this patch.