Completed
Pull Request — 3.x (#5199)
by Marko
11:58 queued 05:49
created
src/Twig/GlobalVariables.php 1 patch
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     /**
68 68
      * @param string $code
69 69
      * @param string $action
70
-     * @param array  $parameters
70
+     * @param string[]  $parameters
71 71
      * @param int    $absolute
72 72
      *
73 73
      * @return string
@@ -82,8 +82,8 @@  discard block
 block discarded – undo
82 82
     /**
83 83
      * @param string $code
84 84
      * @param string $action
85
-     * @param mixed  $object
86
-     * @param array  $parameters
85
+     * @param string  $object
86
+     * @param string[]  $parameters
87 87
      * @param int    $absolute
88 88
      *
89 89
      * @return string
@@ -96,6 +96,8 @@  discard block
 block discarded – undo
96 96
     }
97 97
 
98 98
     /**
99
+     * @param string $code
100
+     * @param string $action
99 101
      * @return array
100 102
      */
101 103
     private function getCodeAction($code, $action)
Please login to merge, or discard this patch.
src/Admin/Pool.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
      *
192 192
      * @param string $class
193 193
      *
194
-     * @return \Sonata\AdminBundle\Admin\AdminInterface|null
194
+     * @return AdminInterface
195 195
      */
196 196
     public function getAdminByClass($class)
197 197
     {
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
     }
304 304
 
305 305
     /**
306
-     * @return array
306
+     * @return string[]
307 307
      */
308 308
     public function getAdminServiceIds()
309 309
     {
Please login to merge, or discard this patch.
src/Admin/AdminExtensionInterface.php 1 patch
Doc Comments   +27 added lines patch added patch discarded remove patch
@@ -31,14 +31,29 @@  discard block
 block discarded – undo
31 31
  */
32 32
 interface AdminExtensionInterface
33 33
 {
34
+    /**
35
+     * @return void
36
+     */
34 37
     public function configureFormFields(FormMapper $formMapper);
35 38
 
39
+    /**
40
+     * @return void
41
+     */
36 42
     public function configureListFields(ListMapper $listMapper);
37 43
 
44
+    /**
45
+     * @return void
46
+     */
38 47
     public function configureDatagridFilters(DatagridMapper $datagridMapper);
39 48
 
49
+    /**
50
+     * @return void
51
+     */
40 52
     public function configureShowFields(ShowMapper $showMapper);
41 53
 
54
+    /**
55
+     * @return void
56
+     */
42 57
     public function configureRoutes(AdminInterface $admin, RouteCollection $collection);
43 58
 
44 59
     /**
@@ -49,6 +64,7 @@  discard block
 block discarded – undo
49 64
      * @param string $action
50 65
      *
51 66
      * @deprecated
67
+     * @return void
52 68
      */
53 69
     public function configureSideMenu(
54 70
         AdminInterface $admin,
@@ -61,6 +77,7 @@  discard block
 block discarded – undo
61 77
      * Builds the tab menu.
62 78
      *
63 79
      * @param string $action
80
+     * @return void
64 81
      */
65 82
     public function configureTabMenu(
66 83
         AdminInterface $admin,
@@ -71,11 +88,13 @@  discard block
 block discarded – undo
71 88
 
72 89
     /**
73 90
      * @param mixed $object
91
+     * @return void
74 92
      */
75 93
     public function validate(AdminInterface $admin, ErrorElement $errorElement, $object);
76 94
 
77 95
     /**
78 96
      * @param string $context
97
+     * @return void
79 98
      */
80 99
     public function configureQuery(AdminInterface $admin, ProxyQueryInterface $query, $context = 'list');
81 100
 
@@ -83,6 +102,7 @@  discard block
 block discarded – undo
83 102
      * Get a chance to modify a newly created instance.
84 103
      *
85 104
      * @param mixed $object
105
+     * @return void
86 106
      */
87 107
     public function alterNewInstance(AdminInterface $admin, $object);
88 108
 
@@ -90,6 +110,7 @@  discard block
 block discarded – undo
90 110
      * Get a chance to modify object instance.
91 111
      *
92 112
      * @param mixed $object
113
+     * @return void
93 114
      */
94 115
     public function alterObject(AdminInterface $admin, $object);
95 116
 
@@ -130,31 +151,37 @@  discard block
 block discarded – undo
130 151
 
131 152
     /**
132 153
      * @param mixed $object
154
+     * @return void
133 155
      */
134 156
     public function preUpdate(AdminInterface $admin, $object);
135 157
 
136 158
     /**
137 159
      * @param mixed $object
160
+     * @return void
138 161
      */
139 162
     public function postUpdate(AdminInterface $admin, $object);
140 163
 
141 164
     /**
142 165
      * @param mixed $object
166
+     * @return void
143 167
      */
144 168
     public function prePersist(AdminInterface $admin, $object);
145 169
 
146 170
     /**
147 171
      * @param mixed $object
172
+     * @return void
148 173
      */
149 174
     public function postPersist(AdminInterface $admin, $object);
150 175
 
151 176
     /**
152 177
      * @param mixed $object
178
+     * @return void
153 179
      */
154 180
     public function preRemove(AdminInterface $admin, $object);
155 181
 
156 182
     /**
157 183
      * @param mixed $object
184
+     * @return void
158 185
      */
159 186
     public function postRemove(AdminInterface $admin, $object);
160 187
 
Please login to merge, or discard this patch.
tests/Action/RetrieveAutocompleteItemsActionTest.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -257,6 +257,9 @@  discard block
 block discarded – undo
257 257
         return $datagrid;
258 258
     }
259 259
 
260
+    /**
261
+     * @param string $field
262
+     */
260 263
     private function configureFormConfig($field, $disabled = false)
261 264
     {
262 265
         $form = $this->prophesize(Form::class);
@@ -276,6 +279,9 @@  discard block
 block discarded – undo
276 279
         $formConfig->getAttribute('target_admin_access_action')->willReturn('list');
277 280
     }
278 281
 
282
+    /**
283
+     * @param string $field
284
+     */
279 285
     private function configureFormConfigComplexProperty($field)
280 286
     {
281 287
         $form = $this->prophesize(Form::class);
@@ -295,6 +301,9 @@  discard block
 block discarded – undo
295 301
         $formConfig->getAttribute('target_admin_access_action')->willReturn('list');
296 302
     }
297 303
 
304
+    /**
305
+     * @param string $field
306
+     */
298 307
     private function configureFormConfigComplexPropertyArray($field)
299 308
     {
300 309
         $form = $this->prophesize(Form::class);
Please login to merge, or discard this patch.
tests/Controller/HelperControllerTest.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -257,6 +257,9 @@  discard block
 block discarded – undo
257 257
         return $datagrid;
258 258
     }
259 259
 
260
+    /**
261
+     * @param string $field
262
+     */
260 263
     private function configureFormConfig($field, $disabled = false)
261 264
     {
262 265
         $form = $this->prophesize(Form::class);
@@ -276,6 +279,9 @@  discard block
 block discarded – undo
276 279
         $formConfig->getAttribute('target_admin_access_action')->willReturn('list');
277 280
     }
278 281
 
282
+    /**
283
+     * @param string $field
284
+     */
279 285
     private function configureFormConfigComplexProperty($field)
280 286
     {
281 287
         $form = $this->prophesize(Form::class);
@@ -295,6 +301,9 @@  discard block
 block discarded – undo
295 301
         $formConfig->getAttribute('target_admin_access_action')->willReturn('list');
296 302
     }
297 303
 
304
+    /**
305
+     * @param string $field
306
+     */
298 307
     private function configureFormConfigComplexPropertyArray($field)
299 308
     {
300 309
         $form = $this->prophesize(Form::class);
Please login to merge, or discard this patch.
src/Extension/Event/AlterNewInstanceMessage.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,6 @@
 block discarded – undo
29 29
     private $object;
30 30
 
31 31
     /**
32
-     * @param mixed $action
33 32
      */
34 33
     public function __construct(AdminInterface $admin, $object)
35 34
     {
Please login to merge, or discard this patch.