PoolTest::testGetInstanceWithUndefinedServiceId() - Code Metrics - Inspection of "Add support for unlimited nested child admins. (#4..." - sonata-project/SonataAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x ( f7534c...26d69b )

by Grégoire

created 2017-09-28 14:48 UTC

PoolTest::testGetInstanceWithUndefinedServiceId() A

↳ Parent: PoolTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\AdminBundle\Tests\Admin;

use Sonata\AdminBundle\Admin\Pool;
use Sonata\AdminBundle\Tests\Helpers\PHPUnit_Framework_TestCase;

class PoolTest extends PHPUnit_Framework_TestCase
{
    /**
     * @var Pool
     */
    private $pool = null;

    public function setUp()
    {
        $this->pool = new Pool($this->getContainer(), 'Sonata Admin', '/path/to/pic.png', array('foo' => 'bar'));
    }

    public function testGetGroups()
    {
        $this->pool->setAdminServiceIds(array('sonata.user.admin.group1'));

        $this->pool->setAdminGroups(array(
            'adminGroup1' => array('sonata.user.admin.group1' => array()),
        ));

        $expectedOutput = array(
            'adminGroup1' => array(
                'sonata.user.admin.group1' => 'sonata_user_admin_group1_AdminClass',
            ),
        );

        $this->assertSame($expectedOutput, $this->pool->getGroups());
    }

    public function testHasGroup()
    {
        $this->pool->setAdminGroups(array(
                'adminGroup1' => array(),
            ));

        $this->assertTrue($this->pool->hasGroup('adminGroup1'));
        $this->assertFalse($this->pool->hasGroup('adminGroup2'));
    }

    public function testGetDashboardGroups()
    {
        $admin_group1 = $this->createMock('Sonata\AdminBundle\Admin\AdminInterface');
        $admin_group1->expects($this->once())->method('showIn')->will($this->returnValue(true));

        $admin_group2 = $this->createMock('Sonata\AdminBundle\Admin\AdminInterface');
        $admin_group2->expects($this->once())->method('showIn')->will($this->returnValue(false));

        $admin_group3 = $this->createMock('Sonata\AdminBundle\Admin\AdminInterface');
        $admin_group3->expects($this->once())->method('showIn')->will($this->returnValue(false));

        $container = $this->createMock('Symfony\Component\DependencyInjection\ContainerInterface');

        $container->expects($this->any())->method('get')->will($this->onConsecutiveCalls(
            $admin_group1, $admin_group2, $admin_group3
        ));

        $pool = new Pool($container, 'Sonata Admin', '/path/to/pic.png');
        $pool->setAdminServiceIds(array('sonata.user.admin.group1', 'sonata.user.admin.group2', 'sonata.user.admin.group3'));

        $pool->setAdminGroups(array(
            'adminGroup1' => array(
                'items' => array('itemKey' => $this->getItemArray('sonata.user.admin.group1')),
            ),
            'adminGroup2' => array(
                'items' => array('itemKey' => $this->getItemArray('sonata.user.admin.group2')),
            ),
            'adminGroup3' => array(
                'items' => array('itemKey' => $this->getItemArray('sonata.user.admin.group3')),
            ),
        ));

        $groups = $pool->getDashboardGroups();

        $this->assertCount(1, $groups);
        $this->assertSame($admin_group1, $groups['adminGroup1']['items']['itemKey']);
    }

    /**
     * @expectedException \InvalidArgumentException
     */
    public function testGetAdminsByGroupWhenGroupNotSet()
    {
        $this->pool->setAdminGroups(array(
                'adminGroup1' => array(),
            ));

        $this->pool->getAdminsByGroup('adminGroup2');
    }

    public function testGetAdminsByGroupWhenGroupIsEmpty()
    {
        $this->pool->setAdminGroups(array(
                'adminGroup1' => array(),
            ));

        $this->assertSame(array(), $this->pool->getAdminsByGroup('adminGroup1'));
    }

    public function testGetAdminsByGroup()
    {
        $this->pool->setAdminServiceIds(array('sonata.admin1', 'sonata.admin2', 'sonata.admin3'));
        $this->pool->setAdminGroups(array(
            'adminGroup1' => array(
                'items' => array(
                    $this->getItemArray('sonata.admin1'),
                    $this->getItemArray('sonata.admin2'),
                ),
            ),
            'adminGroup2' => array(
                'items' => array($this->getItemArray('sonata.admin3')),
            ),
        ));

        $this->assertEquals(array(
            'sonata_admin1_AdminClass',
            'sonata_admin2_AdminClass',
        ), $this->pool->getAdminsByGroup('adminGroup1'));
        $this->assertEquals(array('sonata_admin3_AdminClass'), $this->pool->getAdminsByGroup('adminGroup2'));
    }

    public function testGetAdminForClassWhenAdminClassIsNotSet()
    {
        $this->pool->setAdminClasses(array('someclass' => 'sonata.user.admin.group1'));
        $this->assertFalse($this->pool->hasAdminByClass('notexists'));
        $this->assertNull($this->pool->getAdminByClass('notexists'));
    }

    /**
     * @expectedException \RuntimeException
     */
    public function testGetAdminForClassWithInvalidFormat()
    {
        $this->pool->setAdminClasses(array('someclass' => 'sonata.user.admin.group1'));
        $this->assertTrue($this->pool->hasAdminByClass('someclass'));

        $this->pool->getAdminByClass('someclass');
    }

    /**
     * @expectedException \RuntimeException
     */
    public function testGetAdminForClassWithTooManyRegisteredAdmin()
    {
        $this->pool->setAdminClasses(array(
            'someclass' => array('sonata.user.admin.group1', 'sonata.user.admin.group2'),
        ));

        $this->assertTrue($this->pool->hasAdminByClass('someclass'));
        $this->pool->getAdminByClass('someclass');
    }

    public function testGetAdminForClassWhenAdminClassIsSet()
    {
        $this->pool->setAdminServiceIds(array('sonata.user.admin.group1'));
        $this->pool->setAdminClasses(array(
            'someclass' => array('sonata.user.admin.group1'),
        ));

        $this->assertTrue($this->pool->hasAdminByClass('someclass'));
        $this->assertSame('sonata_user_admin_group1_AdminClass', $this->pool->getAdminByClass('someclass'));
    }

    /**
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage Admin service "sonata.news.admin.post" not found in admin pool.
     */
    public function testGetInstanceWithUndefinedServiceId()
    {
        $this->pool->getInstance('sonata.news.admin.post');
    }

    public function testGetAdminByAdminCode()
    {
        $this->pool->setAdminServiceIds(array('sonata.news.admin.post'));

        $this->assertSame('sonata_news_admin_post_AdminClass', $this->pool->getAdminByAdminCode('sonata.news.admin.post'));
    }

    public function testGetAdminByAdminCodeForChildClass()
    {
        $adminMock = $this->getMockBuilder('Sonata\AdminBundle\Admin\AdminInterface')
            ->disableOriginalConstructor()
            ->getMock();
        $adminMock->expects($this->any())
            ->method('hasChild')
            ->will($this->returnValue(true));
        $adminMock->expects($this->once())
            ->method('getChild')
            ->with($this->equalTo('sonata.news.admin.comment'))
            ->will($this->returnValue('commentAdminClass'));

        $containerMock = $this->createMock('Symfony\Component\DependencyInjection\ContainerInterface');
        $containerMock->expects($this->any())
            ->method('get')
            ->will($this->returnValue($adminMock));

        $this->pool = new Pool($containerMock, 'Sonata', '/path/to/logo.png');
        $this->pool->setAdminServiceIds(array('sonata.news.admin.post'));

        $this->assertSame('commentAdminClass', $this->pool->getAdminByAdminCode('sonata.news.admin.post|sonata.news.admin.comment'));
    }

    public function testGetAdminByAdminCodeForChildInvalidClass()
    {
        $adminMock = $this->getMockBuilder('Sonata\AdminBundle\Admin\AdminInterface')
            ->disableOriginalConstructor()
            ->getMock();
        $adminMock->expects($this->any())
            ->method('hasChild')
            ->will($this->returnValue(false));

        $containerMock = $this->createMock('Symfony\Component\DependencyInjection\ContainerInterface');
        $containerMock->expects($this->any())
            ->method('get')
            ->will($this->returnValue($adminMock));

        $this->pool = new Pool($containerMock, 'Sonata', '/path/to/logo.png');
        $this->pool->setAdminServiceIds(array('sonata.news.admin.post'));

        $this->assertSame(false, $this->pool->getAdminByAdminCode('sonata.news.admin.post|sonata.news.admin.invalid'));
    }

    public function testGetAdminClasses()
    {
        $this->pool->setAdminClasses(array('someclass' => 'sonata.user.admin.group1'));
        $this->assertSame(array('someclass' => 'sonata.user.admin.group1'), $this->pool->getAdminClasses());
    }

    public function testGetAdminGroups()
    {
        $this->pool->setAdminGroups(array('adminGroup1' => 'sonata.user.admin.group1'));
        $this->assertSame(array('adminGroup1' => 'sonata.user.admin.group1'), $this->pool->getAdminGroups());
    }

    public function testGetAdminServiceIds()
    {
        $this->pool->setAdminServiceIds(array('sonata.user.admin.group1', 'sonata.user.admin.group2', 'sonata.user.admin.group3'));
        $this->assertSame(array('sonata.user.admin.group1', 'sonata.user.admin.group2', 'sonata.user.admin.group3'), $this->pool->getAdminServiceIds());
    }

    public function testGetContainer()
    {
        $this->assertInstanceOf('Symfony\Component\DependencyInjection\ContainerInterface', $this->pool->getContainer());
    }

    public function testTemplates()
    {
        $this->assertInternalType('array', $this->pool->getTemplates());

        $this->pool->setTemplates(array('ajax' => 'Foo.html.twig'));

        $this->assertNull($this->pool->getTemplate('bar'));
        $this->assertSame('Foo.html.twig', $this->pool->getTemplate('ajax'));
    }

    public function testGetTitleLogo()
    {
        $this->assertSame('/path/to/pic.png', $this->pool->getTitleLogo());
    }

    public function testGetTitle()
    {
        $this->assertSame('Sonata Admin', $this->pool->getTitle());
    }

    public function testGetOption()
    {
        $this->assertSame('bar', $this->pool->getOption('foo'));

        $this->assertSame(null, $this->pool->getOption('non_existent_option'));
    }

    public function testOptionDefault()
    {
        $this->assertSame(array(), $this->pool->getOption('nonexistantarray', array()));
    }

    /**
     * @return Symfony\Component\DependencyInjection\ContainerInterface - the mock of container interface
     */
    private function getContainer()
    {
        $containerMock = $this->createMock('Symfony\Component\DependencyInjection\ContainerInterface');
        $containerMock->expects($this->any())
            ->method('get')
            ->will($this->returnCallback(function ($serviceId) {
                return str_replace('.', '_', $serviceId).'_AdminClass';
            }));

        return $containerMock;
    }

    private function getItemArray($serviceId)
    {
        return array(
            'admin' => $serviceId,
            'label' => '',
            'route' => '',
            'route_params' => array(),
        );
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\AdminBundle\Tests\Admin;
13
14			use Sonata\AdminBundle\Admin\Pool;
15			use Sonata\AdminBundle\Tests\Helpers\PHPUnit_Framework_TestCase;
16
17			class PoolTest extends PHPUnit_Framework_TestCase
18			{
19			/**
20			* @var Pool
21			*/
22			private $pool = null;
23
24			public function setUp()
25			{
26			$this->pool = new Pool($this->getContainer(), 'Sonata Admin', '/path/to/pic.png', array('foo' => 'bar'));
27			}
28
29			public function testGetGroups()
30			{
31			$this->pool->setAdminServiceIds(array('sonata.user.admin.group1'));
32
33			$this->pool->setAdminGroups(array(
34			'adminGroup1' => array('sonata.user.admin.group1' => array()),
35			));
36
37			$expectedOutput = array(
38			'adminGroup1' => array(
39			'sonata.user.admin.group1' => 'sonata_user_admin_group1_AdminClass',
40			),
41			);
42
43			$this->assertSame($expectedOutput, $this->pool->getGroups());
44			}
45
46			public function testHasGroup()
47			{
48			$this->pool->setAdminGroups(array(
49			'adminGroup1' => array(),
50			));
51
52			$this->assertTrue($this->pool->hasGroup('adminGroup1'));
53			$this->assertFalse($this->pool->hasGroup('adminGroup2'));
54			}
55
56			public function testGetDashboardGroups()
57			{
58			$admin_group1 = $this->createMock('Sonata\AdminBundle\Admin\AdminInterface');
59			$admin_group1->expects($this->once())->method('showIn')->will($this->returnValue(true));
60
61			$admin_group2 = $this->createMock('Sonata\AdminBundle\Admin\AdminInterface');
62			$admin_group2->expects($this->once())->method('showIn')->will($this->returnValue(false));
63
64			$admin_group3 = $this->createMock('Sonata\AdminBundle\Admin\AdminInterface');
65			$admin_group3->expects($this->once())->method('showIn')->will($this->returnValue(false));
66
67			$container = $this->createMock('Symfony\Component\DependencyInjection\ContainerInterface');
68
69			$container->expects($this->any())->method('get')->will($this->onConsecutiveCalls(
70			$admin_group1, $admin_group2, $admin_group3
71			));
72
73			$pool = new Pool($container, 'Sonata Admin', '/path/to/pic.png');
74			$pool->setAdminServiceIds(array('sonata.user.admin.group1', 'sonata.user.admin.group2', 'sonata.user.admin.group3'));
75
76			$pool->setAdminGroups(array(
77			'adminGroup1' => array(
78			'items' => array('itemKey' => $this->getItemArray('sonata.user.admin.group1')),
79			),
80			'adminGroup2' => array(
81			'items' => array('itemKey' => $this->getItemArray('sonata.user.admin.group2')),
82			),
83			'adminGroup3' => array(
84			'items' => array('itemKey' => $this->getItemArray('sonata.user.admin.group3')),
85			),
86			));
87
88			$groups = $pool->getDashboardGroups();
89
90			$this->assertCount(1, $groups);
91			$this->assertSame($admin_group1, $groups['adminGroup1']['items']['itemKey']);
92			}
93
94			/**
95			* @expectedException \InvalidArgumentException
96			*/
97			public function testGetAdminsByGroupWhenGroupNotSet()
98			{
99			$this->pool->setAdminGroups(array(
100			'adminGroup1' => array(),
101			));
102
103			$this->pool->getAdminsByGroup('adminGroup2');
104			}
105
106			public function testGetAdminsByGroupWhenGroupIsEmpty()
107			{
108			$this->pool->setAdminGroups(array(
109			'adminGroup1' => array(),
110			));
111
112			$this->assertSame(array(), $this->pool->getAdminsByGroup('adminGroup1'));
113			}
114
115			public function testGetAdminsByGroup()
116			{
117			$this->pool->setAdminServiceIds(array('sonata.admin1', 'sonata.admin2', 'sonata.admin3'));
118			$this->pool->setAdminGroups(array(
119			'adminGroup1' => array(
120			'items' => array(
121			$this->getItemArray('sonata.admin1'),
122			$this->getItemArray('sonata.admin2'),
123			),
124			),
125			'adminGroup2' => array(
126			'items' => array($this->getItemArray('sonata.admin3')),
127			),
128			));
129
130			$this->assertEquals(array(
131			'sonata_admin1_AdminClass',
132			'sonata_admin2_AdminClass',
133			), $this->pool->getAdminsByGroup('adminGroup1'));
134			$this->assertEquals(array('sonata_admin3_AdminClass'), $this->pool->getAdminsByGroup('adminGroup2'));
135			}
136
137			public function testGetAdminForClassWhenAdminClassIsNotSet()
138			{
139			$this->pool->setAdminClasses(array('someclass' => 'sonata.user.admin.group1'));
140			$this->assertFalse($this->pool->hasAdminByClass('notexists'));
141			$this->assertNull($this->pool->getAdminByClass('notexists'));
142			}
143
144			/**
145			* @expectedException \RuntimeException
146			*/
147			public function testGetAdminForClassWithInvalidFormat()
148			{
149			$this->pool->setAdminClasses(array('someclass' => 'sonata.user.admin.group1'));
150			$this->assertTrue($this->pool->hasAdminByClass('someclass'));
151
152			$this->pool->getAdminByClass('someclass');
153			}
154
155			/**
156			* @expectedException \RuntimeException
157			*/
158			public function testGetAdminForClassWithTooManyRegisteredAdmin()
159			{
160			$this->pool->setAdminClasses(array(
161			'someclass' => array('sonata.user.admin.group1', 'sonata.user.admin.group2'),
162			));
163
164			$this->assertTrue($this->pool->hasAdminByClass('someclass'));
165			$this->pool->getAdminByClass('someclass');
166			}
167
168			public function testGetAdminForClassWhenAdminClassIsSet()
169			{
170			$this->pool->setAdminServiceIds(array('sonata.user.admin.group1'));
171			$this->pool->setAdminClasses(array(
172			'someclass' => array('sonata.user.admin.group1'),
173			));
174
175			$this->assertTrue($this->pool->hasAdminByClass('someclass'));
176			$this->assertSame('sonata_user_admin_group1_AdminClass', $this->pool->getAdminByClass('someclass'));
177			}
178
179			/**
180			* @expectedException \InvalidArgumentException
181			* @expectedExceptionMessage Admin service "sonata.news.admin.post" not found in admin pool.
182			*/
183			public function testGetInstanceWithUndefinedServiceId()
184			{
185			$this->pool->getInstance('sonata.news.admin.post');
186			}
187
188			public function testGetAdminByAdminCode()
189			{
190			$this->pool->setAdminServiceIds(array('sonata.news.admin.post'));
191
192			$this->assertSame('sonata_news_admin_post_AdminClass', $this->pool->getAdminByAdminCode('sonata.news.admin.post'));
193			}
194
195			public function testGetAdminByAdminCodeForChildClass()
196			{
197			$adminMock = $this->getMockBuilder('Sonata\AdminBundle\Admin\AdminInterface')
198			->disableOriginalConstructor()
199			->getMock();
200			$adminMock->expects($this->any())
201			->method('hasChild')
202			->will($this->returnValue(true));
203			$adminMock->expects($this->once())
204			->method('getChild')
205			->with($this->equalTo('sonata.news.admin.comment'))
206			->will($this->returnValue('commentAdminClass'));
207
208			$containerMock = $this->createMock('Symfony\Component\DependencyInjection\ContainerInterface');
209			$containerMock->expects($this->any())
210			->method('get')
211			->will($this->returnValue($adminMock));
212
213			$this->pool = new Pool($containerMock, 'Sonata', '/path/to/logo.png');
214			$this->pool->setAdminServiceIds(array('sonata.news.admin.post'));
215
216			$this->assertSame('commentAdminClass', $this->pool->getAdminByAdminCode('sonata.news.admin.post\|sonata.news.admin.comment'));
217			}
218
219			public function testGetAdminByAdminCodeForChildInvalidClass()
220			{
221			$adminMock = $this->getMockBuilder('Sonata\AdminBundle\Admin\AdminInterface')
222			->disableOriginalConstructor()
223			->getMock();
224			$adminMock->expects($this->any())
225			->method('hasChild')
226			->will($this->returnValue(false));
227
228			$containerMock = $this->createMock('Symfony\Component\DependencyInjection\ContainerInterface');
229			$containerMock->expects($this->any())
230			->method('get')
231			->will($this->returnValue($adminMock));
232
233			$this->pool = new Pool($containerMock, 'Sonata', '/path/to/logo.png');
234			$this->pool->setAdminServiceIds(array('sonata.news.admin.post'));
235
236			$this->assertSame(false, $this->pool->getAdminByAdminCode('sonata.news.admin.post\|sonata.news.admin.invalid'));
237			}
238
239			public function testGetAdminClasses()
240			{
241			$this->pool->setAdminClasses(array('someclass' => 'sonata.user.admin.group1'));
242			$this->assertSame(array('someclass' => 'sonata.user.admin.group1'), $this->pool->getAdminClasses());
243			}
244
245			public function testGetAdminGroups()
246			{
247			$this->pool->setAdminGroups(array('adminGroup1' => 'sonata.user.admin.group1'));
248			$this->assertSame(array('adminGroup1' => 'sonata.user.admin.group1'), $this->pool->getAdminGroups());
249			}
250
251			public function testGetAdminServiceIds()
252			{
253			$this->pool->setAdminServiceIds(array('sonata.user.admin.group1', 'sonata.user.admin.group2', 'sonata.user.admin.group3'));
254			$this->assertSame(array('sonata.user.admin.group1', 'sonata.user.admin.group2', 'sonata.user.admin.group3'), $this->pool->getAdminServiceIds());
255			}
256
257			public function testGetContainer()
258			{
259			$this->assertInstanceOf('Symfony\Component\DependencyInjection\ContainerInterface', $this->pool->getContainer());
260			}
261
262			public function testTemplates()
263			{
264			$this->assertInternalType('array', $this->pool->getTemplates());
265
266			$this->pool->setTemplates(array('ajax' => 'Foo.html.twig'));
267
268			$this->assertNull($this->pool->getTemplate('bar'));
269			$this->assertSame('Foo.html.twig', $this->pool->getTemplate('ajax'));
270			}
271
272			public function testGetTitleLogo()
273			{
274			$this->assertSame('/path/to/pic.png', $this->pool->getTitleLogo());
275			}
276
277			public function testGetTitle()
278			{
279			$this->assertSame('Sonata Admin', $this->pool->getTitle());
280			}
281
282			public function testGetOption()
283			{
284			$this->assertSame('bar', $this->pool->getOption('foo'));
285
286			$this->assertSame(null, $this->pool->getOption('non_existent_option'));
287			}
288
289			public function testOptionDefault()
290			{
291			$this->assertSame(array(), $this->pool->getOption('nonexistantarray', array()));
292			}
293
294			/**
295			* @return Symfony\Component\DependencyInjection\ContainerInterface - the mock of container interface
296			*/
297			private function getContainer()
298			{
299			$containerMock = $this->createMock('Symfony\Component\DependencyInjection\ContainerInterface');
300			$containerMock->expects($this->any())
301			->method('get')
302			->will($this->returnCallback(function ($serviceId) {
303			return str_replace('.', '_', $serviceId).'_AdminClass';
304			}));
305
306			return $containerMock;
307			}
308
309			private function getItemArray($serviceId)
310			{
311			return array(
312			'admin' => $serviceId,
313			'label' => '',
314			'route' => '',
315			'route_params' => array(),
316			);
317			}
318			}
319

sonata-project / SonataAdminBundle

Push — 3.x ( f7534c...26d69b )

PoolTest::testGetInstanceWithUndefinedServiceId() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like