Completed
Pull Request — master (#5836)
by Oskar
05:50 queued 02:54
created
tests/Controller/HelperControllerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -298,6 +298,9 @@
 block discarded – undo
298 298
         $formConfig->getAttribute('target_admin_access_action')->willReturn('list');
299 299
     }
300 300
 
301
+    /**
302
+     * @param string $field
303
+     */
301 304
     private function configureFormConfigComplexPropertyArray($field): void
302 305
     {
303 306
         $form = $this->prophesize(Form::class);
Please login to merge, or discard this patch.
tests/Twig/Extension/SonataAdminExtensionTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -2486,6 +2486,9 @@
 block discarded – undo
2486 2486
         return htmlspecialchars(http_build_query($url, '', '&', PHP_QUERY_RFC3986));
2487 2487
     }
2488 2488
 
2489
+    /**
2490
+     * @param string $privateMethod
2491
+     */
2489 2492
     private function getMethodAsPublic($privateMethod): \ReflectionMethod
2490 2493
     {
2491 2494
         $reflection = new \ReflectionMethod('Sonata\AdminBundle\Twig\Extension\SonataAdminExtension', $privateMethod);
Please login to merge, or discard this patch.
src/Admin/BaseFieldDescription.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -441,6 +441,9 @@
 block discarded – undo
441 441
         return $object->{$fieldName};
442 442
     }
443 443
 
444
+    /**
445
+     * @param string $fieldName
446
+     */
444 447
     private function cacheFieldGetter($object, ?string $fieldName, string $method, ?string $getter = null): void
445 448
     {
446 449
         $getterKey = $this->getFieldGetterKey($object, $fieldName);
Please login to merge, or discard this patch.
tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -292,6 +292,10 @@
 block discarded – undo
292 292
         $this->assertTrue($this->datagridMapper->has('baz'));
293 293
     }
294 294
 
295
+    /**
296
+     * @param string $name
297
+     * @param string $label
298
+     */
295 299
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
296 300
     {
297 301
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -286,6 +286,10 @@
 block discarded – undo
286 286
         $this->assertTrue($this->listMapper->has('baz'));
287 287
     }
288 288
 
289
+    /**
290
+     * @param string $name
291
+     * @param string $label
292
+     */
289 293
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
290 294
     {
291 295
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -501,6 +501,10 @@
 block discarded – undo
501 501
         $this->admin->setLabelTranslatorStrategy(new NoopLabelTranslatorStrategy());
502 502
     }
503 503
 
504
+    /**
505
+     * @param string $name
506
+     * @param string $label
507
+     */
504 508
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
505 509
     {
506 510
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Twig/Extension/SonataAdminExtension.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
     /**
165 165
      * render a list element from the FieldDescription.
166 166
      *
167
-     * @param object $object
167
+     * @param \stdClass $object
168 168
      * @param array  $params
169 169
      *
170 170
      * @return string
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
     /**
246 246
      * render a view element.
247 247
      *
248
-     * @param object $object
248
+     * @param \stdClass $object
249 249
      *
250 250
      * @return string
251 251
      */
@@ -382,7 +382,7 @@  discard block
 block discarded – undo
382 382
     /**
383 383
      * Get the identifiers as a string that is safe to use in a url.
384 384
      *
385
-     * @param object $model
385
+     * @param \stdClass $model
386 386
      *
387 387
      * @return string string representation of the id that is safe to use in a url
388 388
      */
@@ -404,7 +404,7 @@  discard block
 block discarded – undo
404 404
     }
405 405
 
406 406
     /**
407
-     * @return string|bool
407
+     * @return string|false
408 408
      */
409 409
     public function getXEditableType($type)
410 410
     {
Please login to merge, or discard this patch.
src/Security/Handler/SecurityHandlerInterface.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 interface SecurityHandlerInterface
22 22
 {
23 23
     /**
24
-     * @param string|array $attributes
24
+     * @param string $attributes
25 25
      * @param mixed|null   $object
26 26
      *
27 27
      * @return bool
@@ -44,6 +44,7 @@  discard block
 block discarded – undo
44 44
      * Create object security, fe. make the current user owner of the object.
45 45
      *
46 46
      * @param object $object
47
+     * @return void
47 48
      */
48 49
     public function createObjectSecurity(AdminInterface $admin, $object);
49 50
 
@@ -51,6 +52,7 @@  discard block
 block discarded – undo
51 52
      * Remove object security.
52 53
      *
53 54
      * @param object $object
55
+     * @return void
54 56
      */
55 57
     public function deleteObjectSecurity(AdminInterface $admin, $object);
56 58
 }
Please login to merge, or discard this patch.
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -949,6 +949,7 @@  discard block
 block discarded – undo
949 949
 
950 950
     /**
951 951
      * NEXT_MAJOR: remove this method.
952
+     * @param string $subClass
952 953
      */
953 954
     public function addSubClass($subClass): void
954 955
     {
@@ -1104,6 +1105,9 @@  discard block
 block discarded – undo
1104 1105
         return $this->routeGenerator->hasAdminRoute($this, $name);
1105 1106
     }
1106 1107
 
1108
+    /**
1109
+     * @param string $adminCode
1110
+     */
1107 1111
     public function isCurrentRoute(string $name, ?string $adminCode = null): bool
1108 1112
     {
1109 1113
         if (!$this->hasRequest()) {
@@ -2127,7 +2131,7 @@  discard block
 block discarded – undo
2127 2131
      *
2128 2132
      * @param string $context
2129 2133
      *
2130
-     * @return array
2134
+     * @return string[]
2131 2135
      */
2132 2136
     public function getPermissionsShow($context)
2133 2137
     {
@@ -2532,6 +2536,7 @@  discard block
 block discarded – undo
2532 2536
 
2533 2537
     /**
2534 2538
      * {@inheritdoc}
2539
+     * @param boolean $isShown
2535 2540
      */
2536 2541
     final public function showMosaicButton($isShown): void
2537 2542
     {
@@ -2663,6 +2668,7 @@  discard block
 block discarded – undo
2663 2668
      * NEXT_MAJOR: remove this method.
2664 2669
      *
2665 2670
      * @deprecated Use configureTabMenu instead
2671
+     * @param string $action
2666 2672
      */
2667 2673
     protected function configureSideMenu(MenuItemInterface $menu, $action, AdminInterface $childAdmin = null)
2668 2674
     {
Please login to merge, or discard this patch.