Conditions | 14 |
Paths | 1280 |
Total Lines | 191 |
Code Lines | 132 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
115 | public function load(array $configs, ContainerBuilder $container): void |
||
116 | { |
||
117 | $bundles = $container->getParameter('kernel.bundles'); |
||
118 | |||
119 | if (isset($bundles['SonataUserBundle'])) { |
||
120 | // integrate the SonataUserBundle / FOSUserBundle if the bundle exists |
||
121 | array_unshift($configs, [ |
||
122 | 'templates' => [ |
||
123 | 'user_block' => 'SonataUserBundle:Admin/Core:user_block.html.twig', |
||
124 | ], |
||
125 | ]); |
||
126 | } |
||
127 | |||
128 | if (isset($bundles['SonataIntlBundle'])) { |
||
129 | // integrate the SonataUserBundle if the bundle exists |
||
130 | array_unshift($configs, [ |
||
131 | 'templates' => [ |
||
132 | 'history_revision_timestamp' => 'SonataIntlBundle:CRUD:history_revision_timestamp.html.twig', |
||
133 | ], |
||
134 | ]); |
||
135 | } |
||
136 | |||
137 | $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config')); |
||
138 | $loader->load('twig.xml'); |
||
139 | $loader->load('core.xml'); |
||
140 | $loader->load('form_types.xml'); |
||
141 | $loader->load('validator.xml'); |
||
142 | $loader->load('route.xml'); |
||
143 | $loader->load('block.xml'); |
||
144 | $loader->load('menu.xml'); |
||
145 | $loader->load('commands.xml'); |
||
146 | |||
147 | if (isset($bundles['SonataExporterBundle'])) { |
||
148 | $loader->load('exporter.xml'); |
||
149 | } |
||
150 | |||
151 | $container->getDefinition('sonata.admin.exporter')->setDeprecated( |
||
152 | 'The service "%service_id%" is deprecated in favor of the "sonata.exporter.exporter" service' |
||
153 | ); |
||
154 | |||
155 | $configuration = $this->getConfiguration($configs, $container); |
||
156 | $config = $this->processConfiguration($configuration, $configs); |
||
157 | |||
158 | $config['options']['javascripts'] = $this->buildJavascripts($config); |
||
159 | $config['options']['stylesheets'] = $this->buildStylesheets($config); |
||
160 | $config['options']['role_admin'] = $config['security']['role_admin']; |
||
161 | $config['options']['role_super_admin'] = $config['security']['role_super_admin']; |
||
162 | |||
163 | $pool = $container->getDefinition('sonata.admin.pool'); |
||
164 | $pool->replaceArgument(1, $config['title']); |
||
165 | $pool->replaceArgument(2, $config['title_logo']); |
||
166 | $pool->replaceArgument(3, $config['options']); |
||
167 | |||
168 | if (false === $config['options']['lock_protection']) { |
||
169 | $container->removeDefinition('sonata.admin.lock.extension'); |
||
170 | } |
||
171 | |||
172 | $container->setParameter('sonata.admin.configuration.global_search.empty_boxes', $config['global_search']['empty_boxes']); |
||
173 | $container->setParameter('sonata.admin.configuration.templates', $config['templates'] + [ |
||
174 | 'user_block' => 'SonataAdminBundle:Core:user_block.html.twig', |
||
175 | 'add_block' => 'SonataAdminBundle:Core:add_block.html.twig', |
||
176 | 'layout' => 'SonataAdminBundle::standard_layout.html.twig', |
||
177 | 'ajax' => 'SonataAdminBundle::ajax_layout.html.twig', |
||
178 | 'dashboard' => 'SonataAdminBundle:Core:dashboard.html.twig', |
||
179 | 'list' => 'SonataAdminBundle:CRUD:list.html.twig', |
||
180 | 'filter' => 'SonataAdminBundle:Form:filter_admin_fields.html.twig', |
||
181 | 'show' => 'SonataAdminBundle:CRUD:show.html.twig', |
||
182 | 'show_compare' => 'SonataAdminBundle:CRUD:show_compare.html.twig', |
||
183 | 'edit' => 'SonataAdminBundle:CRUD:edit.html.twig', |
||
184 | 'history' => 'SonataAdminBundle:CRUD:history.html.twig', |
||
185 | 'history_revision_timestamp' => 'SonataAdminBundle:CRUD:history_revision_timestamp.html.twig', |
||
186 | 'acl' => 'SonataAdminBundle:CRUD:acl.html.twig', |
||
187 | 'action' => 'SonataAdminBundle:CRUD:action.html.twig', |
||
188 | 'short_object_description' => 'SonataAdminBundle:Helper:short-object-description.html.twig', |
||
189 | 'preview' => 'SonataAdminBundle:CRUD:preview.html.twig', |
||
190 | 'list_block' => 'SonataAdminBundle:Block:block_admin_list.html.twig', |
||
191 | 'delete' => 'SonataAdminBundle:CRUD:delete.html.twig', |
||
192 | 'batch' => 'SonataAdminBundle:CRUD:list__batch.html.twig', |
||
193 | 'select' => 'SonataAdminBundle:CRUD:list__select.html.twig', |
||
194 | 'batch_confirmation' => 'SonataAdminBundle:CRUD:batch_confirmation.html.twig', |
||
195 | 'inner_list_row' => 'SonataAdminBundle:CRUD:list_inner_row.html.twig', |
||
196 | 'base_list_field' => 'SonataAdminBundle:CRUD:base_list_field.html.twig', |
||
197 | 'pager_links' => 'SonataAdminBundle:Pager:links.html.twig', |
||
198 | 'pager_results' => 'SonataAdminBundle:Pager:results.html.twig', |
||
199 | 'tab_menu_template' => 'SonataAdminBundle:Core:tab_menu_template.html.twig', |
||
200 | 'knp_menu_template' => 'SonataAdminBundle:Menu:sonata_menu.html.twig', |
||
201 | 'outer_list_rows_mosaic' => 'SonataAdminBundle:CRUD:list_outer_rows_mosaic.html.twig', |
||
202 | 'outer_list_rows_list' => 'SonataAdminBundle:CRUD:list_outer_rows_list.html.twig', |
||
203 | 'outer_list_rows_tree' => 'SonataAdminBundle:CRUD:list_outer_rows_tree.html.twig', |
||
204 | ]); |
||
205 | $container->setParameter('sonata.admin.configuration.admin_services', $config['admin_services']); |
||
206 | $container->setParameter('sonata.admin.configuration.dashboard_groups', $config['dashboard']['groups']); |
||
207 | $container->setParameter('sonata.admin.configuration.dashboard_blocks', $config['dashboard']['blocks']); |
||
208 | $container->setParameter('sonata.admin.configuration.sort_admins', $config['options']['sort_admins']); |
||
209 | $container->setParameter('sonata.admin.configuration.breadcrumbs', $config['breadcrumbs']); |
||
210 | |||
211 | if (null === $config['security']['acl_user_manager'] && isset($bundles['FOSUserBundle'])) { |
||
212 | $container->setParameter('sonata.admin.security.acl_user_manager', 'fos_user.user_manager'); |
||
213 | } else { |
||
214 | $container->setParameter('sonata.admin.security.acl_user_manager', $config['security']['acl_user_manager']); |
||
215 | } |
||
216 | |||
217 | $container->setAlias('sonata.admin.security.handler', $config['security']['handler']); |
||
218 | |||
219 | switch ($config['security']['handler']) { |
||
220 | case 'sonata.admin.security.handler.role': |
||
221 | if (0 === count($config['security']['information'])) { |
||
222 | $config['security']['information'] = [ |
||
223 | 'EDIT' => ['EDIT'], |
||
224 | 'LIST' => ['LIST'], |
||
225 | 'CREATE' => ['CREATE'], |
||
226 | 'VIEW' => ['VIEW'], |
||
227 | 'DELETE' => ['DELETE'], |
||
228 | 'EXPORT' => ['EXPORT'], |
||
229 | 'ALL' => ['ALL'], |
||
230 | ]; |
||
231 | } |
||
232 | |||
233 | break; |
||
234 | case 'sonata.admin.security.handler.acl': |
||
235 | if (0 === count($config['security']['information'])) { |
||
236 | $config['security']['information'] = [ |
||
237 | 'GUEST' => ['VIEW', 'LIST'], |
||
238 | 'STAFF' => ['EDIT', 'LIST', 'CREATE'], |
||
239 | 'EDITOR' => ['OPERATOR', 'EXPORT'], |
||
240 | 'ADMIN' => ['MASTER'], |
||
241 | ]; |
||
242 | } |
||
243 | |||
244 | break; |
||
245 | } |
||
246 | |||
247 | $container->setParameter('sonata.admin.configuration.security.role_admin', $config['security']['role_admin']); |
||
248 | $container->setParameter('sonata.admin.configuration.security.role_super_admin', $config['security']['role_super_admin']); |
||
249 | $container->setParameter('sonata.admin.configuration.security.information', $config['security']['information']); |
||
250 | $container->setParameter('sonata.admin.configuration.security.admin_permissions', $config['security']['admin_permissions']); |
||
251 | $container->setParameter('sonata.admin.configuration.security.object_permissions', $config['security']['object_permissions']); |
||
252 | |||
253 | $loader->load('security.xml'); |
||
254 | |||
255 | $container->setParameter('sonata.admin.extension.map', $config['extensions']); |
||
256 | |||
257 | /* |
||
258 | * This is a work in progress, so for now it is hardcoded |
||
259 | */ |
||
260 | $classes = [ |
||
261 | 'email' => '', |
||
262 | 'textarea' => '', |
||
263 | 'text' => '', |
||
264 | 'choice' => '', |
||
265 | 'integer' => '', |
||
266 | 'datetime' => 'sonata-medium-date', |
||
267 | 'date' => 'sonata-medium-date', |
||
268 | |||
269 | // SF3+ |
||
270 | SymfonyChoiceType::class => '', |
||
271 | SymfonyDateType::class => 'sonata-medium-date', |
||
272 | SymfonyDateTimeType::class => 'sonata-medium-date', |
||
273 | SymfonyEmailType::class => '', |
||
274 | SymfonyIntegerType::class => '', |
||
275 | SymfonyTextareaType::class => '', |
||
276 | SymfonyTextType::class => '', |
||
277 | ]; |
||
278 | |||
279 | $container->getDefinition('sonata.admin.form.extension.field') |
||
280 | ->replaceArgument(0, $classes) |
||
281 | ->replaceArgument(1, $config['options']); |
||
282 | |||
283 | // remove non used service |
||
284 | if (!isset($bundles['JMSTranslationBundle'])) { |
||
285 | $container->removeDefinition('sonata.admin.translator.extractor.jms_translator_bundle'); |
||
286 | } |
||
287 | |||
288 | //remove non-Mopa compatibility layer |
||
289 | if (isset($bundles['MopaBootstrapBundle'])) { |
||
290 | $container->removeDefinition('sonata.admin.form.extension.field.mopa'); |
||
291 | } |
||
292 | |||
293 | // set filter persistence |
||
294 | $container->setParameter('sonata.admin.configuration.filters.persist', $config['persist_filters']); |
||
295 | |||
296 | $container->setParameter('sonata.admin.configuration.show.mosaic.button', $config['show_mosaic_button']); |
||
297 | |||
298 | $container->setParameter('sonata.admin.configuration.translate_group_label', $config['translate_group_label']); |
||
299 | |||
300 | if (\PHP_VERSION_ID < 70000) { |
||
301 | $this->configureClassesToCompile(); |
||
302 | } |
||
303 | |||
304 | $this->replacePropertyAccessor($container); |
||
305 | } |
||
306 | |||
501 |
Let’s assume that you have a directory layout like this:
and let’s assume the following content of
Bar.php
:If both files
OtherDir/Foo.php
andSomeDir/Foo.php
are loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as
OtherDir/Foo.php
does not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php
, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: