sonata-project / SonataAdminBundle

tests/Datagrid/ListMapperTest.php

Doc Comments +4 added lines

@@ -286,6 +286,10 @@
         $this->assertTrue($this->listMapper->has('baz'));
     }
 
+    /**
+     * @param string $name
+     * @param string $label
+     */
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
     {
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);

tests/Show/ShowMapperTest.php

Doc Comments +4 added lines

@@ -501,6 +501,10 @@
         $this->admin->setLabelTranslatorStrategy(new NoopLabelTranslatorStrategy());
     }
 
+    /**
+     * @param string $name
+     * @param string $label
+     */
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
     {
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);

tests/Datagrid/PagerTest.php

Doc Comments +3 added lines

@@ -647,6 +647,9 @@
         $this->assertNull($this->pager->getQuery());
     }
 
+    /**
+     * @param Pager $obj
+     */
     protected function callMethod($obj, string $name, array $args = [])
     {
         $class = new \ReflectionClass($obj);

src/Command/QuestionableCommand.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 {
     /**
      * @param string   $questionText
-     * @param mixed    $default
+     * @param string    $default
      * @param callable $validator
      *
      * @return mixed

tests/Form/Widget/FormSonataFilterChoiceWidgetTest.php

Doc Comments +3 added lines

@@ -56,6 +56,9 @@
         );
     }
 
+    /**
+     * @return string
+     */
     protected function getChoiceClass()
     {
         return ChoiceType::class;

src/Twig/Extension/SonataAdminExtension.php

Doc Comments +3 added lines, -3 removed lines

@@ -182,7 +182,7 @@ 
     /**
      * render a view element.
      *
-     * @param object $object
+     * @param \stdClass $object
      *
      * @return string
      */
@@ -319,7 +319,7 @@ 
     /**
      * Get the identifiers as a string that is safe to use in a url.
      *
-     * @param object $model
+     * @param \stdClass $model
      *
      * @return string string representation of the id that is safe to use in a url
      */
@@ -341,7 +341,7 @@ 
     }
 
     /**
-     * @return string|bool
+     * @return string|false
      */
     public function getXEditableType($type)
     {

src/Controller/CRUDController.php

Doc Comments +2 added lines, -2 removed lines

@@ -743,8 +743,8 @@
     /**
      * Compare history revisions of object.
      *
-     * @param int|string|null $baseRevision
-     * @param int|string|null $compareRevision
+     * @param null|integer $baseRevision
+     * @param null|integer $compareRevision
      *
      * @throws AccessDeniedException If access is not granted
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available

src/Model/ModelManagerInterface.php

Doc Comments +13 added lines, -1 removed lines

@@ -37,6 +37,7 @@ 
      * @param object $object
      *
      * @throws ModelManagerException
+     * @return void
      */
     public function create(object $object);
 
@@ -44,6 +45,7 @@ 
      * @param object $object
      *
      * @throws ModelManagerException
+     * @return void
      */
     public function update(object $object);
 
@@ -51,6 +53,7 @@ 
      * @param object $object
      *
      * @throws ModelManagerException
+     * @return void
      */
     public function delete(object $object);
 
@@ -72,7 +75,7 @@ 
      * @param string $class
      * @param mixed  $id
      *
-     * @return object|null the object with id or null if not found
+     * @return \Sonata\AdminBundle\Tests\App\Model\Foo|null the object with id or null if not found
      */
     public function find(string $class, $id): ?object;
 
@@ -80,12 +83,14 @@ 
      * @param string $class
      *
      * @throws ModelManagerException
+     * @return void
      */
     public function batchDelete(string $class, ProxyQueryInterface $queryProxy);
 
     /**
      * @param array  $parentAssociationMapping
      * @param string $class
+     * @return void
      */
     public function getParentFieldDescription(array $parentAssociationMapping, string $class);
 
@@ -172,6 +177,7 @@ 
      *
      * @param array  $collection
      * @param object $element
+     * @return void
      */
     public function collectionRemoveElement(array &$collection, object &$element);
 
@@ -180,6 +186,7 @@ 
      *
      * @param array  $collection
      * @param object $element
+     * @return void
      */
     public function collectionAddElement(array &$collection, object &$element);
 
@@ -197,6 +204,7 @@ 
      * Clear the collection.
      *
      * @param array $collection
+     * @return void
      */
     public function collectionClear(array &$collection);
 
@@ -216,17 +224,20 @@ 
 
     /**
      * @param string $class
+     * @return void
      */
     public function modelReverseTransform(string $class, array $array = []);
 
     /**
      * @param string $class
      * @param object $instance
+     * @return void
      */
     public function modelTransform(string $class, object $instance);
 
     /**
      * @param mixed $query
+     * @return void
      */
     public function executeQuery($query);
 
@@ -259,6 +270,7 @@ 
 
     /**
      * @param string $class
+     * @return void
      */
     public function addIdentifiersToQuery(string $class, ProxyQueryInterface $query, array $idx);
 }

src/Security/Handler/SecurityHandlerInterface.php

Doc Comments +3 added lines, -1 removed lines

@@ -21,7 +21,7 @@ 
 interface SecurityHandlerInterface
 {
     /**
-     * @param string|array $attributes
+     * @param string $attributes
      * @param mixed|null   $object
      *
      * @return bool
@@ -44,6 +44,7 @@ 
      * Create object security, fe. make the current user owner of the object.
      *
      * @param object $object
+     * @return void
      */
     public function createObjectSecurity(AdminInterface $admin, object $object);
 
@@ -51,6 +52,7 @@ 
      * Remove object security.
      *
      * @param object $object
+     * @return void
      */
     public function deleteObjectSecurity(AdminInterface $admin, object $object);
 }