Completed
Pull Request — 3.x (#4825)
by Grégoire
03:52
created
src/Controller/PolyfillControllerTrait.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -25,6 +25,9 @@
 block discarded – undo
25 25
  */
26 26
 trait PolyfillControllerTrait
27 27
 {
28
+    /**
29
+     * @param string $methodName
30
+     */
28 31
     public function __call($methodName, $arguments)
29 32
     {
30 33
         $this->proxyToController($methodName, $arguments);
Please login to merge, or discard this patch.
src/Twig/GlobalVariables.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     /**
68 68
      * @param string $code
69 69
      * @param string $action
70
-     * @param array  $parameters
70
+     * @param string[]  $parameters
71 71
      * @param int    $absolute
72 72
      *
73 73
      * @return string
@@ -82,8 +82,8 @@  discard block
 block discarded – undo
82 82
     /**
83 83
      * @param string $code
84 84
      * @param string $action
85
-     * @param mixed  $object
86
-     * @param array  $parameters
85
+     * @param string  $object
86
+     * @param string[]  $parameters
87 87
      * @param int    $absolute
88 88
      *
89 89
      * @return string
@@ -96,8 +96,8 @@  discard block
 block discarded – undo
96 96
     }
97 97
 
98 98
     /**
99
-     * @param $code
100
-     * @param $action
99
+     * @param string $code
100
+     * @param string $action
101 101
      *
102 102
      * @return array
103 103
      */
Please login to merge, or discard this patch.
tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -266,6 +266,12 @@
 block discarded – undo
266 266
         ], array_keys($this->datagrid->getFilters()));
267 267
     }
268 268
 
269
+    /**
270
+     * @param string $name
271
+     * @param string $label
272
+     *
273
+     * @return string
274
+     */
269 275
     private function getFieldDescriptionMock($name = null, $label = null)
270 276
     {
271 277
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -255,6 +255,12 @@
 block discarded – undo
255 255
         ], true), print_r($this->fieldDescriptionCollection->getElements(), true));
256 256
     }
257 257
 
258
+    /**
259
+     * @param string $name
260
+     * @param string $label
261
+     *
262
+     * @return string
263
+     */
258 264
     private function getFieldDescriptionMock($name = null, $label = null)
259 265
     {
260 266
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -455,6 +455,10 @@
 block discarded – undo
455 455
         $this->showMapper = new ShowMapper($this->showBuilder, $this->fieldDescriptionCollection, $this->admin);
456 456
     }
457 457
 
458
+    /**
459
+     * @param string $name
460
+     * @param string $label
461
+     */
458 462
     private function getFieldDescriptionMock($name = null, $label = null)
459 463
     {
460 464
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Controller/CRUDController.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
     /**
209 209
      * Delete action.
210 210
      *
211
-     * @param int|string|null $id
211
+     * @param integer|null $id
212 212
      *
213 213
      * @throws NotFoundHttpException If the object does not exist
214 214
      * @throws AccessDeniedException If access is not granted
@@ -726,7 +726,7 @@  discard block
 block discarded – undo
726 726
     /**
727 727
      * View history revision of object.
728 728
      *
729
-     * @param int|string|null $id
729
+     * @param null|integer $id
730 730
      * @param string|null     $revision
731 731
      *
732 732
      * @throws AccessDeniedException If access is not granted
@@ -786,9 +786,9 @@  discard block
 block discarded – undo
786 786
     /**
787 787
      * Compare history revisions of object.
788 788
      *
789
-     * @param int|string|null $id
790
-     * @param int|string|null $base_revision
791
-     * @param int|string|null $compare_revision
789
+     * @param null|integer $id
790
+     * @param null|integer $base_revision
791
+     * @param null|integer $compare_revision
792 792
      *
793 793
      * @throws AccessDeniedException If access is not granted
794 794
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available
Please login to merge, or discard this patch.
tests/Datagrid/PagerTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -639,6 +639,10 @@
 block discarded – undo
639 639
         $this->assertNull($this->pager->getQuery());
640 640
     }
641 641
 
642
+    /**
643
+     * @param Pager $obj
644
+     * @param string $name
645
+     */
642 646
     protected function callMethod($obj, $name, array $args = [])
643 647
     {
644 648
         $class = new \ReflectionClass($obj);
Please login to merge, or discard this patch.
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1019,6 +1019,7 @@  discard block
 block discarded – undo
1019 1019
 
1020 1020
     /**
1021 1021
      * NEXT_MAJOR: remove this method.
1022
+     * @param string $subClass
1022 1023
      */
1023 1024
     public function addSubClass($subClass)
1024 1025
     {
@@ -1173,6 +1174,8 @@  discard block
 block discarded – undo
1173 1174
 
1174 1175
     /**
1175 1176
      * {@inheritdoc}
1177
+     * @param string $name
1178
+     * @param string $adminCode
1176 1179
      */
1177 1180
     public function isCurrentRoute($name, $adminCode = null)
1178 1181
     {
@@ -2542,7 +2545,7 @@  discard block
 block discarded – undo
2542 2545
      *
2543 2546
      * @param string $context
2544 2547
      *
2545
-     * @return array
2548
+     * @return string[]
2546 2549
      */
2547 2550
     public function getPermissionsShow($context)
2548 2551
     {
@@ -2785,7 +2788,7 @@  discard block
 block discarded – undo
2785 2788
     /**
2786 2789
      * Set custom per page options.
2787 2790
      *
2788
-     * @param array $options
2791
+     * @param integer[] $options
2789 2792
      */
2790 2793
     public function setPerPageOptions(array $options)
2791 2794
     {
@@ -2947,6 +2950,7 @@  discard block
 block discarded – undo
2947 2950
 
2948 2951
     /**
2949 2952
      * {@inheritdoc}
2953
+     * @param string $action
2950 2954
      */
2951 2955
     public function configureActionButtons($action, $object = null)
2952 2956
     {
@@ -3078,7 +3082,6 @@  discard block
 block discarded – undo
3078 3082
     }
3079 3083
 
3080 3084
     /**
3081
-     * @param FormMapper $form
3082 3085
      */
3083 3086
     final public function getSearchResultLink($object)
3084 3087
     {
@@ -3193,7 +3196,7 @@  discard block
 block discarded – undo
3193 3196
      * NEXT_MAJOR: remove this method.
3194 3197
      *
3195 3198
      * @param MenuItemInterface $menu
3196
-     * @param                   $action
3199
+     * @param                   string $action
3197 3200
      * @param AdminInterface    $childAdmin
3198 3201
      *
3199 3202
      * @return mixed
Please login to merge, or discard this patch.