Completed
Pull Request — master (#6093)
by Mathieu
35:29
created
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -957,6 +957,7 @@  discard block
 block discarded – undo
957 957
 
958 958
     /**
959 959
      * NEXT_MAJOR: remove this method.
960
+     * @param string $subClass
960 961
      */
961 962
     public function addSubClass($subClass): void
962 963
     {
@@ -1088,6 +1089,9 @@  discard block
 block discarded – undo
1088 1089
         return $this->routeGenerator->hasAdminRoute($this, $name);
1089 1090
     }
1090 1091
 
1092
+    /**
1093
+     * @param string $adminCode
1094
+     */
1091 1095
     public function isCurrentRoute(string $name, ?string $adminCode = null): bool
1092 1096
     {
1093 1097
         if (!$this->hasRequest()) {
@@ -1342,6 +1346,9 @@  discard block
 block discarded – undo
1342 1346
         return $this->baseControllerName;
1343 1347
     }
1344 1348
 
1349
+    /**
1350
+     * @param string $label
1351
+     */
1345 1352
     public function setLabel(?string $label): void
1346 1353
     {
1347 1354
         $this->label = $label;
@@ -2126,6 +2133,9 @@  discard block
 block discarded – undo
2126 2133
         return $this->managerType;
2127 2134
     }
2128 2135
 
2136
+    /**
2137
+     * @param string $type
2138
+     */
2129 2139
     public function setManagerType(?string $type): void
2130 2140
     {
2131 2141
         $this->managerType = $type;
@@ -2579,6 +2589,7 @@  discard block
 block discarded – undo
2579 2589
 
2580 2590
     /**
2581 2591
      * {@inheritdoc}
2592
+     * @param boolean $isShown
2582 2593
      */
2583 2594
     final public function showMosaicButton($isShown): void
2584 2595
     {
@@ -2726,6 +2737,7 @@  discard block
 block discarded – undo
2726 2737
      * NEXT_MAJOR: remove this method.
2727 2738
      *
2728 2739
      * @deprecated Use configureTabMenu instead
2740
+     * @param string $action
2729 2741
      */
2730 2742
     protected function configureSideMenu(ItemInterface $menu, $action, ?AdminInterface $childAdmin = null): void
2731 2743
     {
Please login to merge, or discard this patch.
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -586,6 +586,10 @@
 block discarded – undo
586 586
         $this->admin->setShowBuilder(new ShowBuilder());
587 587
     }
588 588
 
589
+    /**
590
+     * @param string $name
591
+     * @param string $label
592
+     */
589 593
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
590 594
     {
591 595
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Datagrid/DatagridMapper.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -44,6 +44,8 @@
 block discarded – undo
44 44
 
45 45
     /**
46 46
      * @param FieldDescriptionInterface|string $name
47
+     * @param string $type
48
+     * @param string $fieldType
47 49
      *
48 50
      * @throws \LogicException
49 51
      */
Please login to merge, or discard this patch.
src/Show/ShowMapper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -41,6 +41,7 @@
 block discarded – undo
41 41
 
42 42
     /**
43 43
      * @param FieldDescriptionInterface|string $name
44
+     * @param string $type
44 45
      *
45 46
      * @throws \LogicException
46 47
      */
Please login to merge, or discard this patch.
src/Twig/Extension/SonataAdminExtension.php 1 patch
Doc Comments   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     /**
183 183
      * render a view element.
184 184
      *
185
-     * @param object $object
185
+     * @param \stdClass $object
186 186
      *
187 187
      * @return string
188 188
      */
@@ -221,8 +221,8 @@  discard block
 block discarded – undo
221 221
     /**
222 222
      * render a compared view element.
223 223
      *
224
-     * @param mixed $baseObject
225
-     * @param mixed $compareObject
224
+     * @param \stdClass $baseObject
225
+     * @param \stdClass $compareObject
226 226
      *
227 227
      * @return string
228 228
      */
@@ -343,7 +343,8 @@  discard block
 block discarded – undo
343 343
     /**
344 344
      * Get the identifiers as a string that is safe to use in a url.
345 345
      *
346
-     * @param object $model
346
+     * @param \stdClass $model
347
+     * @param AdminInterface $admin
347 348
      *
348 349
      * @return string string representation of the id that is safe to use in a url
349 350
      */
@@ -365,7 +366,7 @@  discard block
 block discarded – undo
365 366
     }
366 367
 
367 368
     /**
368
-     * @return string|bool
369
+     * @return string|false
369 370
      */
370 371
     public function getXEditableType($type)
371 372
     {
Please login to merge, or discard this patch.
src/Datagrid/ListMapper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
     }
44 44
 
45 45
     /**
46
-     * @param FieldDescriptionInterface|string $name
46
+     * @param \Sonata\AdminBundle\Admin\BaseFieldDescription $name
47 47
      */
48 48
     public function addIdentifier($name, ?string $type = null, array $fieldDescriptionOptions = []): self
49 49
     {
Please login to merge, or discard this patch.
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -414,6 +414,10 @@
 block discarded – undo
414 414
         );
415 415
     }
416 416
 
417
+    /**
418
+     * @param string $name
419
+     * @param string $label
420
+     */
417 421
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
418 422
     {
419 423
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Admin/Pool.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -70,6 +70,9 @@
 block discarded – undo
70 70
      */
71 71
     protected $propertyAccessor;
72 72
 
73
+    /**
74
+     * @param PropertyAccessorInterface $propertyAccessor
75
+     */
73 76
     public function __construct(
74 77
         ContainerInterface $container,
75 78
         string $title,
Please login to merge, or discard this patch.
src/Admin/FieldDescriptionInterface.php 1 patch
Doc Comments   +14 added lines patch added patch discarded remove patch
@@ -25,6 +25,7 @@  discard block
 block discarded – undo
25 25
 {
26 26
     /**
27 27
      * set the field name.
28
+     * @return void
28 29
      */
29 30
     public function setFieldName(?string $fieldName): void;
30 31
 
@@ -37,6 +38,7 @@  discard block
 block discarded – undo
37 38
 
38 39
     /**
39 40
      * Set the name.
41
+     * @return void
40 42
      */
41 43
     public function setName(?string $name): void;
42 44
 
@@ -60,6 +62,7 @@  discard block
 block discarded – undo
60 62
      * Define an option, an option is has a name and a value.
61 63
      *
62 64
      * @param mixed $value
65
+     * @return void
63 66
      */
64 67
     public function setOption(string $name, $value): void;
65 68
 
@@ -71,6 +74,7 @@  discard block
 block discarded – undo
71 74
      * Then the value are copied across to the related property value.
72 75
      *
73 76
      * @param array<string, mixed> $options
77
+     * @return void
74 78
      */
75 79
     public function setOptions(array $options): void;
76 80
 
@@ -83,6 +87,7 @@  discard block
 block discarded – undo
83 87
 
84 88
     /**
85 89
      * Sets the template used to render the field.
90
+     * @return void
86 91
      */
87 92
     public function setTemplate(string $template): void;
88 93
 
@@ -96,16 +101,19 @@  discard block
 block discarded – undo
96 101
     /**
97 102
      * Sets the field type. The type is a mandatory field as it's used to select the correct template
98 103
      * or the logic associated to the current FieldDescription object.
104
+     * @return void
99 105
      */
100 106
     public function setType(?string $type): void;
101 107
 
102 108
     /**
103 109
      * Returns the type.
110
+     * @return string
104 111
      */
105 112
     public function getType(): ?string;
106 113
 
107 114
     /**
108 115
      * set the parent Admin (only used in nested admin).
116
+     * @return void
109 117
      */
110 118
     public function setParent(AdminInterface $parent);
111 119
 
@@ -135,6 +143,7 @@  discard block
 block discarded – undo
135 143
      * Returns the related Target object model.
136 144
      *
137 145
      * @deprecated since sonata-project/admin-bundle 3.69. Use `getTargetModel()` instead.
146
+     * @return string
138 147
      */
139 148
     public function getTargetEntity(): ?string;
140 149
 
@@ -168,6 +177,7 @@  discard block
 block discarded – undo
168 177
      * set the association admin instance (only used if the field is linked to an Admin).
169 178
      *
170 179
      * @param AdminInterface $associationAdmin the associated admin
180
+     * @return void
171 181
      */
172 182
     public function setAssociationAdmin(AdminInterface $associationAdmin);
173 183
 
@@ -195,6 +205,7 @@  discard block
 block discarded – undo
195 205
 
196 206
     /**
197 207
      * set the admin class linked to this FieldDescription.
208
+     * @return void
198 209
      */
199 210
     public function setAdmin(AdminInterface $admin);
200 211
 
@@ -210,11 +221,13 @@  discard block
 block discarded – undo
210 221
      * merge option values related to the provided option name.
211 222
      *
212 223
      * @throws \RuntimeException
224
+     * @return void
213 225
      */
214 226
     public function mergeOption(string $name, array $options = []): void;
215 227
 
216 228
     /**
217 229
      * merge options values.
230
+     * @return void
218 231
      */
219 232
     public function mergeOptions(array $options = []): void;
220 233
 
@@ -222,6 +235,7 @@  discard block
 block discarded – undo
222 235
      * set the original mapping type (only used if the field is linked to an entity).
223 236
      *
224 237
      * @param string|int $mappingType
238
+     * @return void
225 239
      */
226 240
     public function setMappingType($mappingType);
227 241
 
Please login to merge, or discard this patch.