AdminVoter::matchItem() - Code Metrics - Inspection of "Fixed "request" attribute deprecation on "knp_menu..." - sonata-project/SonataAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x ( 11c3ea...aeee6f )

by Grégoire

created 2018-01-06 16:43 UTC

AdminVoter::matchItem() C

↳ Parent: AdminVoter

Complexity

Conditions	12
Paths	12

Size

Total Lines	33
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	33
rs	5.1612
c	0
b	0
f	0
cc	12
eloc	18
nc	12
nop	1

How to fix Complexity

<?php

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\AdminBundle\Menu\Matcher\Voter;

use Knp\Menu\ItemInterface;
use Knp\Menu\Matcher\Voter\VoterInterface;
use Sonata\AdminBundle\Admin\AdminInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;

/**
 * Admin menu voter based on extra `admin`.
 *
 * @author Samusev Andrey <[email protected]>
 */
class AdminVoter implements VoterInterface
{
    /**
     * @var RequestStack
     */
    private $requestStack;

    /**
     * @var Request
     */
    private $request = null;

    public function __construct(RequestStack $requestStack = null)
    {
        $this->requestStack = $requestStack;
    }

    /**
     * @deprecated since version 3.x. Pass a RequestStack to the constructor instead.
     *
     * @return $this
     */
    public function setRequest($request)
    {
        @trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            sprintf(
                'The %s() method is deprecated since version 3.x.
                Pass a Symfony\Component\HttpFoundation\RequestStack
                in the constructor instead.',
            __METHOD__),
            E_USER_DEPRECATED
        );

        $this->request = $request;

        return $this;
    }

    public function matchItem(ItemInterface $item)
    {
        $admin = $item->getExtra('admin');

        $request = $this->request;
        if (null !== $this->requestStack) {
            $request = $this->requestStack->getMasterRequest();
        }

        if ($admin instanceof AdminInterface
            && $admin->hasRoute('list') && $admin->hasAccess('list')
            && $request
        ) {
            $requestCode = $request->get('_sonata_admin');

            if ($admin->getCode() === $requestCode) {
                return true;
            }

            foreach ($admin->getChildren() as $child) {
                if ($child->getBaseCodeRoute() === $requestCode) {
                    return true;
                }
            }
        }

        $route = $item->getExtra('route');
        if ($route && $request && $route == $request->get('_route')) {
            return true;
        }

        return null;
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sonata Project package.
5			*
6			* (c) Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sonata\AdminBundle\Menu\Matcher\Voter;
13
14			use Knp\Menu\ItemInterface;
15			use Knp\Menu\Matcher\Voter\VoterInterface;
16			use Sonata\AdminBundle\Admin\AdminInterface;
17			use Symfony\Component\HttpFoundation\Request;
18			use Symfony\Component\HttpFoundation\RequestStack;
19
20			/**
21			* Admin menu voter based on extra `admin`.
22			*
23			* @author Samusev Andrey <[email protected]>
24			*/
25			class AdminVoter implements VoterInterface
26			{
27			/**
28			* @var RequestStack
29			*/
30			private $requestStack;
31
32			/**
33			* @var Request
34			*/
35			private $request = null;
36
37			public function __construct(RequestStack $requestStack = null)
38			{
39			$this->requestStack = $requestStack;
40			}
41
42			/**
43			* @deprecated since version 3.x. Pass a RequestStack to the constructor instead.
44			*
45			* @return $this
46			*/
47			public function setRequest($request)
48			{
49			@trigger_error(
			0 ignored issues – show Security Best Practice introduced 2017-12-26 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
50			sprintf(
51			'The %s() method is deprecated since version 3.x.
52			Pass a Symfony\Component\HttpFoundation\RequestStack
53			in the constructor instead.',
54			__METHOD__),
55			E_USER_DEPRECATED
56			);
57
58			$this->request = $request;
59
60			return $this;
61			}
62
63			public function matchItem(ItemInterface $item)
64			{
65			$admin = $item->getExtra('admin');
66
67			$request = $this->request;
68			if (null !== $this->requestStack) {
69			$request = $this->requestStack->getMasterRequest();
70			}
71
72			if ($admin instanceof AdminInterface
73			&& $admin->hasRoute('list') && $admin->hasAccess('list')
74			&& $request
75			) {
76			$requestCode = $request->get('_sonata_admin');
77
78			if ($admin->getCode() === $requestCode) {
79			return true;
80			}
81
82			foreach ($admin->getChildren() as $child) {
83			if ($child->getBaseCodeRoute() === $requestCode) {
84			return true;
85			}
86			}
87			}
88
89			$route = $item->getExtra('route');
90			if ($route && $request && $route == $request->get('_route')) {
91			return true;
92			}
93
94			return null;
95			}
96			}
97

sonata-project / SonataAdminBundle

Push — 3.x ( 11c3ea...aeee6f )

AdminVoter::matchItem() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like