Completed
Pull Request — master (#4831)
by Jordi Sala
10:38 queued 05:56
created
src/Twig/Extension/SonataAdminExtension.php 2 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     /**
123 123
      * render a list element from the FieldDescription.
124 124
      *
125
-     * @param mixed                     $object
125
+     * @param \stdClass                     $object
126 126
      * @param FieldDescriptionInterface $fieldDescription
127 127
      * @param array                     $params
128 128
      *
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
      * render a view element.
153 153
      *
154 154
      * @param FieldDescriptionInterface $fieldDescription
155
-     * @param mixed                     $object
155
+     * @param \stdClass                     $object
156 156
      *
157 157
      * @return string
158 158
      */
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
     /**
292 292
      * Get the identifiers as a string that is safe to use in a url.
293 293
      *
294
-     * @param object         $model
294
+     * @param \stdClass         $model
295 295
      * @param AdminInterface $admin
296 296
      *
297 297
      * @return string string representation of the id that is safe to use in a url
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
     /**
317 317
      * @param $type
318 318
      *
319
-     * @return string|bool
319
+     * @return string|false
320 320
      */
321 321
     public function getXEditableType($type)
322 322
     {
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
      * @param FieldDescriptionInterface $fieldDescription
448 448
      * @param string                    $defaultTemplate
449 449
      *
450
-     * @return \Twig_TemplateInterface
450
+     * @return \Twig_Template
451 451
      */
452 452
     private function getTemplate(
453 453
         FieldDescriptionInterface $fieldDescription,
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
 use Symfony\Component\Translation\TranslatorInterface;
21 21
 use Twig\Environment;
22 22
 use Twig\Extension\AbstractExtension;
23
-use Twig\Template;
24 23
 use Twig\TwigFilter;
25 24
 
26 25
 /**
Please login to merge, or discard this patch.
src/Controller/PolyfillControllerTrait.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -25,6 +25,9 @@
 block discarded – undo
25 25
  */
26 26
 trait PolyfillControllerTrait
27 27
 {
28
+    /**
29
+     * @param string $methodName
30
+     */
28 31
     public function __call($methodName, $arguments)
29 32
     {
30 33
         $this->proxyToController($methodName, $arguments);
Please login to merge, or discard this patch.
tests/Generator/AdminGeneratorTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
     }
68 68
 
69 69
     /**
70
-     * @return ModelManagerInterface|\PHPUnit_Framework_MockObject_MockObject
70
+     * @return ModelManagerInterface
71 71
      */
72 72
     private function createModelManagerMock()
73 73
     {
Please login to merge, or discard this patch.
src/Twig/GlobalVariables.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     /**
68 68
      * @param string $code
69 69
      * @param string $action
70
-     * @param array  $parameters
70
+     * @param string[]  $parameters
71 71
      * @param int    $absolute
72 72
      *
73 73
      * @return string
@@ -82,8 +82,8 @@  discard block
 block discarded – undo
82 82
     /**
83 83
      * @param string $code
84 84
      * @param string $action
85
-     * @param mixed  $object
86
-     * @param array  $parameters
85
+     * @param string  $object
86
+     * @param string[]  $parameters
87 87
      * @param int    $absolute
88 88
      *
89 89
      * @return string
@@ -96,8 +96,8 @@  discard block
 block discarded – undo
96 96
     }
97 97
 
98 98
     /**
99
-     * @param $code
100
-     * @param $action
99
+     * @param string $code
100
+     * @param string $action
101 101
      *
102 102
      * @return array
103 103
      */
Please login to merge, or discard this patch.
tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -266,6 +266,12 @@
 block discarded – undo
266 266
         ], array_keys($this->datagrid->getFilters()));
267 267
     }
268 268
 
269
+    /**
270
+     * @param string $name
271
+     * @param string $label
272
+     *
273
+     * @return string
274
+     */
269 275
     private function getFieldDescriptionMock($name = null, $label = null)
270 276
     {
271 277
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -255,6 +255,12 @@
 block discarded – undo
255 255
         ], true), print_r($this->fieldDescriptionCollection->getElements(), true));
256 256
     }
257 257
 
258
+    /**
259
+     * @param string $name
260
+     * @param string $label
261
+     *
262
+     * @return string
263
+     */
258 264
     private function getFieldDescriptionMock($name = null, $label = null)
259 265
     {
260 266
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -455,6 +455,10 @@
 block discarded – undo
455 455
         $this->showMapper = new ShowMapper($this->showBuilder, $this->fieldDescriptionCollection, $this->admin);
456 456
     }
457 457
 
458
+    /**
459
+     * @param string $name
460
+     * @param string $label
461
+     */
458 462
     private function getFieldDescriptionMock($name = null, $label = null)
459 463
     {
460 464
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Controller/CRUDController.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
     /**
209 209
      * Delete action.
210 210
      *
211
-     * @param int|string|null $id
211
+     * @param integer|null $id
212 212
      *
213 213
      * @throws NotFoundHttpException If the object does not exist
214 214
      * @throws AccessDeniedException If access is not granted
@@ -726,7 +726,7 @@  discard block
 block discarded – undo
726 726
     /**
727 727
      * View history revision of object.
728 728
      *
729
-     * @param int|string|null $id
729
+     * @param null|integer $id
730 730
      * @param string|null     $revision
731 731
      *
732 732
      * @throws AccessDeniedException If access is not granted
@@ -786,9 +786,9 @@  discard block
 block discarded – undo
786 786
     /**
787 787
      * Compare history revisions of object.
788 788
      *
789
-     * @param int|string|null $id
790
-     * @param int|string|null $base_revision
791
-     * @param int|string|null $compare_revision
789
+     * @param null|integer $id
790
+     * @param null|integer $base_revision
791
+     * @param null|integer $compare_revision
792 792
      *
793 793
      * @throws AccessDeniedException If access is not granted
794 794
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available
Please login to merge, or discard this patch.
tests/Datagrid/PagerTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -639,6 +639,10 @@
 block discarded – undo
639 639
         $this->assertNull($this->pager->getQuery());
640 640
     }
641 641
 
642
+    /**
643
+     * @param Pager $obj
644
+     * @param string $name
645
+     */
642 646
     protected function callMethod($obj, $name, array $args = [])
643 647
     {
644 648
         $class = new \ReflectionClass($obj);
Please login to merge, or discard this patch.