ObjectManipulatorTest::testAddInstanceWithParentAssociation() - Code Metrics - Inspection of "Improve the way we append parent object if any" - sonata-project/SonataAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 3.x (#6171)

by Vincent

created 2020-07-12 18:49 UTC

testAddInstanceWithParentAssociation() A

↳ Parent: ObjectManipulatorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.7333
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\AdminBundle\Tests\Manipulator;

use PHPUnit\Framework\TestCase;
use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
use Sonata\AdminBundle\Manipulator\ObjectManipulator;

class ObjectManipulatorTest extends TestCase
{
    public function testAddInstance(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBar']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);

        $instance = new \stdClass();
        $object = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
        $object->expects($this->once())->method('addFooBar')->with($instance);

        ObjectManipulator::addInstance($object, $instance, $fieldDescription);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testAddInstanceWithParentAssociation(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBar']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([['fieldName' => 'parent']]);

        $instance = new \stdClass();

        $object2 = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
        $object2->expects($this->once())->method('addFooBar')->with($instance);

        $object1 = $this->getMockBuilder(\stdClass::class)->setMethods(['getParent'])->getMock();
        $object1->expects($this->once())->method('getParent')->willReturn($object2);

        ObjectManipulator::addInstance($object1, $instance, $fieldDescription);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testAddInstancePlural(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBars']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);

        $instance = new \stdClass();
        $object = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
        $object->expects($this->once())->method('addFooBar')->with($instance);

        ObjectManipulator::addInstance($object, $instance, $fieldDescription);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testAddInstanceInflector(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'entries']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);

        $instance = new \stdClass();
        $object = $this->getMockBuilder(\stdClass::class)->setMethods(['addEntry'])->getMock();
        $object->expects($this->once())->method('addEntry')->with($instance);

        ObjectManipulator::addInstance($object, $instance, $fieldDescription);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testSetObject(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['mappedBy' => 'parent']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);

        $object = new \stdClass();
        $instance = $this->getMockBuilder(\stdClass::class)->setMethods(['setParent'])->getMock();
        $instance->expects($this->once())->method('setParent')->with($object);

        ObjectManipulator::setObject($instance, $object, $fieldDescription);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testSetObjectWithParentAssociation(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['mappedBy' => 'fooBar']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([['fieldName' => 'parent']]);

        $object2 = new \stdClass();

        $instance = $this->getMockBuilder(\stdClass::class)->setMethods(['setFooBar'])->getMock();
        $instance->expects($this->once())->method('setFooBar')->with($object2);

        $object1 = $this->getMockBuilder(\stdClass::class)->setMethods(['getParent'])->getMock();
        $object1->expects($this->once())->method('getParent')->willReturn($object2);

        ObjectManipulator::setObject($instance, $object1, $fieldDescription);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\AdminBundle\Tests\Manipulator;
15
16			use PHPUnit\Framework\TestCase;
17			use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
18			use Sonata\AdminBundle\Manipulator\ObjectManipulator;
19
20			class ObjectManipulatorTest extends TestCase
21			{
22			public function testAddInstance(): void
23			{
24			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
25			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBar']);
26			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);
27
28			$instance = new \stdClass();
29			$object = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
30			$object->expects($this->once())->method('addFooBar')->with($instance);
31
32			ObjectManipulator::addInstance($object, $instance, $fieldDescription);
			0 ignored issues – show Documentation introduced 2020-07-06 19:44 UTC by Report Bug Copy Issue Report `$instance` is of type `object<stdClass>`, but the function expects a `object<Sonata\AdminBundle\Manipulator\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			}
34
35			public function testAddInstanceWithParentAssociation(): void
36			{
37			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
38			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBar']);
39			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([['fieldName' => 'parent']]);
40
41			$instance = new \stdClass();
42
43			$object2 = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
44			$object2->expects($this->once())->method('addFooBar')->with($instance);
45
46			$object1 = $this->getMockBuilder(\stdClass::class)->setMethods(['getParent'])->getMock();
47			$object1->expects($this->once())->method('getParent')->willReturn($object2);
48
49			ObjectManipulator::addInstance($object1, $instance, $fieldDescription);
			0 ignored issues – show Documentation introduced 2020-07-06 19:44 UTC by Report Bug Copy Issue Report `$instance` is of type `object<stdClass>`, but the function expects a `object<Sonata\AdminBundle\Manipulator\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
50			}
51
52			public function testAddInstancePlural(): void
53			{
54			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
55			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBars']);
56			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);
57
58			$instance = new \stdClass();
59			$object = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
60			$object->expects($this->once())->method('addFooBar')->with($instance);
61
62			ObjectManipulator::addInstance($object, $instance, $fieldDescription);
			0 ignored issues – show Documentation introduced 2020-07-06 19:44 UTC by Report Bug Copy Issue Report `$instance` is of type `object<stdClass>`, but the function expects a `object<Sonata\AdminBundle\Manipulator\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63			}
64
65			public function testAddInstanceInflector(): void
66			{
67			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
68			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'entries']);
69			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);
70
71			$instance = new \stdClass();
72			$object = $this->getMockBuilder(\stdClass::class)->setMethods(['addEntry'])->getMock();
73			$object->expects($this->once())->method('addEntry')->with($instance);
74
75			ObjectManipulator::addInstance($object, $instance, $fieldDescription);
			0 ignored issues – show Documentation introduced 2020-07-06 19:44 UTC by Report Bug Copy Issue Report `$instance` is of type `object<stdClass>`, but the function expects a `object<Sonata\AdminBundle\Manipulator\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
76			}
77
78			public function testSetObject(): void
79			{
80			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
81			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['mappedBy' => 'parent']);
82			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);
83
84			$object = new \stdClass();
85			$instance = $this->getMockBuilder(\stdClass::class)->setMethods(['setParent'])->getMock();
86			$instance->expects($this->once())->method('setParent')->with($object);
87
88			ObjectManipulator::setObject($instance, $object, $fieldDescription);
			0 ignored issues – show Documentation introduced 2020-07-06 19:44 UTC by Report Bug Copy Issue Report `$object` is of type `object<stdClass>`, but the function expects a `object<Sonata\AdminBundle\Manipulator\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
89			}
90
91			public function testSetObjectWithParentAssociation(): void
92			{
93			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
94			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['mappedBy' => 'fooBar']);
95			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([['fieldName' => 'parent']]);
96
97			$object2 = new \stdClass();
98
99			$instance = $this->getMockBuilder(\stdClass::class)->setMethods(['setFooBar'])->getMock();
100			$instance->expects($this->once())->method('setFooBar')->with($object2);
101
102			$object1 = $this->getMockBuilder(\stdClass::class)->setMethods(['getParent'])->getMock();
103			$object1->expects($this->once())->method('getParent')->willReturn($object2);
104
105			ObjectManipulator::setObject($instance, $object1, $fieldDescription);
106			}
107			}
108

sonata-project / SonataAdminBundle

Pull Request — 3.x (#6171)

testAddInstanceWithParentAssociation() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like