Completed
Pull Request — master (#6093)
by Mathieu
30:17 queued 27:30
created
tests/Form/Widget/FormSonataFilterChoiceWidgetTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -56,6 +56,9 @@
 block discarded – undo
56 56
         );
57 57
     }
58 58
 
59
+    /**
60
+     * @return string
61
+     */
59 62
     protected function getChoiceClass()
60 63
     {
61 64
         return ChoiceType::class;
Please login to merge, or discard this patch.
src/Model/ModelManagerInterface.php 1 patch
Doc Comments   +11 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,6 +37,7 @@  discard block
 block discarded – undo
37 37
      * @param object $object
38 38
      *
39 39
      * @throws ModelManagerException
40
+     * @return void
40 41
      */
41 42
     public function create($object);
42 43
 
@@ -44,6 +45,7 @@  discard block
 block discarded – undo
44 45
      * @param object $object
45 46
      *
46 47
      * @throws ModelManagerException
48
+     * @return void
47 49
      */
48 50
     public function update($object);
49 51
 
@@ -51,6 +53,7 @@  discard block
 block discarded – undo
51 53
      * @param object $object
52 54
      *
53 55
      * @throws ModelManagerException
56
+     * @return void
54 57
      */
55 58
     public function delete($object);
56 59
 
@@ -72,7 +75,7 @@  discard block
 block discarded – undo
72 75
      * @param string $class
73 76
      * @param mixed  $id
74 77
      *
75
-     * @return object|null the object with id or null if not found
78
+     * @return \Sonata\AdminBundle\Tests\App\Model\Foo|null the object with id or null if not found
76 79
      */
77 80
     public function find($class, $id);
78 81
 
@@ -80,6 +83,7 @@  discard block
 block discarded – undo
80 83
      * @param string $class
81 84
      *
82 85
      * @throws ModelManagerException
86
+     * @return void
83 87
      */
84 88
     public function batchDelete($class, ProxyQueryInterface $queryProxy);
85 89
 
@@ -156,7 +160,7 @@  discard block
 block discarded – undo
156 160
      *
157 161
      * @param string $class
158 162
      *
159
-     * @return object
163
+     * @return \Sonata\AdminBundle\Tests\App\Model\Foo
160 164
      */
161 165
     public function getModelInstance($class);
162 166
 
@@ -172,6 +176,7 @@  discard block
 block discarded – undo
172 176
      *
173 177
      * @param array  $collection
174 178
      * @param object $element
179
+     * @return void
175 180
      */
176 181
     public function collectionRemoveElement(&$collection, &$element);
177 182
 
@@ -180,6 +185,7 @@  discard block
 block discarded – undo
180 185
      *
181 186
      * @param array  $collection
182 187
      * @param object $element
188
+     * @return void
183 189
      */
184 190
     public function collectionAddElement(&$collection, &$element);
185 191
 
@@ -197,6 +203,7 @@  discard block
 block discarded – undo
197 203
      * Clear the collection.
198 204
      *
199 205
      * @param array $collection
206
+     * @return void
200 207
      */
201 208
     public function collectionClear(&$collection);
202 209
 
@@ -229,6 +236,7 @@  discard block
 block discarded – undo
229 236
 
230 237
     /**
231 238
      * @param mixed $query
239
+     * @return void
232 240
      */
233 241
     public function executeQuery($query);
234 242
 
@@ -261,6 +269,7 @@  discard block
 block discarded – undo
261 269
 
262 270
     /**
263 271
      * @param string $class
272
+     * @return void
264 273
      */
265 274
     public function addIdentifiersToQuery($class, ProxyQueryInterface $query, array $idx);
266 275
 }
Please login to merge, or discard this patch.
src/Filter/FilterInterface.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,6 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
     /**
64 64
      * @param string $label
65
+     * @return void
65 66
      */
66 67
     public function setLabel($label);
67 68
 
@@ -72,7 +73,7 @@  discard block
 block discarded – undo
72 73
 
73 74
     /**
74 75
      * @param string     $name
75
-     * @param mixed|null $default
76
+     * @param boolean $default
76 77
      *
77 78
      * @return mixed
78 79
      */
@@ -80,12 +81,14 @@  discard block
 block discarded – undo
80 81
 
81 82
     /**
82 83
      * @param string $name
83
-     * @param mixed  $value
84
+     * @param boolean  $value
85
+     * @return void
84 86
      */
85 87
     public function setOption($name, $value);
86 88
 
87 89
     /**
88 90
      * @param string $name
91
+     * @return void
89 92
      */
90 93
     public function initialize($name, array $options = []);
91 94
 
@@ -129,6 +132,7 @@  discard block
 block discarded – undo
129 132
      *
130 133
      * @param string $name
131 134
      * @param mixed  $value
135
+     * @return void
132 136
      */
133 137
     public function setFieldOption($name, $value);
134 138
 
@@ -155,6 +159,7 @@  discard block
 block discarded – undo
155 159
      * Set the condition to use with the left side of the query : OR or AND.
156 160
      *
157 161
      * @param string $condition
162
+     * @return void
158 163
      */
159 164
     public function setCondition($condition);
160 165
 
Please login to merge, or discard this patch.
tests/Fixtures/Admin/PostAdmin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -19,6 +19,9 @@
 block discarded – undo
19 19
 {
20 20
     protected $metadataClass;
21 21
 
22
+    /**
23
+     * @param string $associationMapping
24
+     */
22 25
     public function setParentAssociationMapping($associationMapping): void
23 26
     {
24 27
         $this->parentAssociationMapping = $associationMapping;
Please login to merge, or discard this patch.
src/Form/ChoiceList/ModelChoiceLoader.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -65,6 +65,7 @@
 block discarded – undo
65 65
      * @param string|null $property
66 66
      * @param mixed|null  $query
67 67
      * @param array       $choices
68
+     * @param PropertyAccessorInterface $propertyAccessor
68 69
      */
69 70
     public function __construct(
70 71
         ModelManagerInterface $modelManager,
Please login to merge, or discard this patch.
src/Security/Handler/AclSecurityHandler.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -181,6 +181,9 @@
 block discarded – undo
181 181
         return $acls;
182 182
     }
183 183
 
184
+    /**
185
+     * @param UserSecurityIdentity $securityIdentity
186
+     */
184 187
     public function addObjectOwner(AclInterface $acl, ?UserSecurityIdentity $securityIdentity = null): void
185 188
     {
186 189
         if (false === $this->findClassAceIndexByUsername($acl, $securityIdentity->getUsername())) {
Please login to merge, or discard this patch.
src/Translator/Extractor/JMSTranslatorBundle/AdminExtractor.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -196,6 +196,11 @@
 block discarded – undo
196 196
         return $id;
197 197
     }
198 198
 
199
+    /**
200
+     * @param string $id
201
+     * @param integer $number
202
+     * @param string $domain
203
+     */
199 204
     public function transChoice($id, $number, array $parameters = [], ?string $domain = null, ?string $locale = null)
200 205
     {
201 206
         $this->addMessage($id, $domain);
Please login to merge, or discard this patch.
src/Admin/BaseFieldDescription.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -131,6 +131,9 @@  discard block
 block discarded – undo
131 131
      */
132 132
     private static $fieldGetters = [];
133 133
 
134
+    /**
135
+     * @param string $fieldName
136
+     */
134 137
     public function setFieldName(?string $fieldName): void
135 138
     {
136 139
         $this->fieldName = $fieldName;
@@ -141,6 +144,9 @@  discard block
 block discarded – undo
141 144
         return $this->fieldName;
142 145
     }
143 146
 
147
+    /**
148
+     * @param string $name
149
+     */
144 150
     public function setName(?string $name): void
145 151
     {
146 152
         $this->name = $name;
@@ -270,6 +276,9 @@  discard block
 block discarded – undo
270 276
         return null !== $this->associationAdmin;
271 277
     }
272 278
 
279
+    /**
280
+     * @param string $fieldName
281
+     */
273 282
     public function getFieldValue(?object $object, ?string $fieldName)
274 283
     {
275 284
         if ($this->isVirtual() || null === $object) {
Please login to merge, or discard this patch.
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -957,6 +957,7 @@  discard block
 block discarded – undo
957 957
 
958 958
     /**
959 959
      * NEXT_MAJOR: remove this method.
960
+     * @param string $subClass
960 961
      */
961 962
     public function addSubClass($subClass): void
962 963
     {
@@ -1088,6 +1089,9 @@  discard block
 block discarded – undo
1088 1089
         return $this->routeGenerator->hasAdminRoute($this, $name);
1089 1090
     }
1090 1091
 
1092
+    /**
1093
+     * @param string $adminCode
1094
+     */
1091 1095
     public function isCurrentRoute(string $name, ?string $adminCode = null): bool
1092 1096
     {
1093 1097
         if (!$this->hasRequest()) {
@@ -1342,6 +1346,9 @@  discard block
 block discarded – undo
1342 1346
         return $this->baseControllerName;
1343 1347
     }
1344 1348
 
1349
+    /**
1350
+     * @param string $label
1351
+     */
1345 1352
     public function setLabel(?string $label): void
1346 1353
     {
1347 1354
         $this->label = $label;
@@ -2126,6 +2133,9 @@  discard block
 block discarded – undo
2126 2133
         return $this->managerType;
2127 2134
     }
2128 2135
 
2136
+    /**
2137
+     * @param string $type
2138
+     */
2129 2139
     public function setManagerType(?string $type): void
2130 2140
     {
2131 2141
         $this->managerType = $type;
@@ -2579,6 +2589,7 @@  discard block
 block discarded – undo
2579 2589
 
2580 2590
     /**
2581 2591
      * {@inheritdoc}
2592
+     * @param boolean $isShown
2582 2593
      */
2583 2594
     final public function showMosaicButton($isShown): void
2584 2595
     {
@@ -2726,6 +2737,7 @@  discard block
 block discarded – undo
2726 2737
      * NEXT_MAJOR: remove this method.
2727 2738
      *
2728 2739
      * @deprecated Use configureTabMenu instead
2740
+     * @param string $action
2729 2741
      */
2730 2742
     protected function configureSideMenu(ItemInterface $menu, $action, ?AdminInterface $childAdmin = null): void
2731 2743
     {
Please login to merge, or discard this patch.