Completed
Pull Request — master (#6093)
by Mathieu
12:11
created
src/Controller/CRUDController.php 1 patch
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -72,6 +72,7 @@  discard block
 block discarded – undo
72 72
      *
73 73
      * @param string               $view       The view name
74 74
      * @param array<string, mixed> $parameters An array of parameters to pass to the view
75
+     * @param Response $response
75 76
      */
76 77
     public function renderWithExtraParams($view, array $parameters = [], ?Response $response = null): Response
77 78
     {
@@ -711,8 +712,8 @@  discard block
 block discarded – undo
711 712
     /**
712 713
      * Compare history revisions of object.
713 714
      *
714
-     * @param int|string|null $baseRevision
715
-     * @param int|string|null $compareRevision
715
+     * @param null|integer $baseRevision
716
+     * @param null|integer $compareRevision
716 717
      *
717 718
      * @throws AccessDeniedException If access is not granted
718 719
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available
@@ -1408,6 +1409,7 @@  discard block
 block discarded – undo
1408 1409
 
1409 1410
     /**
1410 1411
      * Sets the admin form theme to form view. Used for compatibility between Symfony versions.
1412
+     * @param string[] $theme
1411 1413
      */
1412 1414
     private function setFormTheme(FormView $formView, ?array $theme = null): void
1413 1415
     {
Please login to merge, or discard this patch.
src/Translator/Extractor/JMSTranslatorBundle/AdminExtractor.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -196,6 +196,11 @@
 block discarded – undo
196 196
         return $id;
197 197
     }
198 198
 
199
+    /**
200
+     * @param string $id
201
+     * @param integer $number
202
+     * @param string $domain
203
+     */
199 204
     public function transChoice($id, $number, array $parameters = [], ?string $domain = null, ?string $locale = null)
200 205
     {
201 206
         $this->addMessage($id, $domain);
Please login to merge, or discard this patch.
src/Admin/BaseFieldDescription.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -131,6 +131,9 @@  discard block
 block discarded – undo
131 131
      */
132 132
     private static $fieldGetters = [];
133 133
 
134
+    /**
135
+     * @param string $fieldName
136
+     */
134 137
     public function setFieldName(?string $fieldName): void
135 138
     {
136 139
         $this->fieldName = $fieldName;
@@ -141,6 +144,9 @@  discard block
 block discarded – undo
141 144
         return $this->fieldName;
142 145
     }
143 146
 
147
+    /**
148
+     * @param string $name
149
+     */
144 150
     public function setName(?string $name): void
145 151
     {
146 152
         $this->name = $name;
@@ -270,6 +276,9 @@  discard block
 block discarded – undo
270 276
         return null !== $this->associationAdmin;
271 277
     }
272 278
 
279
+    /**
280
+     * @param string $fieldName
281
+     */
273 282
     public function getFieldValue(?object $object, ?string $fieldName)
274 283
     {
275 284
         if ($this->isVirtual() || null === $object) {
Please login to merge, or discard this patch.
src/Admin/FieldDescriptionInterface.php 1 patch
Doc Comments   +16 added lines patch added patch discarded remove patch
@@ -20,6 +20,7 @@  discard block
 block discarded – undo
20 20
 {
21 21
     /**
22 22
      * set the field name.
23
+     * @return void
23 24
      */
24 25
     public function setFieldName(?string $fieldName): void;
25 26
 
@@ -32,6 +33,7 @@  discard block
 block discarded – undo
32 33
 
33 34
     /**
34 35
      * Set the name.
36
+     * @return void
35 37
      */
36 38
     public function setName(?string $name): void;
37 39
 
@@ -55,6 +57,7 @@  discard block
 block discarded – undo
55 57
      * Define an option, an option is has a name and a value.
56 58
      *
57 59
      * @param mixed $value
60
+     * @return void
58 61
      */
59 62
     public function setOption(string $name, $value): void;
60 63
 
@@ -66,6 +69,7 @@  discard block
 block discarded – undo
66 69
      * Then the value are copied across to the related property value.
67 70
      *
68 71
      * @param array<string, mixed> $options
72
+     * @return void
69 73
      */
70 74
     public function setOptions(array $options): void;
71 75
 
@@ -78,6 +82,7 @@  discard block
 block discarded – undo
78 82
 
79 83
     /**
80 84
      * Sets the template used to render the field.
85
+     * @return void
81 86
      */
82 87
     public function setTemplate(string $template): void;
83 88
 
@@ -91,21 +96,25 @@  discard block
 block discarded – undo
91 96
     /**
92 97
      * Sets the field type. The type is a mandatory field as it's used to select the correct template
93 98
      * or the logic associated to the current FieldDescription object.
99
+     * @return void
94 100
      */
95 101
     public function setType(?string $type): void;
96 102
 
97 103
     /**
98 104
      * Returns the type.
105
+     * @return string
99 106
      */
100 107
     public function getType(): ?string;
101 108
 
102 109
     /**
103 110
      * set the parent Admin (only used in nested admin).
111
+     * @return void
104 112
      */
105 113
     public function setParent(AdminInterface $parent);
106 114
 
107 115
     /**
108 116
      * Returns the parent Admin (only used in nested admin).
117
+     * @return AdminInterface|null
109 118
      */
110 119
     public function getParent(): ?AdminInterface;
111 120
 
@@ -121,6 +130,7 @@  discard block
 block discarded – undo
121 130
 
122 131
     /**
123 132
      * Returns the related Target Entity.
133
+     * @return string
124 134
      */
125 135
     public function getTargetEntity(): ?string;
126 136
 
@@ -152,11 +162,13 @@  discard block
 block discarded – undo
152 162
      * set the association admin instance (only used if the field is linked to an Admin).
153 163
      *
154 164
      * @param AdminInterface $associationAdmin the associated admin
165
+     * @return void
155 166
      */
156 167
     public function setAssociationAdmin(AdminInterface $associationAdmin);
157 168
 
158 169
     /**
159 170
      * Returns the associated Admin instance (only used if the field is linked to an Admin).
171
+     * @return AdminInterface
160 172
      */
161 173
     public function getAssociationAdmin(): ?AdminInterface;
162 174
 
@@ -174,6 +186,7 @@  discard block
 block discarded – undo
174 186
 
175 187
     /**
176 188
      * set the admin class linked to this FieldDescription.
189
+     * @return void
177 190
      */
178 191
     public function setAdmin(AdminInterface $admin);
179 192
 
@@ -186,11 +199,13 @@  discard block
 block discarded – undo
186 199
      * merge option values related to the provided option name.
187 200
      *
188 201
      * @throws \RuntimeException
202
+     * @return void
189 203
      */
190 204
     public function mergeOption(string $name, array $options = []): void;
191 205
 
192 206
     /**
193 207
      * merge options values.
208
+     * @return void
194 209
      */
195 210
     public function mergeOptions(array $options = []): void;
196 211
 
@@ -198,6 +213,7 @@  discard block
 block discarded – undo
198 213
      * set the original mapping type (only used if the field is linked to an entity).
199 214
      *
200 215
      * @param string|int $mappingType
216
+     * @return void
201 217
      */
202 218
     public function setMappingType($mappingType);
203 219
 
Please login to merge, or discard this patch.
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -957,6 +957,7 @@  discard block
 block discarded – undo
957 957
 
958 958
     /**
959 959
      * NEXT_MAJOR: remove this method.
960
+     * @param string $subClass
960 961
      */
961 962
     public function addSubClass($subClass): void
962 963
     {
@@ -1088,6 +1089,9 @@  discard block
 block discarded – undo
1088 1089
         return $this->routeGenerator->hasAdminRoute($this, $name);
1089 1090
     }
1090 1091
 
1092
+    /**
1093
+     * @param string $adminCode
1094
+     */
1091 1095
     public function isCurrentRoute(string $name, ?string $adminCode = null): bool
1092 1096
     {
1093 1097
         if (!$this->hasRequest()) {
@@ -1342,6 +1346,9 @@  discard block
 block discarded – undo
1342 1346
         return $this->baseControllerName;
1343 1347
     }
1344 1348
 
1349
+    /**
1350
+     * @param string $label
1351
+     */
1345 1352
     public function setLabel(?string $label): void
1346 1353
     {
1347 1354
         $this->label = $label;
@@ -2126,6 +2133,9 @@  discard block
 block discarded – undo
2126 2133
         return $this->managerType;
2127 2134
     }
2128 2135
 
2136
+    /**
2137
+     * @param string $type
2138
+     */
2129 2139
     public function setManagerType(?string $type): void
2130 2140
     {
2131 2141
         $this->managerType = $type;
@@ -2579,6 +2589,7 @@  discard block
 block discarded – undo
2579 2589
 
2580 2590
     /**
2581 2591
      * {@inheritdoc}
2592
+     * @param boolean $isShown
2582 2593
      */
2583 2594
     final public function showMosaicButton($isShown): void
2584 2595
     {
@@ -2726,6 +2737,7 @@  discard block
 block discarded – undo
2726 2737
      * NEXT_MAJOR: remove this method.
2727 2738
      *
2728 2739
      * @deprecated Use configureTabMenu instead
2740
+     * @param string $action
2729 2741
      */
2730 2742
     protected function configureSideMenu(ItemInterface $menu, $action, ?AdminInterface $childAdmin = null): void
2731 2743
     {
Please login to merge, or discard this patch.