ObjectManipulatorTest - Code Metrics - Inspection of "Improve the way we append parent object if any" - sonata-project/SonataAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 3.x (#6171)

by Vincent

created 2020-07-06 19:41 UTC

ObjectManipulatorTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	1
dl	0
loc	88
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	testAddInstance()	12	1
A	testAddInstanceWithParentAssociation()	16	1
A	testAddInstancePlural()	12	1
A	testAddInstanceInflector()	12	1
A	testSetObject()	12	1
A	testSetObjectWithParentAssociation()	16	1

<?php

namespace Sonata\AdminBundle\Tests\Manipulator;

use PHPUnit\Framework\TestCase;
use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
use Sonata\AdminBundle\Manipulator\ObjectManipulator;

class ObjectManipulatorTest extends TestCase
{
    public function testAddInstance(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBar']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);

        $instance = new \stdClass();
        $object = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
        $object->expects($this->once())->method('addFooBar')->with($instance);

        ObjectManipulator::addInstance($object, $instance, $fieldDescription);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testAddInstanceWithParentAssociation(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBar']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([['fieldName' => 'parent']]);

        $instance = new \stdClass();

        $object2 = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
        $object2->expects($this->once())->method('addFooBar')->with($instance);

        $object1 = $this->getMockBuilder(\stdClass::class)->setMethods(['getParent'])->getMock();
        $object1->expects($this->once())->method('getParent')->willReturn($object2);

        ObjectManipulator::addInstance($object1, $instance, $fieldDescription);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testAddInstancePlural(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBars']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);

        $instance = new \stdClass();
        $object = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
        $object->expects($this->once())->method('addFooBar')->with($instance);

        ObjectManipulator::addInstance($object, $instance, $fieldDescription);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testAddInstanceInflector(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'entries']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);

        $instance = new \stdClass();
        $object = $this->getMockBuilder(\stdClass::class)->setMethods(['addEntry'])->getMock();
        $object->expects($this->once())->method('addEntry')->with($instance);

        ObjectManipulator::addInstance($object, $instance, $fieldDescription);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testSetObject(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['mappedBy' => 'parent']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);

        $object = new \stdClass();
        $instance = $this->getMockBuilder(\stdClass::class)->setMethods(['setParent'])->getMock();
        $instance->expects($this->once())->method('setParent')->with($object);

        ObjectManipulator::setObject($instance, $object, $fieldDescription);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testSetObjectWithParentAssociation(): void
    {
        $fieldDescription = $this->createMock(FieldDescriptionInterface::class);
        $fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['mappedBy' => 'fooBar']);
        $fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([['fieldName' => 'parent']]);

        $object2 = new \stdClass();

        $instance = $this->getMockBuilder(\stdClass::class)->setMethods(['setFooBar'])->getMock();
        $instance->expects($this->once())->method('setFooBar')->with($object2);

        $object1 = $this->getMockBuilder(\stdClass::class)->setMethods(['getParent'])->getMock();
        $object1->expects($this->once())->method('getParent')->willReturn($object2);

        ObjectManipulator::setObject($instance, $object1, $fieldDescription);
    }
}


1			<?php
2
3			namespace Sonata\AdminBundle\Tests\Manipulator;
4
5			use PHPUnit\Framework\TestCase;
6			use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
7			use Sonata\AdminBundle\Manipulator\ObjectManipulator;
8
9			class ObjectManipulatorTest extends TestCase
10			{
11			public function testAddInstance(): void
12			{
13			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
14			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBar']);
15			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);
16
17			$instance = new \stdClass();
18			$object = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
19			$object->expects($this->once())->method('addFooBar')->with($instance);
20
21			ObjectManipulator::addInstance($object, $instance, $fieldDescription);
			0 ignored issues – show Documentation introduced 2020-07-06 19:44 UTC by Report Bug Copy Issue Report `$instance` is of type `object<stdClass>`, but the function expects a `object<Sonata\AdminBundle\Manipulator\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
22			}
23
24			public function testAddInstanceWithParentAssociation(): void
25			{
26			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
27			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBar']);
28			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([['fieldName' => 'parent']]);
29
30			$instance = new \stdClass();
31
32			$object2 = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
33			$object2->expects($this->once())->method('addFooBar')->with($instance);
34
35			$object1 = $this->getMockBuilder(\stdClass::class)->setMethods(['getParent'])->getMock();
36			$object1->expects($this->once())->method('getParent')->willReturn($object2);
37
38			ObjectManipulator::addInstance($object1, $instance, $fieldDescription);
			0 ignored issues – show Documentation introduced 2020-07-06 19:44 UTC by Report Bug Copy Issue Report `$instance` is of type `object<stdClass>`, but the function expects a `object<Sonata\AdminBundle\Manipulator\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39			}
40
41			public function testAddInstancePlural(): void
42			{
43			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
44			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'fooBars']);
45			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);
46
47			$instance = new \stdClass();
48			$object = $this->getMockBuilder(\stdClass::class)->setMethods(['addFooBar'])->getMock();
49			$object->expects($this->once())->method('addFooBar')->with($instance);
50
51			ObjectManipulator::addInstance($object, $instance, $fieldDescription);
			0 ignored issues – show Documentation introduced 2020-07-06 19:44 UTC by Report Bug Copy Issue Report `$instance` is of type `object<stdClass>`, but the function expects a `object<Sonata\AdminBundle\Manipulator\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52			}
53
54			public function testAddInstanceInflector(): void
55			{
56			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
57			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['fieldName' => 'entries']);
58			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);
59
60			$instance = new \stdClass();
61			$object = $this->getMockBuilder(\stdClass::class)->setMethods(['addEntry'])->getMock();
62			$object->expects($this->once())->method('addEntry')->with($instance);
63
64			ObjectManipulator::addInstance($object, $instance, $fieldDescription);
			0 ignored issues – show Documentation introduced 2020-07-06 19:44 UTC by Report Bug Copy Issue Report `$instance` is of type `object<stdClass>`, but the function expects a `object<Sonata\AdminBundle\Manipulator\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
65			}
66
67			public function testSetObject(): void
68			{
69			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
70			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['mappedBy' => 'parent']);
71			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([]);
72
73			$object = new \stdClass();
74			$instance = $this->getMockBuilder(\stdClass::class)->setMethods(['setParent'])->getMock();
75			$instance->expects($this->once())->method('setParent')->with($object);
76
77			ObjectManipulator::setObject($instance, $object, $fieldDescription);
			0 ignored issues – show Documentation introduced 2020-07-06 19:44 UTC by Report Bug Copy Issue Report `$object` is of type `object<stdClass>`, but the function expects a `object<Sonata\AdminBundle\Manipulator\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
78			}
79
80			public function testSetObjectWithParentAssociation(): void
81			{
82			$fieldDescription = $this->createMock(FieldDescriptionInterface::class);
83			$fieldDescription->expects($this->once())->method('getAssociationMapping')->willReturn(['mappedBy' => 'fooBar']);
84			$fieldDescription->expects($this->once())->method('getParentAssociationMappings')->willReturn([['fieldName' => 'parent']]);
85
86			$object2 = new \stdClass();
87
88			$instance = $this->getMockBuilder(\stdClass::class)->setMethods(['setFooBar'])->getMock();
89			$instance->expects($this->once())->method('setFooBar')->with($object2);
90
91			$object1 = $this->getMockBuilder(\stdClass::class)->setMethods(['getParent'])->getMock();
92			$object1->expects($this->once())->method('getParent')->willReturn($object2);
93
94			ObjectManipulator::setObject($instance, $object1, $fieldDescription);
95			}
96			}
97

sonata-project / SonataAdminBundle

Pull Request — 3.x (#6171)

ObjectManipulatorTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like