Completed
Pull Request — master (#6093)
by Mathieu
45:35 queued 42:48
created
tests/Form/Widget/FormSonataFilterChoiceWidgetTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -56,6 +56,9 @@
 block discarded – undo
56 56
         );
57 57
     }
58 58
 
59
+    /**
60
+     * @return string
61
+     */
59 62
     protected function getChoiceClass()
60 63
     {
61 64
         return ChoiceType::class;
Please login to merge, or discard this patch.
src/Filter/FilterInterface.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,6 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
     /**
64 64
      * @param string $label
65
+     * @return void
65 66
      */
66 67
     public function setLabel($label);
67 68
 
@@ -72,7 +73,7 @@  discard block
 block discarded – undo
72 73
 
73 74
     /**
74 75
      * @param string     $name
75
-     * @param mixed|null $default
76
+     * @param boolean $default
76 77
      *
77 78
      * @return mixed
78 79
      */
@@ -80,12 +81,14 @@  discard block
 block discarded – undo
80 81
 
81 82
     /**
82 83
      * @param string $name
83
-     * @param mixed  $value
84
+     * @param boolean  $value
85
+     * @return void
84 86
      */
85 87
     public function setOption($name, $value);
86 88
 
87 89
     /**
88 90
      * @param string $name
91
+     * @return void
89 92
      */
90 93
     public function initialize($name, array $options = []);
91 94
 
@@ -129,6 +132,7 @@  discard block
 block discarded – undo
129 132
      *
130 133
      * @param string $name
131 134
      * @param mixed  $value
135
+     * @return void
132 136
      */
133 137
     public function setFieldOption($name, $value);
134 138
 
@@ -155,6 +159,7 @@  discard block
 block discarded – undo
155 159
      * Set the condition to use with the left side of the query : OR or AND.
156 160
      *
157 161
      * @param string $condition
162
+     * @return void
158 163
      */
159 164
     public function setCondition($condition);
160 165
 
Please login to merge, or discard this patch.
src/Form/ChoiceList/ModelChoiceLoader.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -65,6 +65,7 @@
 block discarded – undo
65 65
      * @param string|null $property
66 66
      * @param mixed|null  $query
67 67
      * @param array       $choices
68
+     * @param PropertyAccessorInterface $propertyAccessor
68 69
      */
69 70
     public function __construct(
70 71
         ModelManagerInterface $modelManager,
Please login to merge, or discard this patch.
src/Action/RetrieveAutocompleteItemsAction.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
 use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
18 18
 use Sonata\AdminBundle\Admin\Pool;
19 19
 use Sonata\AdminBundle\Filter\FilterInterface;
20
-use Symfony\Component\Form\Form;
21 20
 use Symfony\Component\HttpFoundation\JsonResponse;
22 21
 use Symfony\Component\HttpFoundation\Request;
23 22
 use Symfony\Component\HttpFoundation\Response;
Please login to merge, or discard this patch.
src/Translator/Extractor/JMSTranslatorBundle/AdminExtractor.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -196,6 +196,11 @@
 block discarded – undo
196 196
         return $id;
197 197
     }
198 198
 
199
+    /**
200
+     * @param string $id
201
+     * @param integer $number
202
+     * @param string $domain
203
+     */
199 204
     public function transChoice($id, $number, array $parameters = [], ?string $domain = null, ?string $locale = null)
200 205
     {
201 206
         $this->addMessage($id, $domain);
Please login to merge, or discard this patch.
src/Admin/BaseFieldDescription.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -131,6 +131,9 @@  discard block
 block discarded – undo
131 131
      */
132 132
     private static $fieldGetters = [];
133 133
 
134
+    /**
135
+     * @param string $fieldName
136
+     */
134 137
     public function setFieldName(?string $fieldName): void
135 138
     {
136 139
         $this->fieldName = $fieldName;
@@ -141,6 +144,9 @@  discard block
 block discarded – undo
141 144
         return $this->fieldName;
142 145
     }
143 146
 
147
+    /**
148
+     * @param string $name
149
+     */
144 150
     public function setName(?string $name): void
145 151
     {
146 152
         $this->name = $name;
@@ -270,6 +276,9 @@  discard block
 block discarded – undo
270 276
         return null !== $this->associationAdmin;
271 277
     }
272 278
 
279
+    /**
280
+     * @param string $fieldName
281
+     */
273 282
     public function getFieldValue(?object $object, ?string $fieldName)
274 283
     {
275 284
         if ($this->isVirtual() || null === $object) {
Please login to merge, or discard this patch.
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -586,6 +586,10 @@
 block discarded – undo
586 586
         $this->admin->setShowBuilder(new ShowBuilder());
587 587
     }
588 588
 
589
+    /**
590
+     * @param string $name
591
+     * @param string $label
592
+     */
589 593
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
590 594
     {
591 595
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Datagrid/DatagridMapper.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -44,6 +44,8 @@
 block discarded – undo
44 44
 
45 45
     /**
46 46
      * @param FieldDescriptionInterface|string $name
47
+     * @param string $type
48
+     * @param string $fieldType
47 49
      *
48 50
      * @throws \LogicException
49 51
      */
Please login to merge, or discard this patch.
src/Twig/Extension/SonataAdminExtension.php 1 patch
Doc Comments   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     /**
183 183
      * render a view element.
184 184
      *
185
-     * @param object $object
185
+     * @param \stdClass $object
186 186
      *
187 187
      * @return string
188 188
      */
@@ -221,8 +221,8 @@  discard block
 block discarded – undo
221 221
     /**
222 222
      * render a compared view element.
223 223
      *
224
-     * @param mixed $baseObject
225
-     * @param mixed $compareObject
224
+     * @param \stdClass $baseObject
225
+     * @param \stdClass $compareObject
226 226
      *
227 227
      * @return string
228 228
      */
@@ -343,7 +343,8 @@  discard block
 block discarded – undo
343 343
     /**
344 344
      * Get the identifiers as a string that is safe to use in a url.
345 345
      *
346
-     * @param object $model
346
+     * @param \stdClass $model
347
+     * @param AdminInterface $admin
347 348
      *
348 349
      * @return string string representation of the id that is safe to use in a url
349 350
      */
@@ -365,7 +366,7 @@  discard block
 block discarded – undo
365 366
     }
366 367
 
367 368
     /**
368
-     * @return string|bool
369
+     * @return string|false
369 370
      */
370 371
     public function getXEditableType($type)
371 372
     {
Please login to merge, or discard this patch.