Completed
Push — 3.x ( 3d5935...36902d )
by Jordi Sala
02:59
created
src/Form/ChoiceList/ModelChoiceLoader.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -65,6 +65,7 @@
 block discarded – undo
65 65
      * @param string|null $property
66 66
      * @param mixed|null  $query
67 67
      * @param array       $choices
68
+     * @param PropertyAccessorInterface $propertyAccessor
68 69
      */
69 70
     public function __construct(
70 71
         ModelManagerInterface $modelManager,
Please login to merge, or discard this patch.
src/Security/Handler/AclSecurityHandler.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -184,6 +184,9 @@
 block discarded – undo
184 184
         return $acls;
185 185
     }
186 186
 
187
+    /**
188
+     * @param UserSecurityIdentity $securityIdentity
189
+     */
187 190
     public function addObjectOwner(AclInterface $acl, ?UserSecurityIdentity $securityIdentity = null)
188 191
     {
189 192
         if (false === $this->findClassAceIndexByUsername($acl, $securityIdentity->getUsername())) {
Please login to merge, or discard this patch.
src/Util/AdminObjectAclData.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -80,6 +80,7 @@
 block discarded – undo
80 80
     /**
81 81
      * @param object $object
82 82
      * @param string $maskBuilderClass
83
+     * @param \Traversable $aclRoles
83 84
      */
84 85
     public function __construct(
85 86
         AdminInterface $admin,
Please login to merge, or discard this patch.
src/Menu/Matcher/Voter/AdminVoter.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -38,6 +38,9 @@  discard block
 block discarded – undo
38 38
      */
39 39
     private $request;
40 40
 
41
+    /**
42
+     * @param RequestStack $requestStack
43
+     */
41 44
     public function __construct(?RequestStack $requestStack = null)
42 45
     {
43 46
         $this->requestStack = $requestStack;
@@ -46,6 +49,7 @@  discard block
 block discarded – undo
46 49
     /**
47 50
      * @deprecated since sonata-project/admin-bundle 3.31. Pass a RequestStack to the constructor instead.
48 51
      *
52
+     * @param Request $request
49 53
      * @return $this
50 54
      */
51 55
     public function setRequest($request)
Please login to merge, or discard this patch.
src/Action/RetrieveAutocompleteItemsAction.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
 use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
18 18
 use Sonata\AdminBundle\Admin\Pool;
19 19
 use Sonata\AdminBundle\Filter\FilterInterface;
20
-use Symfony\Component\Form\Form;
21 20
 use Symfony\Component\HttpFoundation\JsonResponse;
22 21
 use Symfony\Component\HttpFoundation\Request;
23 22
 use Symfony\Component\HttpFoundation\Response;
Please login to merge, or discard this patch.
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -586,6 +586,10 @@
 block discarded – undo
586 586
         $this->admin->setShowBuilder(new ShowBuilder());
587 587
     }
588 588
 
589
+    /**
590
+     * @param string $name
591
+     * @param string $label
592
+     */
589 593
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
590 594
     {
591 595
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Twig/Extension/SonataAdminExtension.php 1 patch
Doc Comments   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
     /**
185 185
      * render a list element from the FieldDescription.
186 186
      *
187
-     * @param object $object
187
+     * @param \stdClass $object
188 188
      * @param array  $params
189 189
      *
190 190
      * @return string
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
     /**
273 273
      * render a view element.
274 274
      *
275
-     * @param object $object
275
+     * @param \stdClass $object
276 276
      *
277 277
      * @return string
278 278
      */
@@ -311,8 +311,8 @@  discard block
 block discarded – undo
311 311
     /**
312 312
      * render a compared view element.
313 313
      *
314
-     * @param mixed $baseObject
315
-     * @param mixed $compareObject
314
+     * @param \stdClass $baseObject
315
+     * @param \stdClass $compareObject
316 316
      *
317 317
      * @return string
318 318
      */
@@ -433,7 +433,8 @@  discard block
 block discarded – undo
433 433
     /**
434 434
      * Get the identifiers as a string that is safe to use in a url.
435 435
      *
436
-     * @param object $model
436
+     * @param \stdClass $model
437
+     * @param AdminInterface $admin
437 438
      *
438 439
      * @return string string representation of the id that is safe to use in a url
439 440
      */
@@ -455,7 +456,7 @@  discard block
 block discarded – undo
455 456
     }
456 457
 
457 458
     /**
458
-     * @return string|bool
459
+     * @return string|false
459 460
      */
460 461
     public function getXEditableType($type)
461 462
     {
Please login to merge, or discard this patch.
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -414,6 +414,10 @@
 block discarded – undo
414 414
         );
415 415
     }
416 416
 
417
+    /**
418
+     * @param string $name
419
+     * @param string $label
420
+     */
417 421
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
418 422
     {
419 423
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Admin/AdminInterface.php 1 patch
Doc Comments   +76 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,6 +49,9 @@  discard block
 block discarded – undo
49 49
  */
50 50
 interface AdminInterface extends AccessRegistryInterface, FieldDescriptionRegistryInterface, LifecycleHookProviderInterface, MenuBuilderInterface, ParentAdminInterface, UrlGeneratorInterface
51 51
 {
52
+    /**
53
+     * @return void
54
+     */
52 55
     public function setMenuFactory(MenuFactoryInterface $menuFactory);
53 56
 
54 57
     /**
@@ -56,8 +59,14 @@  discard block
 block discarded – undo
56 59
      */
57 60
     public function getMenuFactory();
58 61
 
62
+    /**
63
+     * @return void
64
+     */
59 65
     public function setFormContractor(FormContractorInterface $formContractor);
60 66
 
67
+    /**
68
+     * @return void
69
+     */
61 70
     public function setListBuilder(ListBuilderInterface $listBuilder);
62 71
 
63 72
     /**
@@ -65,6 +74,9 @@  discard block
 block discarded – undo
65 74
      */
66 75
     public function getListBuilder();
67 76
 
77
+    /**
78
+     * @return void
79
+     */
68 80
     public function setDatagridBuilder(DatagridBuilderInterface $datagridBuilder);
69 81
 
70 82
     /**
@@ -72,6 +84,9 @@  discard block
 block discarded – undo
72 84
      */
73 85
     public function getDatagridBuilder();
74 86
 
87
+    /**
88
+     * @return void
89
+     */
75 90
     public function setTranslator(TranslatorInterface $translator);
76 91
 
77 92
     /**
@@ -79,8 +94,14 @@  discard block
 block discarded – undo
79 94
      */
80 95
     public function getTranslator();
81 96
 
97
+    /**
98
+     * @return void
99
+     */
82 100
     public function setRequest(Request $request);
83 101
 
102
+    /**
103
+     * @return void
104
+     */
84 105
     public function setConfigurationPool(Pool $pool);
85 106
 
86 107
     /**
@@ -93,6 +114,9 @@  discard block
 block discarded – undo
93 114
      */
94 115
     public function getClass();
95 116
 
117
+    /**
118
+     * @return void
119
+     */
96 120
     public function attachAdminClass(FieldDescriptionInterface $fieldDescription);
97 121
 
98 122
     /**
@@ -104,6 +128,7 @@  discard block
 block discarded – undo
104 128
      * Set base controller name.
105 129
      *
106 130
      * @param string $baseControllerName
131
+     * @return void
107 132
      */
108 133
     public function setBaseControllerName($baseControllerName);
109 134
 
@@ -178,6 +203,9 @@  discard block
 block discarded – undo
178 203
      */
179 204
     public function getSecurityInformation();
180 205
 
206
+    /**
207
+     * @return void
208
+     */
181 209
     public function setParentFieldDescription(FieldDescriptionInterface $parentFieldDescription);
182 210
 
183 211
     /**
@@ -225,6 +253,9 @@  discard block
 block discarded – undo
225 253
      */
226 254
     public function hasRoute($name);
227 255
 
256
+    /**
257
+     * @return void
258
+     */
228 259
     public function setSecurityHandler(SecurityHandlerInterface $securityHandler);
229 260
 
230 261
     /**
@@ -252,12 +283,13 @@  discard block
 block discarded – undo
252 283
      *
253 284
      * @param object $model
254 285
      *
255
-     * @return mixed
286
+     * @return string
256 287
      */
257 288
     public function id($model);
258 289
 
259 290
     /**
260 291
      * @param ValidatorInterface $validator
292
+     * @return void
261 293
      */
262 294
     public function setValidator($validator);
263 295
 
@@ -274,6 +306,9 @@  discard block
 block discarded – undo
274 306
 //    NEXT_MAJOR: uncomment this method in 4.0
275 307
 //    public function getList(): ?FieldDescriptionCollection;
276 308
 
309
+    /**
310
+     * @return void
311
+     */
277 312
     public function setFormTheme(array $formTheme);
278 313
 
279 314
     /**
@@ -281,6 +316,9 @@  discard block
 block discarded – undo
281 316
      */
282 317
     public function getFormTheme();
283 318
 
319
+    /**
320
+     * @return void
321
+     */
284 322
     public function setFilterTheme(array $filterTheme);
285 323
 
286 324
     /**
@@ -288,6 +326,9 @@  discard block
 block discarded – undo
288 326
      */
289 327
     public function getFilterTheme();
290 328
 
329
+    /**
330
+     * @return void
331
+     */
291 332
     public function addExtension(AdminExtensionInterface $extension);
292 333
 
293 334
     /**
@@ -297,6 +338,9 @@  discard block
 block discarded – undo
297 338
      */
298 339
     public function getExtensions();
299 340
 
341
+    /**
342
+     * @return void
343
+     */
300 344
     public function setRouteBuilder(RouteBuilderInterface $routeBuilder);
301 345
 
302 346
     /**
@@ -311,6 +355,9 @@  discard block
 block discarded – undo
311 355
      */
312 356
     public function toString($object);
313 357
 
358
+    /**
359
+     * @return void
360
+     */
314 361
     public function setLabelTranslatorStrategy(LabelTranslatorStrategyInterface $labelTranslatorStrategy);
315 362
 
316 363
     /**
@@ -334,6 +381,7 @@  discard block
 block discarded – undo
334 381
 
335 382
     /**
336 383
      * @param string $uniqId
384
+     * @return void
337 385
      */
338 386
     public function setUniqid($uniqId);
339 387
 
@@ -353,6 +401,7 @@  discard block
 block discarded – undo
353 401
 
354 402
     /**
355 403
      * @param object|null $subject
404
+     * @return void
356 405
      */
357 406
     public function setSubject($subject);
358 407
 
@@ -390,7 +439,7 @@  discard block
 block discarded – undo
390 439
      *
391 440
      * Returns the collection of list FieldDescriptions.
392 441
      *
393
-     * @return array
442
+     * @return FieldDescriptionInterface[]
394 443
      */
395 444
     public function getListFieldDescriptions();
396 445
 
@@ -408,6 +457,9 @@  discard block
 block discarded – undo
408 457
      */
409 458
     public function getDataSourceIterator();
410 459
 
460
+    /**
461
+     * @return void
462
+     */
411 463
     public function configure();
412 464
 
413 465
     /**
@@ -415,6 +467,7 @@  discard block
 block discarded – undo
415 467
      *
416 468
      * @param string $actionName
417 469
      * @param bool   $allElements
470
+     * @return void
418 471
      */
419 472
     public function preBatchAction($actionName, ProxyQueryInterface $query, array &$idx, $allElements);
420 473
 
@@ -439,6 +492,7 @@  discard block
 block discarded – undo
439 492
      *
440 493
      * @deprecated this feature cannot be stable, use a custom validator,
441 494
      *             the feature will be removed with Symfony 2.2
495
+     * @return void
442 496
      */
443 497
     public function validate(ErrorElement $errorElement, $object);
444 498
 
@@ -453,6 +507,7 @@  discard block
 block discarded – undo
453 507
      * Add object security, fe. make the current user owner of the object.
454 508
      *
455 509
      * @param object $object
510
+     * @return void
456 511
      */
457 512
     public function createObjectSecurity($object);
458 513
 
@@ -461,6 +516,9 @@  discard block
 block discarded – undo
461 516
      */
462 517
     public function getParent();
463 518
 
519
+    /**
520
+     * @return void
521
+     */
464 522
     public function setParent(self $admin);
465 523
 
466 524
     /**
@@ -485,6 +543,7 @@  discard block
 block discarded – undo
485 543
      * Set the translation domain.
486 544
      *
487 545
      * @param string $translationDomain the translation domain
546
+     * @return void
488 547
      */
489 548
     public function setTranslationDomain($translationDomain);
490 549
 
@@ -506,6 +565,7 @@  discard block
 block discarded – undo
506 565
 
507 566
     /**
508 567
      * Set the form groups.
568
+     * @return void
509 569
      */
510 570
     public function setFormGroups(array $formGroups);
511 571
 
@@ -514,6 +574,9 @@  discard block
 block discarded – undo
514 574
      */
515 575
     public function getFormTabs();
516 576
 
577
+    /**
578
+     * @return void
579
+     */
517 580
     public function setFormTabs(array $formTabs);
518 581
 
519 582
     /**
@@ -521,12 +584,16 @@  discard block
 block discarded – undo
521 584
      */
522 585
     public function getShowTabs();
523 586
 
587
+    /**
588
+     * @return void
589
+     */
524 590
     public function setShowTabs(array $showTabs);
525 591
 
526 592
     /**
527 593
      * Remove a form group field.
528 594
      *
529 595
      * @param string $key
596
+     * @return void
530 597
      */
531 598
     public function removeFieldFromFormGroup($key);
532 599
 
@@ -541,6 +608,7 @@  discard block
 block discarded – undo
541 608
 
542 609
     /**
543 610
      * Set the show groups.
611
+     * @return void
544 612
      */
545 613
     public function setShowGroups(array $showGroups);
546 614
 
@@ -548,6 +616,7 @@  discard block
 block discarded – undo
548 616
      * Reorder items in showGroup.
549 617
      *
550 618
      * @param string $group
619
+     * @return void
551 620
      */
552 621
     public function reorderShowGroup($group, array $keys);
553 622
 
@@ -557,6 +626,7 @@  discard block
 block discarded – undo
557 626
      * add a FieldDescription.
558 627
      *
559 628
      * @param string $name
629
+     * @return void
560 630
      */
561 631
     public function addFormFieldDescription($name, FieldDescriptionInterface $fieldDescription);
562 632
 
@@ -566,6 +636,7 @@  discard block
 block discarded – undo
566 636
      * Remove a FieldDescription.
567 637
      *
568 638
      * @param string $name
639
+     * @return void
569 640
      */
570 641
     public function removeFormFieldDescription($name);
571 642
 
@@ -578,6 +649,7 @@  discard block
 block discarded – undo
578 649
 
579 650
     /**
580 651
      * Sets the list of supported sub classes.
652
+     * @return void
581 653
      */
582 654
     public function setSubClasses(array $subClasses);
583 655
 
@@ -646,6 +718,7 @@  discard block
 block discarded – undo
646 718
      * Set the current child status.
647 719
      *
648 720
      * @param bool $currentChild
721
+     * @return void
649 722
      */
650 723
     public function setCurrentChild($currentChild);
651 724
 
@@ -695,6 +768,7 @@  discard block
 block discarded – undo
695 768
 
696 769
     /**
697 770
      * @param string $mode
771
+     * @return void
698 772
      */
699 773
     public function setListMode($mode);
700 774
 
Please login to merge, or discard this patch.