somework /
offset-page
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 14 | class SourceResultCallbackAdapter implements SourceResultInterface |
||
| 15 | { |
||
| 16 | /** |
||
| 17 | * @var callable |
||
| 18 | */ |
||
| 19 | private $callback; |
||
| 20 | |||
| 21 | /** |
||
| 22 | * @var int |
||
| 23 | */ |
||
| 24 | private $totalCount; |
||
| 25 | |||
| 26 | public function __construct(callable $callback, $totalCount) |
||
| 31 | |||
| 32 | /** |
||
| 33 | * @throws \RuntimeException |
||
| 34 | * |
||
| 35 | * @return \Generator |
||
| 36 | */ |
||
| 37 | View Code Duplication | public function generator() |
|
|
|
|||
| 38 | { |
||
| 39 | $result = call_user_func($this->callback); |
||
| 40 | if (!is_object($result) || !$result instanceof \Generator) { |
||
| 41 | throw new \UnexpectedValueException('Callback result should return Generator'); |
||
| 42 | } |
||
| 43 | |||
| 44 | return $result; |
||
| 45 | } |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @return int |
||
| 49 | */ |
||
| 50 | public function getTotalCount() |
||
| 54 | } |
||
| 55 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.