RequestException::__construct() - Code Metrics - Inspection of "Make the error handling more robust" - solutionDrive/HipchatAPIv2Client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#18)

unknown

created 2018-02-26 02:35 UTC

RequestException::__construct() C

↳ Parent: RequestException

Complexity

Conditions	7
Paths	18

Size

Total Lines	23
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	7.0099

Importance

Changes

Metric	Value
cc	7
eloc	16
nc	18
nop	1
dl	0
loc	23
ccs	16
cts	17
cp	0.9412
crap	7.0099
rs	6.7272
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: gorkalaucirica
 * Date: 09/07/14
 * Time: 12:33
 */

namespace SolutionDrive\HipchatAPIv2Client\Exception;


class RequestException extends \Exception implements RequestExceptionInterface
{
    protected $responseCode;

    protected $message;

    protected $type;

    /**
     * Request exception constructor
     *
     * @param string $response json_decoded array with the error response given by the server
     */
    public function __construct($response)
    {
        $message = '';
        $code = null;
        $type = null;
        if (is_string($response)) {

            $message = $response;
        } elseif (is_array($response)) {
            $error = isset($response['error']) ? $response['error'] : '';
            if (isset($error['code'])) {
                $code = $error['code'];
            }
            if (isset($error['message'])) {
                $message = $error['message'];
            }
            if (isset($error['type'])) {
                $type = $error['type'];
            }
        }

        $this->responseCode = $code;
        $this->type = $type;
        parent::__construct($message, $code);
    }

    /**
     * @inheritdoc
     */
    public function getResponseCode()
    {
        return $this->responseCode;
    }

    /**
     * @inheritdoc
     */
    public function getType()
    {
        return $this->type;
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: gorkalaucirica
5		* Date: 09/07/14
6		* Time: 12:33
7		*/
8
9		namespace SolutionDrive\HipchatAPIv2Client\Exception;
10
11
12		class RequestException extends \Exception implements RequestExceptionInterface
13		{
14		protected $responseCode;
15
16		protected $message;
17
18		protected $type;
19
20		/**
21		* Request exception constructor
22		*
23		* @param string $response json_decoded array with the error response given by the server
24		*/
25	4	public function __construct($response)
26		{
27	4	$message = '';
28	4	$code = null;
29	4	$type = null;
30	4	if (is_string($response)) {
		0 ignored issues – show introduced 2018-02-26 02:38 UTC by Report Bug Copy Issue Report The condition `is_string($response)` can never be `false`. Loading history...
31		$message = $response;
32	4	} elseif (is_array($response)) {
33	4	$error = isset($response['error']) ? $response['error'] : '';
34	4	if (isset($error['code'])) {
35	4	$code = $error['code'];
36		}
37	4	if (isset($error['message'])) {
38	4	$message = $error['message'];
39		}
40	4	if (isset($error['type'])) {
41	4	$type = $error['type'];
42		}
43		}
44
45	4	$this->responseCode = $code;
46	4	$this->type = $type;
47	4	parent::__construct($message, $code);
48	4	}
49
50		/**
51		* @inheritdoc
52		*/
53	1	public function getResponseCode()
54		{
55	1	return $this->responseCode;
56		}
57
58		/**
59		* @inheritdoc
60		*/
61	1	public function getType()
62		{
63	1	return $this->type;
64		}
65		}
66

solutionDrive / HipchatAPIv2Client

Pull Request — master (#18)

RequestException::__construct() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like