PlatformNullFile - Code Metrics - Inspection of "Prep 0.7.5" - soluble-io/soluble-mediatools - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 12954f...f40466 )

by Sébastien

created 2018-08-16 10:09 UTC

PlatformNullFile A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	9
eloc	25
dl	0
loc	59
ccs	20
cts	20
cp	1
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	getCurrentPlatform()	4	2
A	__construct()	13	3
A	getNullFile()	11	3
A	getFile()	3	1

<?php

declare(strict_types=1);

namespace Soluble\MediaTools\Common\IO;

use Soluble\MediaTools\Common\Exception\InvalidArgumentException;

class PlatformNullFile implements UnescapedFileInterface
{
    public const PLATFORM_LINUX = 'LINUX';
    public const PLATFORM_WIN   = 'WINDOWS';

    public const SUPPORTED_PLATFORMS = [
        self::PLATFORM_LINUX,
        self::PLATFORM_WIN,
    ];

    /** @var string $platform if null platform wil be auto detected */
    protected $platform;

    /**
     * @param null|string $platform if null platform will be autodetected
     *
     * @throws InvalidArgumentException
     */
    public function __construct(?string $platform = null)
    {
        if ($platform === null) {
            $platform = self::getCurrentPlatform();
        } else {
            if (!in_array(mb_strtoupper($platform), self::SUPPORTED_PLATFORMS, true)) {
                throw new InvalidArgumentException(sprintf(
                    'Platform \'%s\' is not supported',
                    $platform
                ));
            }
        }
        $this->platform = mb_strtoupper($platform);
    }

    public static function getCurrentPlatform(): string
    {
        return defined('PHP_WINDOWS_VERSION_MAJOR')
                    ? self::PLATFORM_WIN : self::PLATFORM_LINUX;
    }

    /**
     * Return /dev/null on linux/unix/mac or NUL on windows.
     */
    public function getNullFile(?string $platform = null): string
    {
        $platform = $platform ?? $this->platform;

        switch ($platform) {
            case self::PLATFORM_WIN:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                return 'NUL';
            // All others for now
            case self::PLATFORM_LINUX:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
            default:
                return '/dev/null';
        }
    }

    public function getFile(): string
    {
        return $this->getNullFile();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Soluble\MediaTools\Common\IO;
6
7		use Soluble\MediaTools\Common\Exception\InvalidArgumentException;
8
9		class PlatformNullFile implements UnescapedFileInterface
10		{
11		public const PLATFORM_LINUX = 'LINUX';
12		public const PLATFORM_WIN = 'WINDOWS';
13
14		public const SUPPORTED_PLATFORMS = [
15		self::PLATFORM_LINUX,
16		self::PLATFORM_WIN,
17		];
18
19		/** @var string $platform if null platform wil be auto detected */
20		protected $platform;
21
22		/**
23		* @param null\|string $platform if null platform will be autodetected
24		*
25		* @throws InvalidArgumentException
26		*/
27	5	public function __construct(?string $platform = null)
28		{
29	5	if ($platform === null) {
30	3	$platform = self::getCurrentPlatform();
31		} else {
32	2	if (!in_array(mb_strtoupper($platform), self::SUPPORTED_PLATFORMS, true)) {
33	1	throw new InvalidArgumentException(sprintf(
34	1	'Platform \'%s\' is not supported',
35	1	$platform
36		));
37		}
38		}
39	4	$this->platform = mb_strtoupper($platform);
40	4	}
41
42	3	public static function getCurrentPlatform(): string
43		{
44	3	return defined('PHP_WINDOWS_VERSION_MAJOR')
45	3	? self::PLATFORM_WIN : self::PLATFORM_LINUX;
46		}
47
48		/**
49		* Return /dev/null on linux/unix/mac or NUL on windows.
50		*/
51	4	public function getNullFile(?string $platform = null): string
52		{
53	4	$platform = $platform ?? $this->platform;
54
55		switch ($platform) {
56	4	case self::PLATFORM_WIN:
		0 ignored issues – show Coding Style introduced 2018-08-16 10:11 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
57	1	return 'NUL';
58		// All others for now
59	4	case self::PLATFORM_LINUX:
		0 ignored issues – show Coding Style introduced 2018-08-16 10:11 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
60		default:
61	4	return '/dev/null';
62		}
63		}
64
65	3	public function getFile(): string
66		{
67	3	return $this->getNullFile();
68		}
69		}
70

soluble-io / soluble-mediatools

Push — master ( 12954f...f40466 )

PlatformNullFile A

Complexity

Size/Duplication

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like