Soleo\UrlShortener\Shorty

Complexity

Total Complexity

18

Size/Duplication

Total Lines	117
Duplicated Lines	10.26 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getShortUrl()	0	21	3
A	getLongUrl()	0	9	1
A	generateId()	0	6	1
C	alphaID()	12	68	12

<?php

namespace Soleo\UrlShortener;

class Shorty
{
    private $conn;

    public function __construct(ConnectionInterface $conn)
    {
        $this->conn = $conn;
    }

    public function getShortUrl($longURL)
    {
        // validate Long URL first and normalize it
        if (strlen($longURL) <= 3) {
            throw new \InvalidArgumentException("URL is malformated!");
        }
        $currentDomain = "localhost";
        // Lookup
        $slug = $this->conn->reverseLookup($longURL);

        $fullURL = 'http://'.$currentDomain.'/';
        if ($slug) {
            return $fullURL.$slug;
        } else {
            // add new records to DB
            $slug = $this->generateId($longURL);
            var_dump($slug);

var_dump($slug); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

            $this->conn->addNewRecord($longURL, $slug);
            return $fullURL.$slug;
        }
    }

    public function getLongUrl($slug)
    {
        // filter out invalid string
       $slug = preg_replace('[^A_Za_z0-9]', '', $slug);

        $longURL = $this->conn->lookup($slug);

The call to lookup() misses a required argument $update.

        return $longURL;
    }

    private function generateId($longURL)

The parameter $longURL is not used and could be removed.

    {
        $url_num_id = $this->conn->getIncrementUid();
        $slug = $this->alphaID($url_num_id);
        return $slug;
    }

    private function alphaID($in, $to_num = false, $pad_up = 3, $passKey = "prephe.ro")
    {
        $index = "abcdefghijklmnopqrstuvwxyz0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";
        if ($passKey !== null) {
            // Although this function's purpose is to just make the
            // ID short - and not so much secure,
            // with this patch by Simon Franz (http://blog.snaky.org/)
            // you can optionally supply a password to make it harder
            // to calculate the corresponding numeric ID

            for ($n = 0; $n<strlen($index); $n++) {
                $i[] = substr($index, $n, 1);

$i was never initialized. Although not strictly required by PHP, it is generally a good practice to add $i = array(); before regardless.

            }

            $passhash = hash('sha256', $passKey);
            $passhash = (strlen($passhash) < strlen($index))
                ? hash('sha512', $passKey)
                : $passhash;

            for ($n=0; $n < strlen($index); $n++) {
                $p[] =  substr($passhash, $n, 1);

$p was never initialized. Although not strictly required by PHP, it is generally a good practice to add $p = array(); before regardless.

            }

            array_multisort($p,  SORT_DESC, $i);

The variable $i does not seem to be defined for all execution paths leading up to this point.

            $index = implode($i);
        }

        $base  = strlen($index);

        if ($to_num) {
            // Digital number  <<--  alphabet letter code
            $in  = strrev($in);
            $out = 0;
            $len = strlen($in) - 1;
            for ($t = 0; $t <= $len; $t++) {
                $bcpow = bcpow($base, $len - $t);
                $out   = $out + strpos($index, substr($in, $t, 1)) * $bcpow;
            }

            if (is_numeric($pad_up)) {

This code seems to be duplicated across your project.

                $pad_up--;
                if ($pad_up > 0) {
                    $out -= pow($base, $pad_up);
                }
            }
            $out = sprintf('%F', $out);
            $out = substr($out, 0, strpos($out, '.'));
        } else {
            // Digital number  -->>  alphabet letter code
            if (is_numeric($pad_up)) {

This code seems to be duplicated across your project.

                $pad_up--;
                if ($pad_up > 0) {
                    $in += pow($base, $pad_up);
                }
            }

            $out = "";
            for ($t = floor(log($in, $base)); $t >= 0; $t--) {
                $bcp = bcpow($base, $t);
                $a   = floor($in / $bcp) % $base;
                $out = $out . substr($index, $a, 1);
                $in  = $in - ($a * $bcp);
            }
            $out = strrev($out); // reverse
        }

        return $out;
    }
}