Soleo\UrlShortener\MongoConnection

Complexity

Total Complexity

12

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	lookup()	0	18	3
B	reverseLookup()	0	24	3
A	addNewRecord()	0	8	1
A	getIncrementUid()	0	15	4

<?php

namespace Soleo\UrlShortener;

use \MongoClient;

class MongoConnection implements ConnectionInterface
{

    private $client;
    private $DB;
    public function __construct($config)
    {
        $options = array("connectTimeoutMS" => 30000);
        $this->client = new MongoClient($config, $options);
        $this->DB = $this->client->selectDB("url_shortener");
    }

    public function lookup($slug, $update = false)
    {
        $c_db = $this->DB;
        $c_table = $c_db->selectCollection("url_table");
        $c_table->ensureIndex(array('shorturl' => 1 ), array('unique' => true));
        $urls = $c_table->findOne(array('shorturl' => $slug), array('longurl', '_id'));
        if ($urls) {
            if ($update) {
                $c_table->ensureIndex(array('hits' => 1 ));
                $c_table->update(array("_id" => $urls['_id']), array('$inc' => array("hits" => 1)));
                $days = floor(time()/24/3600);
                $c_table->update(array("_id" => $urls['_id']), array('$inc' => array("hits_d.{$days}" => 1)));
            }
            return $urls['longurl'];
        } else {
            return false;
        }
    }

    public function reverseLookup($longUrl)
    {
        // If stored, return the slug, otherwise, return false

37% of this comment could be valid code. Did you maybe forget this after debugging?

        /*
         * mongodb
         * {
         *   shorturl
         *   longurl
         * }
         */

        $c_db = $this->DB;

        // check if url already exists
        $c_table = $c_db->selectCollection("url_table");
        $c_table->ensureIndex(array('longurl' => 1 ), array('unique' => true));
        $c_table->ensureIndex(array('shorturl' => 1 ), array('unique' => true));
        $shorturl = $c_table->findOne(array('longurl' => $longUrl), array('shorturl'));
        if ($shorturl && $shorturl['shorturl']) {
            return $shorturl['shorturl'];
        } else {
            return false;
        }
    }

    public function addNewRecord($longUrl, $slug)
    {
        $c_db = $this->DB;
        $c_table = $c_db->selectCollection("url_table");

        $c_table->insert(array("shorturl" => $slug, "longurl" => $longUrl));
        return $slug;
    }

    public function getIncrementUid()
    {
        // generate increment unique id
        $collection_name = 'increment_id';
        $unique_field =  'section';
        $data_field = 'url_id';

        $c_inc = $this->DB->selectCollection($collection_name);
        $c_inc->ensureIndex(array($unique_field => 1), array('unique' => true));
        $ret = $this->DB->command(array("findandmodify" => "increment_id", "query" => array($unique_field => $data_field),
                                                  "update" => array('$inc' => array($data_field => 1)), "upsert" => true ));
        if ($ret && $ret['value'] && $ret['value'][$data_field]) {

The expression $ret of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $ret['value'][$data_field];
        }
    }
}