PageLegacyData - Code Metrics - Inspection of "chore(composer.json): update dependency for cssmin" - solcre/columnis-express - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4d741c...e56791 )

unknown

created 2017-01-31 17:38 UTC

PageLegacyData A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	197
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	32
lcom	1
cbo	0
dl	0
loc	197
rs	9.6
c	0
b	0
f	0

10 Methods

Rating	Name	Size	Complexity
A	setData()	3	1
A	__construct()	3	1
D	getData()	44	9
A	processPageData()	10	2
A	processMenuData()	16	3
A	processConfigurationData()	15	1
A	processTranslationsData()	16	4
A	processSectionsData()	16	3
B	processBannersData()	36	6
A	processPictureData()	15	2

<?php

namespace Columnis\Model;

class PageLegacyData {

    /**
     *
     * @var array 
     */
    protected $data;

    public function setData($data) {
        $this->data = $data;
    }

    public function __construct($data) {
        $this->data = $data;
    }

    /**
     * Get legacy data
     * 
     * @return array
     */
    public function getData() {
        $legacyData = [
            "sitio" => [
                "traducciones" => [],
                "traducciones_json" => [],
                "menus" => [],
                "datos_fecha" => [],
                "images_path" => '',
                "idiomas" => [],
                "sitelink" => '',
                "head" => [],
            ],
            "modulos" => [],
            "pagina" => [],
        ];

        if(is_array($this->data)) {
            foreach($this->data as $key => $value) {

                switch($key) {
                    case 'columnis.rest.pages':
                        $this->processPageData(array_values($value)[0], $legacyData['pagina']);
                        break;
                    case 'columnis.rest.menu_items':
                        $this->processMenuData(array_values($value)[0], $legacyData['sitio']['menus'][0]);
                        break;
                    case 'columnis.rest.configuration':
                        $this->processConfigurationData(array_values($value)[0], $legacyData);
                        break;
                    case 'columnis.rest.translations':
                        $this->processTranslationsData(array_values($value)[0], $legacyData);
                        break;
                    case 'columnis.rest.sections':
                        $this->processSectionsData($value, $legacyData['modulos']);
                        break;
                    case 'columnis.rest.banners':
                        $this->processBannersData($value, $legacyData['modulos']);
                        break;
                }
            }
        }

        return $legacyData;
    }

    protected function processPageData($value, &$pageData) {

        if(!empty($value)) {
            $pageData['idPagina'] = $value['id'];
            $pageData['template'] = $value['template'];
            $pageData['tituloPagina'] = $value['text'];
            $pageData['description'] = $value['description'];
            $pageData['keywords'] = $value['keywords'];
        }
    }

    protected function processMenuData($values, &$menusData) {
        $menusData = [
            'vinculos' => []
        ];

        if(is_array($values["_embedded"]["menu_items"])) {
            foreach($values["_embedded"]["menu_items"] as $menu) {
                $menusData['vinculos'][] = [
                    "id" => $menu['id'],
                    "texto" => $menu['text'],
                    "target" => $menu['target'],
                    "anclaje" => $menu['anchorage'],
                ];
            }
        }
    }

    protected function processConfigurationData($values, &$data) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

        $data["sitio"]["images_path"] = $values["imagesDomain"];

        $data["sitio"]["head"] = [
            "fixed" => [
                "title" => $values["title"],
                "keywords" => $values["keywords"],
                "description" => $values["description"]
            ],
            "analytics" => $values["analyticsAccountIds"]
        ];

        $data["sitio"]["sitelink"] = $_SERVER['SERVER_NAME'];
    }

    protected function processTranslationsData($values, &$data) {
        $translations = [];

        if(is_array($values["_embedded"]["translations"])) {
            foreach($values["_embedded"]["translations"] as $translation) {

                if($translation["languageId"] === "es") {
                    $translations = $translation["translations"];
                    break;
                }
            }
        }

        $data["sitio"]["traducciones"] = $translations;
        $data["sitio"]["traducciones_json"] = json_encode($translations);
    }

    protected function processSectionsData($values, &$modulesData) {
        if(!array_key_exists("secciones", $modulesData)) {
            $modulesData["secciones"] = [];
        };

        foreach($values as $route => $data) {
            $modulesData["secciones"][] = [
                "id" => $data["id"],
                "titulo" => $data["title"],
                "keywords" => $data["keywords"],
                "descripcion" => $data["description"],
                "foto" => $this->processPictureData($data["_embedded"]['picture']),
                "subSecciones" => $data["subSections"],
            ];
        }
    }

    protected function processBannersData($values, &$modulesData) {
        if(!array_key_exists("banners", $modulesData)) {
            $modulesData["banners"] = [
                "grupos_banners" => []
            ];
        };


        foreach($values as $bannerGroup) {
            $modulesData["banners"]["grupos_banners"][] = [
                "nombre" => "",
                "banners" => []
            ];

            $bannerIndex = count($modulesData["banners"]["grupos_banners"]) - 1;

            if(is_array($bannerGroup["_embedded"]["banners"])) {
                foreach($bannerGroup["_embedded"]["banners"] as $route => $data) {
                    
                    $picture = $this->processPictureData($data["_embedded"]['picture']);
                    
                    $modulesData["banners"]["grupos_banners"][$bannerIndex]['banners'][] = [
                        "id" => $data["id"],
                        "titulo" => $data["title"],
                        "texto" => $data["text"],
                        "vinculo" => $data["link"],
                        "descripcion" => $data["description"],
                        "enImagen" => $data["inImagen"],
                        "archivo" => is_array($picture) ? $picture["src"] : "",
                        "foto" => $picture,
                    ];
                }
            }
        }
        
    }

    protected function processPictureData($picture) {
        if(!is_array($picture)) {
            return;
        }
        
        return [
            "id" => $picture["id"],
            "idOriginal" => $picture["id"],
            "titulo" => $picture["title"],
            "src" => $picture["filename"],
            "src_alternativa" => $picture["filename"],
            "comentarios" => $picture["description"],
            "orden" => $picture["order"],
        ];
    }
}

?>


1			<?php
2
3			namespace Columnis\Model;
4
5			class PageLegacyData {
6
7			/**
8			*
9			* @var array
10			*/
11			protected $data;
12
13			public function setData($data) {
14			$this->data = $data;
15			}
16
17			public function __construct($data) {
18			$this->data = $data;
19			}
20
21			/**
22			* Get legacy data
23			*
24			* @return array
25			*/
26			public function getData() {
27			$legacyData = [
28			"sitio" => [
29			"traducciones" => [],
30			"traducciones_json" => [],
31			"menus" => [],
32			"datos_fecha" => [],
33			"images_path" => '',
34			"idiomas" => [],
35			"sitelink" => '',
36			"head" => [],
37			],
38			"modulos" => [],
39			"pagina" => [],
40			];
41
42			if(is_array($this->data)) {
43			foreach($this->data as $key => $value) {
44
45			switch($key) {
46			case 'columnis.rest.pages':
47			$this->processPageData(array_values($value)[0], $legacyData['pagina']);
48			break;
49			case 'columnis.rest.menu_items':
50			$this->processMenuData(array_values($value)[0], $legacyData['sitio']['menus'][0]);
51			break;
52			case 'columnis.rest.configuration':
53			$this->processConfigurationData(array_values($value)[0], $legacyData);
54			break;
55			case 'columnis.rest.translations':
56			$this->processTranslationsData(array_values($value)[0], $legacyData);
57			break;
58			case 'columnis.rest.sections':
59			$this->processSectionsData($value, $legacyData['modulos']);
60			break;
61			case 'columnis.rest.banners':
62			$this->processBannersData($value, $legacyData['modulos']);
63			break;
64			}
65			}
66			}
67
68			return $legacyData;
69			}
70
71			protected function processPageData($value, &$pageData) {
72
73			if(!empty($value)) {
74			$pageData['idPagina'] = $value['id'];
75			$pageData['template'] = $value['template'];
76			$pageData['tituloPagina'] = $value['text'];
77			$pageData['description'] = $value['description'];
78			$pageData['keywords'] = $value['keywords'];
79			}
80			}
81
82			protected function processMenuData($values, &$menusData) {
83			$menusData = [
84			'vinculos' => []
85			];
86
87			if(is_array($values["_embedded"]["menu_items"])) {
88			foreach($values["_embedded"]["menu_items"] as $menu) {
89			$menusData['vinculos'][] = [
90			"id" => $menu['id'],
91			"texto" => $menu['text'],
92			"target" => $menu['target'],
93			"anclaje" => $menu['anchorage'],
94			];
95			}
96			}
97			}
98
99			protected function processConfigurationData($values, &$data) {
			0 ignored issues – show Coding Style introduced 2017-01-31 17:55 UTC by Report Bug Copy Issue Report `processConfigurationData` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
100
101			$data["sitio"]["images_path"] = $values["imagesDomain"];
102
103			$data["sitio"]["head"] = [
104			"fixed" => [
105			"title" => $values["title"],
106			"keywords" => $values["keywords"],
107			"description" => $values["description"]
108			],
109			"analytics" => $values["analyticsAccountIds"]
110			];
111
112			$data["sitio"]["sitelink"] = $_SERVER['SERVER_NAME'];
113			}
114
115			protected function processTranslationsData($values, &$data) {
116			$translations = [];
117
118			if(is_array($values["_embedded"]["translations"])) {
119			foreach($values["_embedded"]["translations"] as $translation) {
120
121			if($translation["languageId"] === "es") {
122			$translations = $translation["translations"];
123			break;
124			}
125			}
126			}
127
128			$data["sitio"]["traducciones"] = $translations;
129			$data["sitio"]["traducciones_json"] = json_encode($translations);
130			}
131
132			protected function processSectionsData($values, &$modulesData) {
133			if(!array_key_exists("secciones", $modulesData)) {
134			$modulesData["secciones"] = [];
135			};
136
137			foreach($values as $route => $data) {
138			$modulesData["secciones"][] = [
139			"id" => $data["id"],
140			"titulo" => $data["title"],
141			"keywords" => $data["keywords"],
142			"descripcion" => $data["description"],
143			"foto" => $this->processPictureData($data["_embedded"]['picture']),
144			"subSecciones" => $data["subSections"],
145			];
146			}
147			}
148
149			protected function processBannersData($values, &$modulesData) {
150			if(!array_key_exists("banners", $modulesData)) {
151			$modulesData["banners"] = [
152			"grupos_banners" => []
153			];
154			};
155
156
157			foreach($values as $bannerGroup) {
158			$modulesData["banners"]["grupos_banners"][] = [
159			"nombre" => "",
160			"banners" => []
161			];
162
163			$bannerIndex = count($modulesData["banners"]["grupos_banners"]) - 1;
164
165			if(is_array($bannerGroup["_embedded"]["banners"])) {
166			foreach($bannerGroup["_embedded"]["banners"] as $route => $data) {
167
168			$picture = $this->processPictureData($data["_embedded"]['picture']);
169
170			$modulesData["banners"]["grupos_banners"][$bannerIndex]['banners'][] = [
171			"id" => $data["id"],
172			"titulo" => $data["title"],
173			"texto" => $data["text"],
174			"vinculo" => $data["link"],
175			"descripcion" => $data["description"],
176			"enImagen" => $data["inImagen"],
177			"archivo" => is_array($picture) ? $picture["src"] : "",
178			"foto" => $picture,
179			];
180			}
181			}
182			}
183
184			}
185
186			protected function processPictureData($picture) {
187			if(!is_array($picture)) {
188			return;
189			}
190
191			return [
192			"id" => $picture["id"],
193			"idOriginal" => $picture["id"],
194			"titulo" => $picture["title"],
195			"src" => $picture["filename"],
196			"src_alternativa" => $picture["filename"],
197			"comentarios" => $picture["description"],
198			"orden" => $picture["order"],
199			];
200			}
201			}
202
203			?>
			0 ignored issues – show Best Practice introduced 2017-01-31 17:55 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...

solcre / columnis-express

Push — master ( 4d741c...e56791 )

PageLegacyData A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

Duplication Side-by-Side

Filter issues like