TemplateAssetsResolverFactory::createService() - Code Metrics - solcre/columnis-express - Measure and Improve Code Quality continuously with Scrutinizer

TemplateAssetsResolverFactory::createService() B
last analyzed 2021-05-19 18:34 UTC

↳ Parent: TemplateAssetsResolverFactory

Complexity

Conditions	7
Paths	64

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	21
CRAP Score	7.0322

Importance

Changes

Metric	Value
dl	0
loc	29
rs	8.5226
c	0
b	0
f	0
ccs	21
cts	23
cp	0.913
cc	7
nc	64
nop	1
crap	7.0322

<?php

namespace Columnis\Service\Factory;

use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;
use Columnis\Model\TemplateAssetsResolver;

class TemplateAssetsResolverFactory implements FactoryInterface
{
    /**
     * {@inheritDoc}
     *
     * @return TemplateAssetsResolver
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        $config      = $serviceLocator->get('Config');
        
        if (isset($config['view_manager']['template_path_stack'])) {
            $templatesPathStack = $config['view_manager']['template_path_stack'];
        }
        if (isset($config['asset_manager']['resolver_configs']['paths'])) {
            $assetsPaths = $config['asset_manager']['resolver_configs']['paths'];
        }
        $templateAssetsResolver = new TemplateAssetsResolver($assetsPaths, $templatesPathStack);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        $resolverCfg = $config['template_assets_resolver'];
        if (isset($resolverCfg['match_patterns']['template_name'])) {
            $templateAssetsResolver->setPatternTemplateName($resolverCfg['match_patterns']['template_name']);
        }
        if (isset($resolverCfg['match_patterns']['global_asset'])) {
            $templateAssetsResolver->setPatternGlobalAssets($resolverCfg['match_patterns']['global_asset']);
        }
        if (isset($resolverCfg['global_folder_name'])) {
            $templateAssetsResolver->setGlobalFolderName($resolverCfg['global_folder_name']);
        }
        if (isset($resolverCfg['public_path'])) {
            $templateAssetsResolver->setPublicPath($resolverCfg['public_path']);
        }
        
        
        return $templateAssetsResolver;
    }
}


TemplateAssetsResolverFactory::createService() B
last analyzed 2021-05-19 18:34 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1		<?php
2
3		namespace Columnis\Service\Factory;
4
5		use Zend\ServiceManager\FactoryInterface;
6		use Zend\ServiceManager\ServiceLocatorInterface;
7		use Columnis\Model\TemplateAssetsResolver;
8
9		class TemplateAssetsResolverFactory implements FactoryInterface
10		{
11		/**
12		* {@inheritDoc}
13		*
14		* @return TemplateAssetsResolver
15		*/
16	13	public function createService(ServiceLocatorInterface $serviceLocator)
17		{
18	13	$config = $serviceLocator->get('Config');
19
20	13	if (isset($config['view_manager']['template_path_stack'])) {
21	13	$templatesPathStack = $config['view_manager']['template_path_stack'];
22	13	}
23	13	if (isset($config['asset_manager']['resolver_configs']['paths'])) {
24	13	$assetsPaths = $config['asset_manager']['resolver_configs']['paths'];
25	13	}
26	13	$templateAssetsResolver = new TemplateAssetsResolver($assetsPaths, $templatesPathStack);
		0 ignored issues – show Bug introduced 2016-03-10 18:01 UTC by Report Bug Copy Issue Report The variable `$assetsPaths` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2016-03-10 18:01 UTC by Report Bug Copy Issue Report The variable `$templatesPathStack` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
27
28	13	$resolverCfg = $config['template_assets_resolver'];
29	13	if (isset($resolverCfg['match_patterns']['template_name'])) {
30	13	$templateAssetsResolver->setPatternTemplateName($resolverCfg['match_patterns']['template_name']);
31	13	}
32	13	if (isset($resolverCfg['match_patterns']['global_asset'])) {
33	13	$templateAssetsResolver->setPatternGlobalAssets($resolverCfg['match_patterns']['global_asset']);
34	13	}
35	13	if (isset($resolverCfg['global_folder_name'])) {
36	13	$templateAssetsResolver->setGlobalFolderName($resolverCfg['global_folder_name']);
37	13	}
38	13	if (isset($resolverCfg['public_path'])) {
39		$templateAssetsResolver->setPublicPath($resolverCfg['public_path']);
40		}
41
42
43	13	return $templateAssetsResolver;
44		}
45		}
46

solcre / columnis-express

TemplateAssetsResolverFactory::createService() B last analyzed 2021-05-19 18:34 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

TemplateAssetsResolverFactory::createService() B
last analyzed 2021-05-19 18:34 UTC