Complex classes like Content often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Content, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
7 | class Content |
||
8 | { |
||
9 | const SHARE_TYPE_FACEBOOK = 'facebook'; |
||
10 | const SHARE_TYPE_GOOGLE = 'google'; |
||
11 | const SHARE_TYPE_ODNOKLASSNIKI = 'odnoklassniki'; |
||
12 | const SHARE_TYPE_TELEGRAM = 'telegram'; |
||
13 | const SHARE_TYPE_TWITTER = 'twitter'; |
||
14 | const SHARE_TYPE_VKONTAKTE = 'vkontakte'; |
||
15 | |||
16 | const SLIDER_DATA_VIEW_SQUARE = 'square'; |
||
17 | const SLIDER_DATA_VIEW_PORTRAIT = 'portrait'; |
||
18 | const SLIDER_DATA_VIEW_LANDSCAPE = 'landscape'; |
||
19 | |||
20 | const SLIDER_DATA_ITEM_VIEW_COVER = 'cover'; |
||
21 | const SLIDER_DATA_ITEM_VIEW_CONTAIN = 'contain'; |
||
22 | |||
23 | const OWN_VIDEO_TYPE_MP4 = 'video/mp4'; |
||
24 | |||
25 | /** |
||
26 | * Generate header element |
||
27 | * @param string $h1 |
||
28 | * @param string|null $h2 |
||
29 | * @param string|null $imgUrl |
||
30 | * @param string|null $imgCaption |
||
31 | * @param array|null $menuArray array of arrays with pairs of url and content |
||
32 | * [ |
||
33 | * ['url' => 'http://example/page1.html', 'title' => 'Page title 1'], |
||
34 | * ['url' => 'http://example/page2.html', 'title' => 'Page title 2'], |
||
35 | * ] |
||
36 | * @return string |
||
37 | */ |
||
38 | 9 | public static function header(string $h1, string $h2 = null, string $imgUrl = null, |
|
48 | |||
49 | /** |
||
50 | * Generate image element |
||
51 | * @param string $imgUrl |
||
52 | * @param string|null $imgCaption |
||
53 | * @return string |
||
54 | */ |
||
55 | 9 | public static function img(string $imgUrl, string $imgCaption = null): string |
|
63 | |||
64 | /** |
||
65 | * Generate video element |
||
66 | * @param string $videoUrl |
||
67 | * @param string|null $videoCaption |
||
68 | * @param string $imgUrl |
||
69 | * @param string $type |
||
70 | * @return string |
||
71 | */ |
||
72 | 6 | public static function ownVideo(string $videoUrl, string $videoCaption = null, string $type = self::OWN_VIDEO_TYPE_MP4, string $imgUrl = null): string |
|
80 | |||
81 | /** |
||
82 | * Generate video element for external video |
||
83 | * @param string $videoUrl |
||
84 | * @param array $options Options Array with next variables: width, height, frameborder, allowfullscreen, |
||
85 | * referrerpolicy, sandbox, hd. Options example: |
||
86 | * [ |
||
87 | * 'width' => 640, |
||
88 | * 'height' => 480, |
||
89 | * 'frameborder' => 1, |
||
90 | * 'allowfullscreen' => 'true', |
||
91 | * 'referrerpolicy' => 'unsafe-url', |
||
92 | * 'sandbox' => 'allow-forms allow-modals', |
||
93 | * 'hd' => 3 |
||
94 | * ] |
||
95 | * @return string |
||
96 | */ |
||
97 | 6 | public static function externalVideo(string $videoUrl, array $options = []): string |
|
109 | |||
110 | /** |
||
111 | * Generate images gallery |
||
112 | * @param array $imagesArray Array of images urls |
||
113 | * ['http://example.com/image1.jpg', 'http://example.com/image2.jpg'] |
||
114 | * @param string|null $header |
||
115 | * @return string |
||
116 | */ |
||
117 | 6 | public static function gallery(array $imagesArray, string $header = null): string |
|
127 | |||
128 | /** |
||
129 | * Generate media slider |
||
130 | * @param array $itemsArray Array of items with data |
||
131 | * [ |
||
132 | * ['url' => 'http://example.com/image1.jpg', 'title' => 'Image title 1', 'link' => ''], |
||
133 | * ['url' => 'http://example.com/image2.jpg', 'title' => 'Image title 2', 'link' => ''], |
||
134 | * ['url' => 'http://example.com/image3.jpg'], |
||
135 | * ['href' => 'http://example.com/page1.html', 'title' => 'Link title 1', 'text' => 'Link text 1'] |
||
136 | * ] |
||
137 | * @param string|null $header |
||
138 | * @param string $dataView |
||
139 | * @param string $dataItemView |
||
140 | * @return string |
||
141 | */ |
||
142 | 6 | public static function slider(array $itemsArray, string $header = null, |
|
153 | |||
154 | /** |
||
155 | * Generate share block |
||
156 | * @param array|null $networks Array of network names |
||
157 | * [Content::SHARE_TYPE_GOOGLE, Content::SHARE_TYPE_TWITTER] |
||
158 | * Can be empty, in this way all possible network types will be showed. |
||
159 | * @return string |
||
160 | */ |
||
161 | 6 | public static function share(array $networks = null): string |
|
169 | |||
170 | /** |
||
171 | * Generate rating block |
||
172 | * @param float $currentRating |
||
173 | * @param float $maxRating |
||
174 | * @return string |
||
175 | */ |
||
176 | 12 | public static function rating(float $currentRating, float $maxRating): string |
|
187 | |||
188 | /** |
||
189 | * Generate button |
||
190 | * @param string $text |
||
191 | * @param string $url |
||
192 | * @param string $phone Phone number in RFC-3966 format |
||
193 | * @param string|null $buttonColor Can be Text or HEX |
||
194 | * @param string|null $textColor Can be Text or HEX |
||
195 | * @param bool $isBoldText |
||
196 | * @param bool $isDisabled |
||
197 | * @return string |
||
198 | */ |
||
199 | 12 | public static function button(string $text, string $url = '', string $phone = '', |
|
220 | |||
221 | /** |
||
222 | * Generate comment block |
||
223 | * @param string $url URL to comments page |
||
224 | * @param array $commentsArray multidimensional or one-dimensional array of comments, |
||
225 | * can has unlimited includes, example: |
||
226 | * [ |
||
227 | * [ |
||
228 | * 'author' => 'First Author Name', |
||
229 | * 'avatar' => 'http://example.com/user1.jpg', |
||
230 | * 'title' => 'Comment Title', |
||
231 | * 'subtitle' => '2017-12-10', |
||
232 | * 'content' => 'Somme comment text', |
||
233 | * 'comments' => [ |
||
234 | * [ |
||
235 | * 'author' => 'Third Author Name', |
||
236 | * 'avatar' => 'http://example.com/user3.jpg', |
||
237 | * 'title' => 'Comment Title', |
||
238 | * 'subtitle' => '2017-12-12', |
||
239 | * 'content' => 'Some answer text' |
||
240 | * ], |
||
241 | * [ |
||
242 | * 'author' => 'Another Author Name', |
||
243 | * 'avatar' => 'http://example.com/user4.jpg', |
||
244 | * 'title' => 'Comment Title', |
||
245 | * 'subtitle' => '2017-12-13', |
||
246 | * 'content' => 'Another answer text' |
||
247 | * ], |
||
248 | * ] |
||
249 | * ], |
||
250 | * [ |
||
251 | * 'author' => 'Second Author Name', |
||
252 | * 'avatar' => 'http://example.com/user2.jpg', |
||
253 | * 'title' => 'Comment Title', |
||
254 | * 'subtitle' => '2017-12-11', |
||
255 | * 'content' => 'Some comment text' |
||
256 | * ], |
||
257 | * ] |
||
258 | * @return string |
||
259 | */ |
||
260 | 3 | public static function comment(string $url, array $commentsArray): string |
|
266 | |||
267 | /** |
||
268 | * Generate accordion |
||
269 | * @param array $accordionArray array accordion elements |
||
270 | * [ |
||
271 | * ['title' => 'Page title 1', 'text' => 'Text 1'], |
||
272 | * ['title' => 'Page title 2', 'text' => 'Text 2', 'expanded' => true], |
||
273 | * ] |
||
274 | * @return string |
||
275 | */ |
||
276 | 3 | public static function accordion(array $accordionArray): string |
|
289 | |||
290 | /** |
||
291 | * Generate Ad block position element |
||
292 | * @param string $turboAdId value of $turboAdId used in Channel() class |
||
293 | * @return string |
||
294 | * |
||
295 | * @see Channel::$adTurboAdId |
||
296 | */ |
||
297 | 3 | public static function adBlockPosition(string $turboAdId): string |
|
301 | |||
302 | /** |
||
303 | * Generate content block for media slider |
||
304 | * @param array $itemsArray Array of items with data |
||
305 | * [ |
||
306 | * ['url' => 'http://example.com/image1.jpg', 'title' => 'Image title 1', 'link' => ''], |
||
307 | * ['url' => 'http://example.com/image2.jpg', 'title' => 'Image title 2', 'link' => ''], |
||
308 | * ['url' => 'http://example.com/image3.jpg'], |
||
309 | * ['href' => 'http://example.com/page1.html', 'title' => 'Link title 1', 'text' => 'Link text 1'] |
||
310 | * ] |
||
311 | * @return string |
||
312 | */ |
||
313 | 6 | private static function generateSliderItemsBlock(array $itemsArray): string |
|
335 | |||
336 | 3 | private static function generateCommentBlock(array $commentsArray): string |
|
366 | |||
367 | /** |
||
368 | * Generate header menu |
||
369 | * @param array $menuArray array of arrays with pairs of url and title |
||
370 | * [ |
||
371 | * ['url' => 'http://example/page1.html', 'title' => 'Page title 1'], |
||
372 | * ['url' => 'http://example/page2.html', 'title' => 'Page title 2'], |
||
373 | * ] |
||
374 | * @return string |
||
375 | */ |
||
376 | 3 | private static function generateMenu(array $menuArray) |
|
386 | } |