RelatedItemsList::asXML() - Code Metrics - Inspection of "added possibility to enable infinity mode for rela..." - sokolnikov911/yandex-turbo-pages - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b44d6e...953f71 )

by Petro

created 2018-05-11 09:23 UTC

RelatedItemsList::asXML() A

↳ Parent: RelatedItemsList

Complexity

Conditions	3
Paths	4

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	10
cts	10
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	10
nc	4
nop	0
crap	3

<?php

namespace sokolnikov911\YandexTurboPages;

/**
 * Class RelatedItemsList
 * @package sokolnikov911\YandexTurboPages
 */
class RelatedItemsList implements RelatedItemsListInterface
{
    /** @var RelatedItemInterface[] */
    protected $relatedItems = [];

    protected $infinity;

    /**
     * Add channel
     * @param bool $infinity Use or not infinity scroll of related items
     * @return void

     */
    public function __construct(bool $infinity = false)
    {
        $this->infinity = $infinity;
    }

    public function appendTo(ItemInterface $item): RelatedItemsListInterface
    {
        $item->addRelatedItemsList($this);
        return $this;
    }

    public function addItem(RelatedItem $relatedItem): RelatedItemsListInterface
    {
        $this->relatedItems[] = $relatedItem;
        return $this;
    }

    public function asXML(): SimpleXMLElement
    {
        $infinity = $this->infinity ? 'type="infinity"' : '';

        $xml = new SimpleXMLElement('<?xml version="1.0" encoding="UTF-8" ?><yandex:related '
            . $infinity . '></yandex:related>',
            LIBXML_NOERROR | LIBXML_ERR_NONE | LIBXML_ERR_FATAL);

        foreach ($this->relatedItems as $item) {
            $toDom = dom_import_simplexml($xml);
            $fromDom = dom_import_simplexml($item->asXML());
            $toDom->appendChild($toDom->ownerDocument->importNode($fromDom, true));
        }

        return $xml;
    }
}


1		<?php
2
3		namespace sokolnikov911\YandexTurboPages;
4
5		/**
6		* Class RelatedItemsList
7		* @package sokolnikov911\YandexTurboPages
8		*/
9		class RelatedItemsList implements RelatedItemsListInterface
10		{
11		/** @var RelatedItemInterface[] */
12		protected $relatedItems = [];
13
14		protected $infinity;
15
16		/**
17		* Add channel
18		* @param bool $infinity Use or not infinity scroll of related items
19		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2018-05-11 09:26 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
20		*/
21	21	public function __construct(bool $infinity = false)
22		{
23	21	$this->infinity = $infinity;
24	21	}
25
26	3	public function appendTo(ItemInterface $item): RelatedItemsListInterface
27		{
28	3	$item->addRelatedItemsList($this);
29	3	return $this;
30		}
31
32	9	public function addItem(RelatedItem $relatedItem): RelatedItemsListInterface
33		{
34	9	$this->relatedItems[] = $relatedItem;
35	9	return $this;
36		}
37
38	12	public function asXML(): SimpleXMLElement
39		{
40	12	$infinity = $this->infinity ? 'type="infinity"' : '';
41
42	12	$xml = new SimpleXMLElement('<?xml version="1.0" encoding="UTF-8" ?><yandex:related '
43	12	. $infinity . '></yandex:related>',
44	12	LIBXML_NOERROR \| LIBXML_ERR_NONE \| LIBXML_ERR_FATAL);
45
46	12	foreach ($this->relatedItems as $item) {
47	3	$toDom = dom_import_simplexml($xml);
48	3	$fromDom = dom_import_simplexml($item->asXML());
49	3	$toDom->appendChild($toDom->ownerDocument->importNode($fromDom, true));
50		}
51
52	12	return $xml;
53		}
54		}
55

sokolnikov911 / yandex-turbo-pages

Push — master ( b44d6e...953f71 )

RelatedItemsList::asXML() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like