Issues in GridFS.php (master) - Issues in master - sokil/php-mongo - Measure and Improve Code Quality continuously with Scrutinizer

Issues (142)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/GridFS.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * This file is part of the PHPMongo package.
 *
 * (c) Dmytro Sokil <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sokil\Mongo;

/**
 * Representation of GridFS as collection of files
 *
 * @property \MongoGridFS $collection MongoGridFS Instance
 */
class GridFS extends Collection
{
    protected $mongoCollectionClassName = '\MongoGridFS';
    
    /**
     * Factory method to get document object from array of stored document
     * @param \MongoGridFSFile $data
     * @return \Sokil\Mongo\GridFsFile
     */
    public function hydrate($data, $useDocumentPool = true)
    {
        if (($data instanceof \MongoGridFSFile) === false) {
            throw new Exception('Must be \MongoGridFSFile');
        }
        
        $className = $this->getFileClassName($data);
        
        return new $className($this, $data);
    }
    
    /**
     * Override to define class name of file by file data
     *
     * @param \MongoGridFSFile $fileData
     * @return string Document class data
     */
    public function getFileClassName(\MongoGridFSFile $fileData = null)

    {
        return '\Sokil\Mongo\GridFSFile';
    }
    
    /**
     * Create file in GridFS from file in filesystem
     *
     * @param string $filename name of source file
     * @param array $metadata metadata stored with file
     * @return \MongoId Id of stored file
     */
    public function storeFile($filename, $metadata = array())
    {
        return $this->getMongoCollection()->storeFile($filename, $metadata);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
    
    /**
     * Create file in GridFS from binary data
     *
     * @param string $bytes binary data to store in GridFS
     * @param array $metadata metadata stored with file
     * @return \MongoId Id of stored file
     */
    public function storeBytes($bytes, $metadata = array())
    {
        return $this->getMongoCollection()->storeBytes($bytes, $metadata);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * Get file instance by id of document
     * Used \MongoGridFS::findOne() instead of \MongoGridFS::get() due
     * to backward compatibility with old mongo extensions
     *
     * @param \MongoId|string|int $id
     * @return \Sokil\Mongo\GridFSFile|null
     */
    public function getFileById($id)
    {
        if ($id instanceof \MongoId) {
            $file = $this->getMongoCollection()->findOne(array('_id' => $id));
        } else {
            try {
                $file = $this->getMongoCollection()->findOne(array('_id' => new \MongoId($id)));
            } catch (\MongoException $e) {
                $file = $this->getMongoCollection()->findOne(array('_id' => $id));
            }
        }
        
        if (!$file) {

            return null;
        }
        
        $fileClassName = $this->getFileClassName($file);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        return new $fileClassName($this, $file);
    }
    
    /**
     * Delete file by id
     *
     * @param string|\MongoId $id id of file's document
     * @return \Sokil\Mongo\GridFS
     * @throws Exception
     */
    public function deleteFileById($id)
    {
        if ($id instanceof \MongoId) {
            $result = $this->getMongoCollection()->delete($id);

        } else {
            try {
                $result = $this->getMongoCollection()->delete(new \MongoId($id));

            } catch (\MongoException $e) {
                $result = $this->getMongoCollection()->delete($id);

            }
        }
        if ($result['ok'] !== (double) 1) {

            throw new Exception('Error deleting file: ' . $result['err'] . ': ' . $result['errmsg']);
        }
        
        return $this;
    }
}


1		<?php
2
3		/**
4		* This file is part of the PHPMongo package.
5		*
6		* (c) Dmytro Sokil <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Sokil\Mongo;
13
14		/**
15		* Representation of GridFS as collection of files
16		*
17		* @property \MongoGridFS $collection MongoGridFS Instance
18		*/
19		class GridFS extends Collection
20		{
21		protected $mongoCollectionClassName = '\MongoGridFS';
22
23		/**
24		* Factory method to get document object from array of stored document
25		* @param \MongoGridFSFile $data
26		* @return \Sokil\Mongo\GridFsFile
27		*/
28		public function hydrate($data, $useDocumentPool = true)
29		{
30		if (($data instanceof \MongoGridFSFile) === false) {
31		throw new Exception('Must be \MongoGridFSFile');
32		}
33
34		$className = $this->getFileClassName($data);
35
36		return new $className($this, $data);
37		}
38
39		/**
40		* Override to define class name of file by file data
41		*
42		* @param \MongoGridFSFile $fileData
43		* @return string Document class data
44		*/
45		public function getFileClassName(\MongoGridFSFile $fileData = null)
		0 ignored issues – show Unused Code introduced 2017-08-12 12:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$fileData` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
46		{
47		return '\Sokil\Mongo\GridFSFile';
48		}
49
50		/**
51		* Create file in GridFS from file in filesystem
52		*
53		* @param string $filename name of source file
54		* @param array $metadata metadata stored with file
55		* @return \MongoId Id of stored file
56		*/
57		public function storeFile($filename, $metadata = array())
58		{
59		return $this->getMongoCollection()->storeFile($filename, $metadata);
		0 ignored issues – show Bug introduced 2016-09-13 20:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a specific sub-type and not the parent class `MongoCollection` as the method `storeFile()` does only exist in the following sub-classes of `MongoCollection`: `MongoGridFS`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
60		}
61
62		/**
63		* Create file in GridFS from binary data
64		*
65		* @param string $bytes binary data to store in GridFS
66		* @param array $metadata metadata stored with file
67		* @return \MongoId Id of stored file
68		*/
69		public function storeBytes($bytes, $metadata = array())
70		{
71		return $this->getMongoCollection()->storeBytes($bytes, $metadata);
		0 ignored issues – show Bug introduced 2016-09-13 20:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a specific sub-type and not the parent class `MongoCollection` as the method `storeBytes()` does only exist in the following sub-classes of `MongoCollection`: `MongoGridFS`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
72		}
73
74		/**
75		* Get file instance by id of document
76		* Used \MongoGridFS::findOne() instead of \MongoGridFS::get() due
77		* to backward compatibility with old mongo extensions
78		*
79		* @param \MongoId\|string\|int $id
80		* @return \Sokil\Mongo\GridFSFile\|null
81		*/
82		public function getFileById($id)
83		{
84		if ($id instanceof \MongoId) {
85		$file = $this->getMongoCollection()->findOne(array('_id' => $id));
86		} else {
87		try {
88		$file = $this->getMongoCollection()->findOne(array('_id' => new \MongoId($id)));
89		} catch (\MongoException $e) {
90		$file = $this->getMongoCollection()->findOne(array('_id' => $id));
91		}
92		}
93
94		if (!$file) {
		0 ignored issues – show Bug Best Practice introduced 2016-09-13 20:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$file` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
95		return null;
96		}
97
98		$fileClassName = $this->getFileClassName($file);
		0 ignored issues – show Documentation introduced 2016-09-13 20:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$file` is of type `array`, but the function expects a `null\|object<MongoGridFSFile>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
99		return new $fileClassName($this, $file);
100		}
101
102		/**
103		* Delete file by id
104		*
105		* @param string\|\MongoId $id id of file's document
106		* @return \Sokil\Mongo\GridFS
107		* @throws Exception
108		*/
109		public function deleteFileById($id)
110		{
111		if ($id instanceof \MongoId) {
112		$result = $this->getMongoCollection()->delete($id);
		0 ignored issues – show Bug introduced 2016-09-13 20:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `delete()` does not exist on `MongoCollection`. Did you maybe mean `deleteIndex()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
113		} else {
114		try {
115		$result = $this->getMongoCollection()->delete(new \MongoId($id));
		0 ignored issues – show Bug introduced 2016-09-13 20:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `delete()` does not exist on `MongoCollection`. Did you maybe mean `deleteIndex()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
116		} catch (\MongoException $e) {
117		$result = $this->getMongoCollection()->delete($id);
		0 ignored issues – show Bug introduced 2016-09-13 20:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `delete()` does not exist on `MongoCollection`. Did you maybe mean `deleteIndex()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
118		}
119		}
120	View Code Duplication	if ($result['ok'] !== (double) 1) {
		0 ignored issues – show Duplication introduced 2015-12-03 20:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		throw new Exception('Error deleting file: ' . $result['err'] . ': ' . $result['errmsg']);
122		}
123
124		return $this;
125		}
126		}
127

GitHub Access Token became invalid

Issues (142)

Security Analysis no request data

src/GridFS.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

sokil / php-mongo

GitHub Access Token became invalid

Issues (142)

Security Analysis no request data

src/GridFS.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like