Sokil\Mongo\GridFS

Complexity

Total Complexity

13

Size/Duplication

Total Lines	107
Duplicated Lines	2.8 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	hydrate()	0	10	2
A	getFileClassName()	0	4	1
A	storeFile()	0	4	1
A	storeBytes()	0	4	1
A	getFileById()	0	19	4
A	deleteFileById()	3	17	4

<?php

/**
 * This file is part of the PHPMongo package.
 *
 * (c) Dmytro Sokil <dmytro.sokil@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sokil\Mongo;

/**
 * Representation of GridFS as collection of files
 *
 * @property \MongoGridFS $collection MongoGridFS Instance
 */
class GridFS extends Collection
{
    protected $mongoCollectionClassName = '\MongoGridFS';
    
    /**
     * Factory method to get document object from array of stored document 
     * @param \MongoGridFSFile $data
     * @return \Sokil\Mongo\GridFsFile
     */
    public function hydrate($data, $useDocumentPool = true)
    {
        if(($data instanceof \MongoGridFSFile) === false) {
            throw new Exception('Must be \MongoGridFSFile');
        }
        
        $className = $this->getFileClassName($data);
        
        return new $className($this, $data);
    }
    
    /**
     * Override to define class name of file by file data
     * 
     * @param \MongoGridFSFile $fileData
     * @return string Document class data
     */
    public function getFileClassName(\MongoGridFSFile $fileData = null)

The parameter $fileData is not used and could be removed.

    {
        return '\Sokil\Mongo\GridFSFile';
    }
    
    /**
     * Create file in GridFS from file in filesystem
     * 
     * @param string $filename name of source file
     * @param array $metadata metadata stored with file
     * @return \MongoId Id of stored file
     */
    public function storeFile($filename, $metadata = array())
    {
        return $this->getMongoCollection()->storeFile($filename, $metadata);

It seems like you code against a specific sub-type and not the parent class MongoCollection as the method storeFile() does only exist in the following sub-classes of MongoCollection: MongoGridFS. Maybe you want to instanceof check for one of these explicitly?

    }
    
    /**
     * Create file in GridFS from binary data
     * 
     * @param string $bytes binary data to store in GridFS
     * @param array $metadata metadata stored with file
     * @return \MongoId Id of stored file
     */
    public function storeBytes($bytes, $metadata = array())
    {
        return $this->getMongoCollection()->storeBytes($bytes, $metadata);

It seems like you code against a specific sub-type and not the parent class MongoCollection as the method storeBytes() does only exist in the following sub-classes of MongoCollection: MongoGridFS. Maybe you want to instanceof check for one of these explicitly?

    }

    /**
     * Get file instance by id of document
     * Used \MongoGridFS::findOne() instead of \MongoGridFS::get() due to backward compatibility with old mongo extensions
     *
     * @param \MongoId|string|int $id
     * @return \Sokil\Mongo\GridFSFile|null
     */
    public function getFileById($id)
    {
        if($id instanceof \MongoId) {
            $file = $this->getMongoCollection()->findOne(array('_id' => $id));
        } else {
            try {
                $file = $this->getMongoCollection()->findOne(array('_id' => new \MongoId($id)));
            } catch (\MongoException $e) {
                $file = $this->getMongoCollection()->findOne(array('_id' => $id));
            }
        }
        
        if(!$file) {

The expression $file of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return null;
        }
        
        $fileClassName = $this->getFileClassName($file);

$file is of type array, but the function expects a null|object<MongoGridFSFile>.

        return new $fileClassName($this, $file);
    }
    
    /**
     * Delete file by id
     * 
     * @param string|\MongoId $id id of file's document
     * @return \Sokil\Mongo\GridFS
     * @throws Exception
     */
    public function deleteFileById($id)
    {
        if($id instanceof \MongoId) {
            $result = $this->getMongoCollection()->delete($id);

The method delete() does not exist on MongoCollection. Did you maybe mean deleteIndex()?

        } else {
            try {
                $result = $this->getMongoCollection()->delete(new \MongoId($id));

The method delete() does not exist on MongoCollection. Did you maybe mean deleteIndex()?

            } catch (\MongoException $e) {
                $result = $this->getMongoCollection()->delete($id);

The method delete() does not exist on MongoCollection. Did you maybe mean deleteIndex()?

            }
        }
        if($result['ok'] !== (double) 1) {

This code seems to be duplicated across your project.

            throw new Exception('Error deleting file: ' . $result['err'] . ': ' . $result['errmsg']);
        }
        
        return $this;
    }
}