GenerateConfig::getMutationConfig() - Code Metrics - Inspection of "Config generator allow cyclic relations" - softonic/graphql-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#45)

by Jose Manuel

created 2020-06-03 11:25 UTC

GenerateConfig::getMutationConfig() B

↳ Parent: GenerateConfig

Complexity

Conditions	7
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

Metric	Value
dl	0
loc	34
ccs	0
cts	31
cp	0
rs	8.4426
c	0
b	0
f	0
cc	7
nc	3
nop	3
crap	56

<?php

namespace Softonic\GraphQL\Console\Mutation;

use Softonic\GraphQL\Config\MutationTypeConfig;
use Softonic\GraphQL\DataObjects\Mutation\Collection;
use Softonic\GraphQL\DataObjects\Mutation\Item;
use stdClass;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class GenerateConfig extends Command
{
    const SCALAR = 'SCALAR';

    const INPUT_OBJECT = 'INPUT_OBJECT';

    const LIST = 'LIST';

    protected static $defaultName = 'mutation:generate-config';

    protected $generatedFieldTypes = [];

    protected function configure()
    {
        $this->setDescription('Creates a mutation config.')
            ->setHelp('This command allows you to create a mutation config based in the result of a ' .
                'introspection query for a specific mutation.');

        $this
            ->addArgument(
                'instrospection-result',
                InputArgument::REQUIRED,
                'Json file with the introspection query result'
            )
            ->addArgument(
                'mutation',
                InputArgument::REQUIRED,
                'Mutation name to extract to the configuration'
            );
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        if (!$this->checkArguments($input, $output)) {
            return 1;
        }

        $jsonSchema = file_get_contents($input->getArgument('instrospection-result'));
        $mutation   = $input->getArgument('mutation');

        $mutationConfig = $this->generateConfig(json_decode($jsonSchema), $mutation);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $output->writeln(var_export($mutationConfig, true));

        return 0;
    }

    private function checkArguments(InputInterface $input, OutputInterface $output)
    {
        $jsonPath = $input->getArgument('instrospection-result');

        if (!file_exists($jsonPath)) {
            $output->writeln("The file '{$jsonPath}' does not exist");

            return false;
        }

        return true;
    }

    private function generateConfig(StdClass $jsonSchema, string $mutation)
    {
        foreach ($jsonSchema->data->__schema->types as $type) {
            if ($type->name === 'Mutation' && $type->fields[0]->name === $mutation) {
                $initialMutationField = $type->fields[0]->args[0]->name;
                $inputType            = $type->fields[0]->args[0]->type->ofType->name;
                break;
            }
        }

        return [
            $mutation => [
                $initialMutationField => [
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    'linksTo'  => '.',
                    'type'     => Item::class,
                    'children' => $this->getMutationConfig($jsonSchema, $inputType),
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                ],
            ],
        ];
    }

    private function getTypeFromField($field)
    {
        $isCollection = false;
        $type         = $field->type;

        while ($type->kind !== self::SCALAR && $type->kind !== self::INPUT_OBJECT) {
            if ($type->kind === self::LIST) {
                $isCollection = true;
            }
            $type = $type->ofType;
        }

        if ($type->kind === self::SCALAR) {
            return [
                'type'         => $type->kind,
                'isCollection' => $isCollection,
            ];
        }

        return [
            'type'         => $type->name,
            'isCollection' => $isCollection,
        ];
    }

    private function getMutationConfig(stdClass $jsonSchema, $inputType, $parentLinksTo = ''): array
    {
        $children = [];
        foreach ($jsonSchema->data->__schema->types as $type) {
            if ($type->name === $inputType) {
                foreach ($type->inputFields as $inputField) {
                    [
                        'type'         => $type,
                        'isCollection' => $isCollection,

                    ] = $this->getTypeFromField($inputField);

                    if ($type === self::SCALAR) {
                        $children[$inputField->name] = [
                            'type' => MutationTypeConfig::SCALAR_DATA_TYPE,
                        ];
                        continue;
                    }

                    if (!in_array($inputType, $this->generatedFieldTypes[$inputField->name] ?? [])) {
                        $this->generatedFieldTypes[$inputField->name][] = $inputType;
                        $linksTo                                        = "{$parentLinksTo}.{$inputField->name}";
                        $children[$inputField->name]                    = [
                            'linksTo'  => $linksTo,
                            'type'     => $isCollection ? Collection::class : Item::class,
                            'children' => $this->getMutationConfig($jsonSchema, $type, $linksTo),
                        ];
                    }
                }
                break;
            }
        }

        return $children;
    }
}


1			<?php
2
3			namespace Softonic\GraphQL\Console\Mutation;
4
5			use Softonic\GraphQL\Config\MutationTypeConfig;
6			use Softonic\GraphQL\DataObjects\Mutation\Collection;
7			use Softonic\GraphQL\DataObjects\Mutation\Item;
8			use stdClass;
9			use Symfony\Component\Console\Command\Command;
10			use Symfony\Component\Console\Input\InputArgument;
11			use Symfony\Component\Console\Input\InputInterface;
12			use Symfony\Component\Console\Output\OutputInterface;
13
14			class GenerateConfig extends Command
15			{
16			const SCALAR = 'SCALAR';
17
18			const INPUT_OBJECT = 'INPUT_OBJECT';
19
20			const LIST = 'LIST';
21
22			protected static $defaultName = 'mutation:generate-config';
23
24			protected $generatedFieldTypes = [];
25
26			protected function configure()
27			{
28			$this->setDescription('Creates a mutation config.')
29			->setHelp('This command allows you to create a mutation config based in the result of a ' .
30			'introspection query for a specific mutation.');
31
32			$this
33			->addArgument(
34			'instrospection-result',
35			InputArgument::REQUIRED,
36			'Json file with the introspection query result'
37			)
38			->addArgument(
39			'mutation',
40			InputArgument::REQUIRED,
41			'Mutation name to extract to the configuration'
42			);
43			}
44
45			protected function execute(InputInterface $input, OutputInterface $output)
46			{
47			if (!$this->checkArguments($input, $output)) {
48			return 1;
49			}
50
51			$jsonSchema = file_get_contents($input->getArgument('instrospection-result'));
52			$mutation = $input->getArgument('mutation');
53
54			$mutationConfig = $this->generateConfig(json_decode($jsonSchema), $mutation);
			0 ignored issues – show Bug introduced 2020-05-21 15:54 UTC by Report Bug Copy Issue Report It seems like `$mutation` defined by `$input->getArgument('mutation')` on line `52` can also be of type `array<integer,string>` or `null`; however, `Softonic\GraphQL\Console...onfig::generateConfig()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
55
56			$output->writeln(var_export($mutationConfig, true));
57
58			return 0;
59			}
60
61			private function checkArguments(InputInterface $input, OutputInterface $output)
62			{
63			$jsonPath = $input->getArgument('instrospection-result');
64
65			if (!file_exists($jsonPath)) {
66			$output->writeln("The file '{$jsonPath}' does not exist");
67
68			return false;
69			}
70
71			return true;
72			}
73
74			private function generateConfig(StdClass $jsonSchema, string $mutation)
75			{
76			foreach ($jsonSchema->data->__schema->types as $type) {
77			if ($type->name === 'Mutation' && $type->fields[0]->name === $mutation) {
78			$initialMutationField = $type->fields[0]->args[0]->name;
79			$inputType = $type->fields[0]->args[0]->type->ofType->name;
80			break;
81			}
82			}
83
84			return [
85			$mutation => [
86			$initialMutationField => [
			0 ignored issues – show Bug introduced 2020-05-21 15:54 UTC by Report Bug Copy Issue Report The variable `$initialMutationField` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
87			'linksTo' => '.',
88			'type' => Item::class,
89			'children' => $this->getMutationConfig($jsonSchema, $inputType),
			0 ignored issues – show Bug introduced 2020-05-21 15:54 UTC by Report Bug Copy Issue Report The variable `$inputType` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
90			],
91			],
92			];
93			}
94
95			private function getTypeFromField($field)
96			{
97			$isCollection = false;
98			$type = $field->type;
99
100			while ($type->kind !== self::SCALAR && $type->kind !== self::INPUT_OBJECT) {
101			if ($type->kind === self::LIST) {
102			$isCollection = true;
103			}
104			$type = $type->ofType;
105			}
106
107			if ($type->kind === self::SCALAR) {
108			return [
109			'type' => $type->kind,
110			'isCollection' => $isCollection,
111			];
112			}
113
114			return [
115			'type' => $type->name,
116			'isCollection' => $isCollection,
117			];
118			}
119
120			private function getMutationConfig(stdClass $jsonSchema, $inputType, $parentLinksTo = ''): array
121			{
122			$children = [];
123			foreach ($jsonSchema->data->__schema->types as $type) {
124			if ($type->name === $inputType) {
125			foreach ($type->inputFields as $inputField) {
126			[
127			'type' => $type,
128			'isCollection' => $isCollection,
			0 ignored issues – show Bug introduced 2020-05-21 15:54 UTC by Report Bug Copy Issue Report The variable `$isCollection` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
129			] = $this->getTypeFromField($inputField);
130
131			if ($type === self::SCALAR) {
132			$children[$inputField->name] = [
133			'type' => MutationTypeConfig::SCALAR_DATA_TYPE,
134			];
135			continue;
136			}
137
138			if (!in_array($inputType, $this->generatedFieldTypes[$inputField->name] ?? [])) {
139			$this->generatedFieldTypes[$inputField->name][] = $inputType;
140			$linksTo = "{$parentLinksTo}.{$inputField->name}";
141			$children[$inputField->name] = [
142			'linksTo' => $linksTo,
143			'type' => $isCollection ? Collection::class : Item::class,
144			'children' => $this->getMutationConfig($jsonSchema, $type, $linksTo),
145			];
146			}
147			}
148			break;
149			}
150			}
151
152			return $children;
153			}
154			}
155

softonic / graphql-client

Pull Request — master (#45)

GenerateConfig::getMutationConfig() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like