Softonic\GraphQL\DataObjects\CollectionIterator

Complexity

Total Complexity

8

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

94.12%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	valid()	0	11	4
A	hasChildren()	0	13	3
A	getChildren()	0	6	1

<?php

namespace Softonic\GraphQL\DataObjects;

use RecursiveArrayIterator;

class CollectionIterator extends RecursiveArrayIterator
{
    public function valid(): bool
    {
        $isValid = parent::valid();
        if ($isValid && !$this->hasChildren() && $this->current() instanceof AbstractCollection) {
            $this->next();

            return $this->valid();
        }

        return $isValid;
    }

    public function hasChildren(): bool
    {
        $current = $this->current();
        if ($current instanceof AbstractItem) {
            return false;
        }

        if (is_array($current)) {
            return true;
        }

        return $current->hasChildren();
    }

    public function getChildren()
    {
        return parent::current()

It seems like you call parent on a different method (current() instead of getChildren()). Are you sure this is correct? If so, you might want to change this to $this->current().

            ->getIterator()
            ->getInnerIterator();
    }
}