JsonPathAccessor::get() - Code Metrics - Inspection of "Add is empty to collections" - softonic/graphql-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#42)

by Jose Manuel

created 2020-05-21 09:38 UTC

JsonPathAccessor::get() A

↳ Parent: JsonPathAccessor

Complexity

Conditions	4
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	23
ccs	10
cts	10
cp	1
rs	9.552
c	0
b	0
f	0
cc	4
nc	5
nop	1
crap	4

<?php

namespace Softonic\GraphQL\Traits;

trait JsonPathAccessor
{
    public function get(string $path)
    {
        if ($path == '.') {
            return $this;
        }

        $attributes = explode('.', $path);
        unset($attributes[0]);

        $attribute = array_shift($attributes);

        /**
         * This condition is needed because a child could have the same name than a MutationTypeConfig attribute
         * (type, linksTo, children).
         */
        $value = $this->hasChild($attribute) ? $this->children[$attribute] : $this->{$attribute};
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if (!empty($attributes)) {
            $value = $value->get('.' . implode('.', $attributes));
        }

        return $value;
    }
}


1		<?php
2
3		namespace Softonic\GraphQL\Traits;
4
5		trait JsonPathAccessor
6		{
7	102	public function get(string $path)
8		{
9	102	if ($path == '.') {
10	98	return $this;
11		}
12
13	100	$attributes = explode('.', $path);
14	100	unset($attributes[0]);
15
16	100	$attribute = array_shift($attributes);
17
18		/**
19		* This condition is needed because a child could have the same name than a MutationTypeConfig attribute
20		* (type, linksTo, children).
21		*/
22	100	$value = $this->hasChild($attribute) ? $this->children[$attribute] : $this->{$attribute};
		0 ignored issues – show Bug introduced 2020-05-21 09:39 UTC by Report Bug Copy Issue Report The property `children` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2020-05-21 09:39 UTC by Report Bug Copy Issue Report It seems like `hasChild()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23
24	100	if (!empty($attributes)) {
25	74	$value = $value->get('.' . implode('.', $attributes));
26		}
27
28	100	return $value;
29		}
30		}
31

softonic / graphql-client

Pull Request — master (#42)

JsonPathAccessor::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like