ResponseBuilder::getJsonDecodedResponse() - Code Metrics - Inspection of "Merge pull request #1 from softonic/feature/simple..." - softonic/graphql-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (c90d5b)

by Riccardo

created 2017-08-21 09:28 UTC

ResponseBuilder::getJsonDecodedResponse() A

↳ Parent: ResponseBuilder

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	1
crap	2

<?php

namespace Softonic\GraphQL;

use Psr\Http\Message\ResponseInterface;

class ResponseBuilder
{
    public function build(ResponseInterface $httpResponse)
    {
        $body = $httpResponse->getBody();
        
        $normalizedResponse = $this->getNormalizedResponse($body);

        return new Response($normalizedResponse['data'], $normalizedResponse['errors']);
    }

    private function getNormalizedResponse(string $body)
    {
        $decodedResponse = $this->getJsonDecodedResponse($body);
        
        if (!array_key_exists('data', $decodedResponse)) {
            throw new \UnexpectedValueException('Invalid GraphQL JSON response.');
        }

        return [
            'data' => $decodedResponse['data'] ?? [],
            'errors' => $decodedResponse['errors'] ?? [],
        ];
    }

    private function getJsonDecodedResponse(string $body)
    {
        $response = json_decode($body, true);

        $error = json_last_error();
        if (JSON_ERROR_NONE !== $error) {
            throw new \UnexpectedValueException('Invalid JSON response.');
        }
        return $response;
    }
}


1		<?php
2
3		namespace Softonic\GraphQL;
4
5		use Psr\Http\Message\ResponseInterface;
6
7		class ResponseBuilder
8		{
9	10	public function build(ResponseInterface $httpResponse)
10		{
11	10	$body = $httpResponse->getBody();
12
13	10	$normalizedResponse = $this->getNormalizedResponse($body);
14
15	4	return new Response($normalizedResponse['data'], $normalizedResponse['errors']);
16		}
17
18	10	private function getNormalizedResponse(string $body)
19		{
20	10	$decodedResponse = $this->getJsonDecodedResponse($body);
21
22	8	if (!array_key_exists('data', $decodedResponse)) {
23	4	throw new \UnexpectedValueException('Invalid GraphQL JSON response.');
24		}
25
26		return [
27	4	'data' => $decodedResponse['data'] ?? [],
28	2	'errors' => $decodedResponse['errors'] ?? [],
29		];
30		}
31
32	10	private function getJsonDecodedResponse(string $body)
33		{
34	10	$response = json_decode($body, true);
35
36	10	$error = json_last_error();
37	10	if (JSON_ERROR_NONE !== $error) {
38	2	throw new \UnexpectedValueException('Invalid JSON response.');
39		}
40	8	return $response;
41		}
42		}
43

softonic / graphql-client

Branch — master (c90d5b)

ResponseBuilder::getJsonDecodedResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like