View GitHub Repository graphql-client

Schedule Inspection
Subscribe
Completed
Pull Request — master (#43)
by Jose Manuel
02:54
created

ObjectHandler   A

↳ Parent: Project

Complexity

Total Complexity 3

Size/Duplication

Total Lines 12
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 0

Test Coverage

Coverage 100%

Importance

Changes 0
Metric Value
wmc 3
lcom 1
cbo 0
dl 0
loc 12
ccs 5
cts 5
cp 1
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A toArray() 0 9 3
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace Softonic\GraphQL\DataObjects\Traits;

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                        
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
trait ObjectHandler

            


            
                                                                        
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                             24                         
                
                
                
    public function toArray(): array

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
    {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                             24                         
                
                
                
        $item = [];

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                             24                         
                
                
                
        foreach ($this->arguments as $key => $value) {

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The property arguments does not exist. Did you maybe forget to declare it?
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
In PHP it is possible to write to properties without declaring them. For example,
the following is perfectly valid PHP code:


class MyClass { }

$x = new MyClass();
$x->foo = true;





Generally, it is a good practice to explictly declare properties to avoid
accidental typos and provide IDE auto-completion:


class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;





                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                             24                         
                
                
                
            $item[$key] = $value instanceof \JsonSerializable ? $value->toArray() : $value;

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The class JsonSerializable does not exist. Did you forget a USE statement, or did you not list all dependencies?
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This error could be the result of:




1. Missing dependencies


PHP Analyzer uses your composer.json file (if available) to determine the
dependencies of your project and to determine all the available classes and functions.
It expects the composer.json to be in the root folder of your repository.


Are you sure this class is defined by one of your dependencies, or did you maybe
not list a dependency in either the require or require-dev section?






2. Missing use statement


PHP does not complain about undefined classes in ìnstanceof checks. For
example, the following PHP code will work perfectly fine:


if ($x instanceof DoesNotExist) {
    // Do something.
}





If you have not tested against this specific condition, such errors might go
unnoticed.




                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
        }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                             24                         
                
                
                
        return $item;

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    17