JsonSerializer::jsonSerialize() - Code Metrics - Inspection of "Added query to mutation logic" - softonic/graphql-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#29)

unknown

created 2019-11-21 14:35 UTC

JsonSerializer::jsonSerialize() A

↳ Parent: JsonSerializer

Complexity

Conditions	4
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	8
cts	8
cp	1
rs	9.7666
c	0
b	0
f	0
cc	4
nc	2
nop	0
crap	4

<?php

namespace Softonic\GraphQL\Traits;

trait JsonSerializer
{
    public function jsonSerialize(): array
    {
        $item = [];
        if ($this->hasChanged()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            foreach ($this->arguments as $key => $value) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                if ($value instanceof \JsonSerializable) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                    $item[$key] = $value->jsonSerialize();
                } else {
                    $item[$key] = $value;
                }
            }
        }

        return $item;
    }

    public function toArray(): array
    {
        $item = [];
        foreach ($this->arguments as $key => $value) {
            if ($value instanceof \JsonSerializable) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                $item[$key] = $value->toArray();
            } else {
                $item[$key] = $value;
            }
        }

        return $item;
    }
}


1		<?php
2
3		namespace Softonic\GraphQL\Traits;
4
5		trait JsonSerializer
6		{
7	34	public function jsonSerialize(): array
8		{
9	34	$item = [];
10	34	if ($this->hasChanged()) {
		0 ignored issues – show Bug introduced 2019-11-21 14:41 UTC by Report Bug Copy Issue Report It seems like `hasChanged()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
11	32	foreach ($this->arguments as $key => $value) {
		0 ignored issues – show Bug introduced 2019-11-21 14:41 UTC by Report Bug Copy Issue Report The property `arguments` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
12	32	if ($value instanceof \JsonSerializable) {
		0 ignored issues – show Bug introduced 2019-11-21 14:41 UTC by Report Bug Copy Issue Report The class `JsonSerializable` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
13	28	$item[$key] = $value->jsonSerialize();
14		} else {
15	32	$item[$key] = $value;
16		}
17		}
18		}
19
20	34	return $item;
21		}
22
23	12	public function toArray(): array
24		{
25	12	$item = [];
26	12	foreach ($this->arguments as $key => $value) {
27	12	if ($value instanceof \JsonSerializable) {
		0 ignored issues – show Bug introduced 2019-11-21 14:41 UTC by Report Bug Copy Issue Report The class `JsonSerializable` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
28	10	$item[$key] = $value->toArray();
29		} else {
30	12	$item[$key] = $value;
31		}
32		}
33
34	12	return $item;
35		}
36		}
37

softonic / graphql-client

Pull Request — master (#29)

JsonSerializer::jsonSerialize() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like