Quantum\Libraries\Cache\CacheManager::getHandler()

Complexity

Conditions	3
Paths	4

Size

Total Lines	17
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function getHandler()
    {
        if (!config()->has('cache')) {
            config()->import(new Setup('Config', 'cache'));
        }

        $cacheDriver = config()->get('cache.current');

        if (!in_array($cacheDriver, self::DRIVERS)) {
            throw new \Exception();
        }

        $cacheAdapterClass = __NAMESPACE__ . '\\Adapters\\' . ucfirst($cacheDriver) . 'Cache';

It seems like $cacheDriver can also be of type null; however, parameter $string of ucfirst() does only seem to accept string, maybe add an additional type check?

        $cacheAdapter = new $cacheAdapterClass(config()->get('cache.' . $cacheDriver . '.params'));
        
        return new Cache($cacheAdapter);

The expression return new Quantum\Libraries\Cache\Cache($cacheAdapter) returns the type Quantum\Libraries\Cache\Cache which is incompatible with the documented return type Psr\SimpleCache\CacheInterface.

    }